From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Wilfred Hughes Newsgroups: gmane.emacs.bugs Subject: bug#24863: Functions declared as side-effect-free do not generate warnings in the same file Date: Wed, 2 Nov 2016 20:59:39 -0400 Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: blaine.gmane.org 1478134951 2693 195.159.176.226 (3 Nov 2016 01:02:31 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 3 Nov 2016 01:02:31 +0000 (UTC) To: 24863@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 03 02:02:26 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c26Py-00065G-3B for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Nov 2016 02:02:10 +0100 Original-Received: from localhost ([::1]:58415 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c26Pz-00006C-Tq for geb-bug-gnu-emacs@m.gmane.org; Wed, 02 Nov 2016 21:02:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59943) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c26Pt-000067-NN for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2016 21:02:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c26Pq-0005Wb-IU for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2016 21:02:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53837) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c26Pq-0005WX-FQ for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2016 21:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c26Pq-0007jr-7T for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2016 21:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Wilfred Hughes Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Nov 2016 01:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 24863 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.147813488329701 (code B ref -1); Thu, 03 Nov 2016 01:02:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 3 Nov 2016 01:01:23 +0000 Original-Received: from localhost ([127.0.0.1]:41003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c26PC-0007iz-P6 for submit@debbugs.gnu.org; Wed, 02 Nov 2016 21:01:23 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c26PA-0007im-Dh for submit@debbugs.gnu.org; Wed, 02 Nov 2016 21:01:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c26P4-0005JA-D3 for submit@debbugs.gnu.org; Wed, 02 Nov 2016 21:01:15 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:58770) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c26P4-0005J3-AE for submit@debbugs.gnu.org; Wed, 02 Nov 2016 21:01:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59798) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c26P3-0008Ue-12 for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2016 21:01:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c26Oz-0005IC-UY for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2016 21:01:13 -0400 Original-Received: from mail-qk0-f170.google.com ([209.85.220.170]:33723) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c26Oz-0005Gn-PT for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2016 21:01:09 -0400 Original-Received: by mail-qk0-f170.google.com with SMTP id x190so37835700qkb.0 for ; Wed, 02 Nov 2016 18:01:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wilfred-me-uk.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=9UeKs14Y/ZIhQHpFuQMlVYTlC618m5roV8LEZ5WmDlU=; b=rZS+8h71RRP0fFWYijPIfc2PTphpLvg0Py06gJrAbCQOBFV4OAsr1eK7KcFzH3ljPZ onU57DqRqUVK3dWLfjKNS7UfjiYCSY/EmpXvPWMbk0omWT6sIPsJW2iHa9tnPJ44Jxru ySEs8KQWBmThWmV+I2X3KRa6esnRsq1MOW3dnomyb7kGqX7MZ5bHVWjPYWl7WAYeaA1N Ur6lTxHH9ueAw7b48Dejn1ex4jkB7PUf7K0SUTNJWSkiQU3EQ/AJHWg6hxMhLn7CvJS0 oyhGE37bV8Kq3wARR+8yrOcRu9ov21IHwUA+TfNOE8Yls2bIZ7mzNAzdY+dTrIw1rd/6 tiHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=9UeKs14Y/ZIhQHpFuQMlVYTlC618m5roV8LEZ5WmDlU=; b=b051N74H9/WilcJONJO5vBs2KRZDJ2Jmkt4yoMIC1qAqULn+hiVPjvgTw85BT9xYmh tsaLp54EaaUVlqPtreUr5rYj+NtJCDcO9ICcKIdXxCNxx4SszRvZnFjp8YsE/rnIX9tI ykLcIQyvXfm6LZQjUsB3yfHREfZo2B4+SvWBV9KkKgQzyegLaOrOcJ57xp5MIPQeFjzS WyyLhglefjyFFGxCz5eGeUf7d5CkZ0gn61fXgZJEd1SaObv1g8H4UnWpLRt1Vt7cmuD1 yblCqPJ3Xou+347UQDDznUBEuXjYL0C2q7JTha+OvVX2/N/aWcGd5o9h/u6OWfoDbyFv UzYg== X-Gm-Message-State: ABUngveh254KpoyBtxuDQOFdTT7bG8qncIxgOAzu6WoV5icN9HMHBhQISVKxFGk14OLeHC9+LmApeE715R9Hlg== X-Received: by 10.55.215.220 with SMTP id t89mr5292046qkt.27.1478134799683; Wed, 02 Nov 2016 17:59:59 -0700 (PDT) Original-Received: by 10.237.36.48 with HTTP; Wed, 2 Nov 2016 17:59:39 -0700 (PDT) X-Originating-IP: [65.206.63.10] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125286 Archived-At: If I declare a function as side-effect-free, I do not get warnings when I call it for side effects: (defun foo-pure (x) (declare (side-effect-free t)) x) (defun foo-calls-pure () ;; No warning here: (foo-pure 1) 12) However, if I define foo-pure in a standalone file and byte-compile it, I get byte-compile warnings when I define foo-calls-pure in a second file. As mentioned in http://emacs.stackexchange.com/a/28341/304 , the problem is that side-effect-free is added to the function symbol plist at the wrong time. This can be worked around with: (eval-and-compile (function-put 'foo-pure 'side-effect-free 't)) before defining foo-calls-pure. However, ideally this wouldn't be required. I think it's just a matter of changing defun-declarations-alist to: (list 'side-effect-free #'(lambda (f _args val) `(eval-and-compile (function-put ',f 'side-effect-free ',val))) "If non-nil, calls can be ignored if their value is unused. If `error-free', drop calls even if `byte-compile-delete-errors' is nil.")