From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Javier Olaechea Newsgroups: gmane.emacs.bugs Subject: bug#66144: 29.1; eglot-shutdown request params violate JSONRPC Date: Sat, 7 Oct 2023 22:42:47 -0500 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000000f0c4306072c45a7" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22225"; mail-complaints-to="usenet@ciao.gmane.io" To: "bug#66144" <66144@debbugs.gnu.org> Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 08 05:44:06 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qpKi6-0005Zg-5y for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 08 Oct 2023 05:44:06 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qpKhl-0000ZQ-Ml; Sat, 07 Oct 2023 23:43:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qpKhi-0000Z9-R7 for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2023 23:43:44 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qpKhi-0008A9-FX for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2023 23:43:42 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qpKi2-0002AS-5y for bug-gnu-emacs@gnu.org; Sat, 07 Oct 2023 23:44:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Javier Olaechea Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Oct 2023 03:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66144 X-GNU-PR-Package: emacs Original-Received: via spool by 66144-submit@debbugs.gnu.org id=B66144.16967366078279 (code B ref 66144); Sun, 08 Oct 2023 03:44:02 +0000 Original-Received: (at 66144) by debbugs.gnu.org; 8 Oct 2023 03:43:27 +0000 Original-Received: from localhost ([127.0.0.1]:56131 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpKhS-00029S-UU for submit@debbugs.gnu.org; Sat, 07 Oct 2023 23:43:27 -0400 Original-Received: from mail-yw1-x112e.google.com ([2607:f8b0:4864:20::112e]:56374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qpKhR-00029F-4B for 66144@debbugs.gnu.org; Sat, 07 Oct 2023 23:43:25 -0400 Original-Received: by mail-yw1-x112e.google.com with SMTP id 00721157ae682-5a24b03e22eso42128397b3.0 for <66144@debbugs.gnu.org>; Sat, 07 Oct 2023 20:43:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696736579; x=1697341379; darn=debbugs.gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=FSonRqX3uUFUwcAWDPOzPVPnLOaPgtao75JQGM+H1VQ=; b=Ve55G19HSGAikgF1cQMEwGy4QtqByuNyuJwJ9OK+nTbtd6YypVVvhCn2ARiiHMvQEn 80KTqCUCtr/uF0MmuE2ZLE7ENLtZbzDasox9+52hKbKM9RN4vGkzv0Xx6B6X5BNGHbeT tASu6yqZDE6bR6rQW2q6Lwecnj+YG8cXzDQPU9XbnpXEeeOQnUuZXtHVmGehy8N8Yzy6 B+lsyl4Ym8iThZnyUiOveZoD8FRvKZlK6rPch2SKD+HVHM48iry8DkerBjcM7IjuYO6u /v/886SOFDP8yFxJoCYxJtU2mr0sXhDCoN+xDxbx7tuAMaYL3FpjZIOJt9Qo8n94Wjqc XeSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696736579; x=1697341379; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=FSonRqX3uUFUwcAWDPOzPVPnLOaPgtao75JQGM+H1VQ=; b=Z2/0nm2WO0Q1rcwOzXs/NngQ9kKTDyx7teu/H9SZFj6/7pHsJ+4nC+rpBa1tBZmRU3 Wk1gm6lHmRXLCYctIWQHv1FNLZhaQRqt/E0VkAfT5r4+XBfbrP8dB3NIGPI+yqOTbIgW J88tr99OjsIw5S6CA9pogbvETbfTZxcfGamoSY+FN3L/gSqly0+9BWhyHC/WB/3CaAy1 5837wxy5JI69agJrCpDZSgogPrzqf+RzfMc3fse9xSIwvjUTs9nhO60yLQCz7fqDVnpI lUahVzYv48/5RzQCouLxUkrdjIIhz5lVHevkE1oLNPru0k6+Tl7nPAFwHTdKGPbXcpp5 4F4Q== X-Gm-Message-State: AOJu0YyroTSWmw+DLbe4fMHn7SOGKER7mc9/3j+pab0WhsEYeLCeDSLq 4CHLF8lDl6dLg8/taxBuHGHnDPfgOmTH7DZsC3Tq4v0zONM= X-Google-Smtp-Source: AGHT+IGpEaR/0AaTYvLlx/oT3c0Wp/Rb7umzTpdfLOxpeW9IAJy39RrGbNG5+uxgcEPCDacEVzgTq8iw4XYOj/5EmPY= X-Received: by 2002:a81:5482:0:b0:59b:8da4:dc2 with SMTP id i124-20020a815482000000b0059b8da40dc2mr12157974ywb.48.1696736578831; Sat, 07 Oct 2023 20:42:58 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272056 Archived-At: --0000000000000f0c4306072c45a7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable It seems that eglot used to send an empty object as the params but it got replaced by null to appease gopls. https://github.com/joaotavora/eglot/commit/4f6e152e1c5efc39a888f747ecca313a= 58f4375e The fix would be replacing the call (jsonrpc-request server :shutdown nil :timeout (or timeout 1.5)) with (jsonrpc-request server :shutdown eglot--{} :timeout (or timeout 1.5)) --=20 "I object to doing things that computers can do." =E2=80=94 Olin Shivers --0000000000000f0c4306072c45a7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
It seems that eglot used to send an empty object= as the params but it got replaced by null to appease gopls.

https://github.com/joaotavora/eglot/commit/4f6e152e1c5efc39a8= 88f747ecca313a58f4375e

The fix would be replacing the call=
(jsonrpc-request server :shutdown nil :timeout (or timeout 1.5))
with
(jsonrpc-request server :shutdown eglot--{} :timeout= (or timeout 1.5))

--
"I object to doing things that computers can do.&= quot; =E2=80=94 Olin Shivers
--0000000000000f0c4306072c45a7--