From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Javier Olaechea Newsgroups: gmane.emacs.bugs Subject: bug#70145: [PATCH] Add sqlite-execute-batch command Date: Tue, 2 Apr 2024 13:52:12 -0500 Message-ID: References: <86bk6rag67.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000004d18700615219b5c" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25920"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70145@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 02 20:53:29 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rrjGC-0006T9-Hd for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Apr 2024 20:53:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rrjFp-0003C5-88; Tue, 02 Apr 2024 14:53:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rrjFj-0003Bo-Uq for bug-gnu-emacs@gnu.org; Tue, 02 Apr 2024 14:53:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rrjFj-00015M-MJ for bug-gnu-emacs@gnu.org; Tue, 02 Apr 2024 14:52:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rrjFn-0001NG-7j for bug-gnu-emacs@gnu.org; Tue, 02 Apr 2024 14:53:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Javier Olaechea Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Apr 2024 18:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70145 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70145-submit@debbugs.gnu.org id=B70145.17120839555098 (code B ref 70145); Tue, 02 Apr 2024 18:53:02 +0000 Original-Received: (at 70145) by debbugs.gnu.org; 2 Apr 2024 18:52:35 +0000 Original-Received: from localhost ([127.0.0.1]:56337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rrjFL-0001KA-0o for submit@debbugs.gnu.org; Tue, 02 Apr 2024 14:52:35 -0400 Original-Received: from mail-yb1-xb2f.google.com ([2607:f8b0:4864:20::b2f]:44455) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rrjFJ-0001JT-I6 for 70145@debbugs.gnu.org; Tue, 02 Apr 2024 14:52:34 -0400 Original-Received: by mail-yb1-xb2f.google.com with SMTP id 3f1490d57ef6-dcc84ae94c1so5186917276.1 for <70145@debbugs.gnu.org>; Tue, 02 Apr 2024 11:52:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712083944; x=1712688744; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=p/W+JUVJWyzWFmW1/IDa2TszGYO0/bpvcdj3Z9SGzs0=; b=iL0c3GYpdThm7bIWpw6FTPSobqXtz5hkchE6Iw0bOpyqOE32G9K1h2qcrE85cTjPsK Dzr1DF2RLpco1LFLOUz1VZKG4stJS51eYonm0Wt+euWqz/Io7wWLKr8vWYbueO4zOuzD t5TRg9QuQtzEdng3Bq+S1L0oo5HxwqOrwo/S3Gcg5QopwWYfjFnlnnLV2BVn4vVZ+iYl WoMDMkz4IYi08cvhFHVwynn+6RI680ArQZjTEd656uLGEbFKaXAuyeXt+2Pt3qKpFBdr 7EiC7b2E4n80EpRbLUts3H7GXuSHNziXxkT3S0oeWaDn/d2MN+cF3Dcwi+b+wa1ilJcy HVzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712083944; x=1712688744; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=p/W+JUVJWyzWFmW1/IDa2TszGYO0/bpvcdj3Z9SGzs0=; b=Eoga+r6pOMoBVvdzcwVlnlHkGLXGgvi2DECg010sUQs/UkjOSjS5J13zAsRVGLCPE5 Do7LXzyi07eInCMkRNfq4giRkomsbNTO7UwDTEhsNiOt0MWpNoQ6UEmoJi9ZrtUlWaoD zRc/VRCBuOJIvaWabGM0q1NG48WaeIdGxwa16aHWcpcpXFpoey2q6GRSVdo8iAVGgGgS HKsm/KK9c7g/oZwtihiENXECppP9o17MaB5no02aR29uvVzymA/sJX+zVT2TdXOwpNTF cCtAq8l5qnNA7H0U/eNTHnFzCv5sKxKfIUkMzZSj/NM7rsW0LSqUzQmqyyfNvTkBITJj 2kZA== X-Gm-Message-State: AOJu0YwN2gYqs/mRBAzqG/jKMSOjtwqOm+lZGvTMxCKL1e8wPccoGCwb xeRCQl58mc9sa0Y34XBVUpUMf5wIexlcXMaxQwOtN6Lc79W1Fb9RSF9GgYfkYzOTNemkROrdIQP 3+o7hGlP0pqnJTI3eTpkGj4hxADk= X-Google-Smtp-Source: AGHT+IGRGAb9SKNa2NdhiSIGOuTi8Cn69zeEClBMYJZ8D50z452a7lA7aVoCouJl0rFrsm5gCd+aMFpft3HYn3EdQuo= X-Received: by 2002:a25:bac6:0:b0:dcf:bc57:cd61 with SMTP id a6-20020a25bac6000000b00dcfbc57cd61mr11914222ybk.50.1712083943881; Tue, 02 Apr 2024 11:52:23 -0700 (PDT) In-Reply-To: <86bk6rag67.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282542 Archived-At: --0000000000004d18700615219b5c Content-Type: multipart/alternative; boundary="0000000000004d186e0615219b5a" --0000000000004d186e0615219b5a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks, I've updated the patch according to the feedback. Btw I have a basic test for the functionality which I used to validate the code before submitting the patch. Should I include it in test/sqlite-tests.el? --=20 "I object to doing things that computers can do." =E2=80=94 Olin Shivers --0000000000004d186e0615219b5a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, I've updated the patch according to the f= eedback.

Btw I have a basic test for the func= tionality which I used to validate the code before submitting the patch. Sh= ould I include it in test/sqlite-tests.el?

--
&q= uot;I object to doing things that computers can do." =E2=80=94 Olin Sh= ivers
--0000000000004d186e0615219b5a-- --0000000000004d18700615219b5c Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Add-sqlite-execute-batch-command.patch" Content-Disposition: attachment; filename="0001-Add-sqlite-execute-batch-command.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_luiqadtn0 RnJvbSA2Yzk4NDc5OWEzOTM2MzAwYmJkZTYyZTI0Y2NlMjFkZTE5ZmEzYjNmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYXZpZXIgT2xhZWNoZWEgPHBpcmF0YUBnbWFpbC5jb20+CkRh dGU6IFN1biwgMzEgTWFyIDIwMjQgMjM6MDc6MTAgLTA1MDAKU3ViamVjdDogW1BBVENIXSBBZGQg c3FsaXRlLWV4ZWN1dGUtYmF0Y2ggY29tbWFuZAoKVGhpcyBjb21tYW5kIGlzIHNpbWlsYXIgdG8g c3FsaXRlLWV4ZWN1dGUgZXhjZXB0IHRoYXQgaXQgZXhlY3V0ZXMKbXVsdGlwbGUgc3RhdGVtZW50 cyBpbiBleGNoYW5nZSBmb3Igbm90IGFjY2VwdGluZyBhbnkgYXJndW1lbnRzLgoKKiBkb2MvbGlz cHJlZi90ZXh0LnRleGkgKERhdGFiYXNlKTogRG9jdW1lbnQgaXQuCiogc3JjL3NxbGl0ZS5jIChG c3FsaXRlX2V4ZWN1dGVfYmF0Y2gpOiBBZGQgc3FsaXRlX2V4ZWN1dGVfYmF0Y2gKY29tbWFuZC4g IEl0IGlzIHNpbWlsYXIgdG8gc3FsaXRlLWV4ZWN1dGUgYnV0IGl0IGV4ZWN1dGVzIGFsbCB0aGUK c3RhdGVtZW50cyBpbiB0aGUgcXVlcnkuICBVbmxpa2Ugc3FsaXRlLWV4ZWN1dGUgdGhlIGNvbW1h bmQgZG9lc24ndCB0YWtlCmFueSBhcmd1bWVudHMgdG8gcGFzcyBkb3duIHRvIHRoZSBzdGF0ZW1l bnRzLgotLS0KIGRvYy9saXNwcmVmL3RleHQudGV4aSB8ICA4ICsrKysrKysrCiBzcmMvc3FsaXRl LmMgICAgICAgICAgfCAxMiArKysrKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMjAgaW5zZXJ0 aW9ucygrKQoKZGlmZiAtLWdpdCBhL2RvYy9saXNwcmVmL3RleHQudGV4aSBiL2RvYy9saXNwcmVm L3RleHQudGV4aQppbmRleCA5MGUyYzZjZTg4Mi4uZjFmOGY4MTM5ODEgMTAwNjQ0Ci0tLSBhL2Rv Yy9saXNwcmVmL3RleHQudGV4aQorKysgYi9kb2MvbGlzcHJlZi90ZXh0LnRleGkKQEAgLTU0MDQs NiArNTQwNCwxNCBAQCBEYXRhYmFzZQogCiBAZW5kIGRlZnVuCiAKK0BkZWZ1biBzcWxpdGUtZXhl Y3V0ZS1iYXRjaCBkYiBzdGF0ZW1lbnRzCitFeGVjdXRlIHRoZSBAYWNyb255bXtTUUx9IEB2YXJ7 c3RhdGVtZW50c30uICBAdmFye3N0YXRlbWVudHN9IGlzIGEKK3N0cmluZyBjb250YWluaW5nIDAg b3IgbW9yZSBAYWNyb255bXtTUUx9IHN0YXRlbWVudHMuICBUaGlzIGNvbW1hbmQKK21pZ2h0IGJl IHVzZWZ1bCB3aGVuIHdlIHdhbnQgdG8gZXhlY3V0ZSBtdWx0aXBsZSBAYWNyb255bXtEREx9Citz dGF0ZW1lbnRzLgorCitAZW5kIGRlZnVuCisKIEBkZWZ1biBzcWxpdGUtc2VsZWN0IGRiIHF1ZXJ5 ICZvcHRpb25hbCB2YWx1ZXMgcmV0dXJuLXR5cGUKIFNlbGVjdCBzb21lIGRhdGEgZnJvbSBAdmFy e2RifSBhbmQgcmV0dXJuIHRoZW0uICBGb3IgaW5zdGFuY2U6CiAKZGlmZiAtLWdpdCBhL3NyYy9z cWxpdGUuYyBiL3NyYy9zcWxpdGUuYwppbmRleCAyNjEwODBkYTY3My4uYzYwNmZhNWY4MzEgMTAw NjQ0Ci0tLSBhL3NyYy9zcWxpdGUuYworKysgYi9zcmMvc3FsaXRlLmMKQEAgLTY0Niw2ICs2NDYs MTcgQEAgc3FsaXRlX2V4ZWMgKHNxbGl0ZTMgKnNkYiwgY29uc3QgY2hhciAqcXVlcnkpCiAgIHJl dHVybiBRdDsKIH0KIAorREVGVU4gKCJzcWxpdGUtZXhlY3V0ZS1iYXRjaCIsIEZzcWxpdGVfZXhl Y3V0ZV9iYXRjaCwgU3NxbGl0ZV9leGVjdXRlX2JhdGNoLCAyLCAyLCAwLAorICAgICAgIGRvYzog LyogRXhlY3V0ZSBtdWx0aXBsZSBTUUwgc3RhdGVtZW50cyBpbiBEQi4KK1F1ZXJ5IGlzIGEgc3Ry aW5nIGNvbnRhaW5pbmcgMCBvciBtb3JlIFNRTCBzdGF0ZW1lbnRzLiAgKi8pCisgIChMaXNwX09i amVjdCBkYiwgTGlzcF9PYmplY3QgcXVlcnkpCit7CisgIGNoZWNrX3NxbGl0ZSAoZGIsIGZhbHNl KTsKKyAgQ0hFQ0tfU1RSSU5HIChxdWVyeSk7CisgIExpc3BfT2JqZWN0IGVuY29kZWQgPSBlbmNv ZGVfc3RyaW5nKHF1ZXJ5KTsKKyAgcmV0dXJuIHNxbGl0ZV9leGVjIChYU1FMSVRFIChkYiktPmRi LCBTU0RBVEEgKGVuY29kZWQpKTsKK30KKwogREVGVU4gKCJzcWxpdGUtdHJhbnNhY3Rpb24iLCBG c3FsaXRlX3RyYW5zYWN0aW9uLCBTc3FsaXRlX3RyYW5zYWN0aW9uLCAxLCAxLCAwLAogICAgICAg IGRvYzogLyogU3RhcnQgYSB0cmFuc2FjdGlvbiBpbiBEQi4gICovKQogICAoTGlzcF9PYmplY3Qg ZGIpCkBAIC04NjYsNiArODc3LDcgQEAgc3ltc19vZl9zcWxpdGUgKHZvaWQpCiAgIGRlZnN1YnIg KCZTc3FsaXRlX2Nsb3NlKTsKICAgZGVmc3ViciAoJlNzcWxpdGVfZXhlY3V0ZSk7CiAgIGRlZnN1 YnIgKCZTc3FsaXRlX3NlbGVjdCk7CisgIGRlZnN1YnIgKCZTc3FsaXRlX2V4ZWN1dGVfYmF0Y2gp OwogICBkZWZzdWJyICgmU3NxbGl0ZV90cmFuc2FjdGlvbik7CiAgIGRlZnN1YnIgKCZTc3FsaXRl X2NvbW1pdCk7CiAgIGRlZnN1YnIgKCZTc3FsaXRlX3JvbGxiYWNrKTsKLS0gCjIuMjkuMi4xNTQu ZzdmN2ViZTA1NGEKCg== --0000000000004d18700615219b5c Content-Type: text/x-emacs-lisp; charset="UTF-8"; name="smoke.el" Content-Disposition: attachment; filename="smoke.el" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_luiqiaxk1 OzsgLSotIGxleGljYWwtYmluZGluZzogdCAtKi0KCihyZXF1aXJlICdlcnQpCgooZXJ0LWRlZnRl c3Qgd2l0aC1zcWxpdGUtZXhlY3V0ZS1iYXRjaC10ZXN0ICgpCiAgKGxldCAoKGRiIChzcWxpdGUt b3BlbiBuaWwpKQogICAgICAgIChxdWVyeSAod2l0aC10ZW1wLWJ1ZmZlcgogICAgICAgICAgICAg ICAgIChpbnNlcnQgIi0tIC0qLSBzcWwtcHJvZHVjdDogc3FsaXRlIC0qLQoKLS0gSSDwn5KYIGVt b2ppcwoKQ1JFQVRFIFRBQkxFIHNldHRpbmdzICgKICBuYW1lIFRFWFQgTk9UIE5VTEwsCiAgdmFs dWUgVEVYVCwKICBzZWN0aW9uIFRFWFQgTk9UIE5VTEwsCiAgUFJJTUFSWSBLRVkgKHNlY3Rpb24s IG5hbWUpCik7CgpDUkVBVEUgVEFCTEUgdGFncyAoCiAgbmFtZSBURVhUIFBSSU1BUlkgS0VZIE5P VCBOVUxMCik7CgotLSBDUkVBVEUgVEFCTEUgdG9kb19zdGF0ZXMgKGlkIElOVEVHRVIgUFJJTUFS WSBLRVksIG5hbWUgVEVYVCBOT1QgTlVMTCk7CiIpCiAgICAgICAgICAgICAgICAgKGJ1ZmZlci1z dHJpbmcpKSkpCiAgICAoc3FsaXRlLWV4ZWN1dGUtYmF0Y2ggZGIgcXVlcnkpCiAgICAoc2hvdWxk IChlcXVhbCAnKCgic2V0dGluZ3MiKSAoInRhZ3MiKSkKICAgICAgICAgICAgICAgICAgIChzcWxp dGUtc2VsZWN0IGRiICJzZWxlY3QgbmFtZSBmcm9tIHNxbGl0ZV9tYXN0ZXIgd2hlcmUgdHlwZSA9 ICd0YWJsZScgYW5kIG5hbWUgbm90IGxpa2UgJ3NxbGl0ZV8lJyBvcmRlciBieSBuYW1lIikpKSkp Cg== --0000000000004d18700615219b5c--