bug#16445: Regression: ff-find-other-file doesn't update frame title

bug#16445: Regression: ff-find-other-file doesn't update frame title

[Barry OReilly]

[-- Attachment #1: Type: text/plain, Size: 489 bytes --]

I use ff-find-other-file to switch between .h and .cc C++ files, using
Emacs as an X11 window (Emacs frame). The title for the X11 window does not
update itself when I switch between the two buffers with this command. eg
if I'm in Foo.cc and the title shows Foo.cc, I do ff-find-other-file and
successfully switch to Foo.h, but the title says Foo.cc. If I use the
buffer-menu to go to Foo.h, the title updates fine.

I tested with emacs-24.3 and don't witness the problem.

I'm on RHEL 5.

[-- Attachment #2: Type: text/html, Size: 545 bytes --]

bug#16445: Acknowledgement (Regression: ff-find-other-file doesn't update frame title)

[Barry OReilly]

[-- Attachment #1: Type: text/plain, Size: 703 bytes --]

This depends on some customization of mine. Here's a -Q recipe using a
distillation of my init.

Let /tmp/title-redisplay.el have content:

  (defun my-get-buffer-name ()
    "Get the buffer name. "
    (file-name-nondirectory (or (buffer-file-name)
                                (buffer-name)
                                default-directory)))
  (setq-default frame-title-format '(:eval (my-get-buffer-name)))
  (add-hook 'emacs-startup-hook 'delete-other-windows)
  (global-set-key (kbd "<f4>") 'ff-find-other-file)

cd to the src directory of the Emacs source tree and:

  ./emacs -Q --load /tmp/title-redisplay.el character.h character.c

Then f4, and you'll see the frame title doesn't update.

[-- Attachment #2: Type: text/html, Size: 847 bytes --]

bug#16445: Regression: ff-find-other-file doesn't update frame title

[Stefan Monnier]

> I use ff-find-other-file to switch between .h and .cc C++ files, using
> Emacs as an X11 window (Emacs frame). The title for the X11 window does not
> update itself when I switch between the two buffers with this command. eg
> if I'm in Foo.cc and the title shows Foo.cc, I do ff-find-other-file and
> successfully switch to Foo.h, but the title says Foo.cc. If I use the
> buffer-menu to go to Foo.h, the title updates fine.

Can't reproduce it here.  I tried

  emacs -Q --eval "(global-set-key [?\C-o] 'ff-find-other-file)"
  C-x 5 f src/buffer.c

and then in the frame that displays buffer.c I did

  C-o

But the problem did not manifest itself.
  

        Stefan

bug#16445: Regression: ff-find-other-file doesn't update frame title

[Barry OReilly]

[-- Attachment #1: Type: text/plain, Size: 328 bytes --]

> Can't reproduce it here.  I tried
>
>   emacs -Q --eval "(global-set-key [?\C-o] 'ff-find-other-file)"
>   C-x 5 f src/buffer.c
>
> and then in the frame that displays buffer.c I did
>
>   C-o
>
> But the problem did not manifest itself.

Did you see the more detailed recipe I provided shortly after the original
submission?

[-- Attachment #2: Type: text/html, Size: 476 bytes --]

bug#16445: Regression: ff-find-other-file doesn't update frame title

[Stefan Monnier]

> Did you see the more detailed recipe I provided shortly after the original
> submission?

Sorry, I'd forgotten about it, but I just tried it and it doesn't
reproduce the problem for me either.


        Stefan

bug#16445: Regression: ff-find-other-file doesn't update frame title

[Barry OReilly]

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

I tried with the latest trunk version and couldn't reproduce it
either, so closing.

I have been using the commit before the one that introduced bug 16434,
which is a version this bug manifests in.

[-- Attachment #2: Type: text/html, Size: 244 bytes --]