From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Barry OReilly Newsgroups: gmane.emacs.bugs Subject: bug#16411: undo-only bugs Date: Fri, 10 Jan 2014 22:48:34 -0500 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7b33d5a08efd3f04efa9b7de X-Trace: ger.gmane.org 1389412152 22276 80.91.229.3 (11 Jan 2014 03:49:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 11 Jan 2014 03:49:12 +0000 (UTC) Cc: 16411@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 11 04:49:17 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W1pZU-0000f8-Vy for geb-bug-gnu-emacs@m.gmane.org; Sat, 11 Jan 2014 04:49:17 +0100 Original-Received: from localhost ([::1]:60000 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1pZU-00014G-4p for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Jan 2014 22:49:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44434) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1pZM-000149-A0 for bug-gnu-emacs@gnu.org; Fri, 10 Jan 2014 22:49:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W1pZG-0000L0-9d for bug-gnu-emacs@gnu.org; Fri, 10 Jan 2014 22:49:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60111) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1pZG-0000Kw-6J for bug-gnu-emacs@gnu.org; Fri, 10 Jan 2014 22:49:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W1pZF-00011K-PH for bug-gnu-emacs@gnu.org; Fri, 10 Jan 2014 22:49:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Barry OReilly Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Jan 2014 03:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16411 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16411-submit@debbugs.gnu.org id=B16411.13894121203871 (code B ref 16411); Sat, 11 Jan 2014 03:49:01 +0000 Original-Received: (at 16411) by debbugs.gnu.org; 11 Jan 2014 03:48:40 +0000 Original-Received: from localhost ([127.0.0.1]:45897 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W1pYt-00010N-II for submit@debbugs.gnu.org; Fri, 10 Jan 2014 22:48:39 -0500 Original-Received: from mail-oa0-f46.google.com ([209.85.219.46]:60563) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W1pYp-000109-VX for 16411@debbugs.gnu.org; Fri, 10 Jan 2014 22:48:36 -0500 Original-Received: by mail-oa0-f46.google.com with SMTP id l6so5954038oag.33 for <16411@debbugs.gnu.org>; Fri, 10 Jan 2014 19:48:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=kPoTjxNX0PcqEi8QNIG7OicfmLAKddGzDh0wClD1hTc=; b=pEl1pn4ItAMj91Zcc7k/1eO0fEF3rkRflgSX3klRAjbxoYfwbu7hg9M/7PjLlqmT6v v6gjyIgPTAN65Op8SetTHdt5193nm3WkdAN6qRxMB0yMr2MySiOEsif6dtGNG9PBnEZJ zhez1C0e5xGJ2xJgi42LhpSa6GUJaVhawEq/yDZfAI1mpvbnWrAm36RmiSm/sXsfr9GF Z4bYoTJc07JBkYlGkBvANALOacD+ljrLmJEcIwTcDNKoU+0mf4jDDdJiRjMe9Ra2jyvI Ffk/QfUMCbYzef6nLV1YRKuU0PKEHnZWkkFnQF+utagG2St/h4oHkJW749SgkooWE/nW kq8Q== X-Received: by 10.60.93.105 with SMTP id ct9mr11347826oeb.12.1389412114954; Fri, 10 Jan 2014 19:48:34 -0800 (PST) Original-Received: by 10.76.114.74 with HTTP; Fri, 10 Jan 2014 19:48:34 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:83266 Archived-At: --047d7b33d5a08efd3f04efa9b7de Content-Type: text/plain; charset=ISO-8859-1 > undo-in-region does not implement undo-only, indeed. I think the way > to implement undo-only is to change undo-make-selective-list so it > also skips redo entries (depending on undo-no-redo, obviously) using > the above while loop. I don't see how that's a correct solution in the face of arbitrary regional undos and prefix args. Would you have the redo records resulting from regional undos still map to t in the undo-equiv-table? How does your solution account for redo records that undid several because of prefix-arg? undo-equiv-table only maps to the change group after the last undone record without information about the (1- prefix-arg) others. My proposition accounts for these considerations and I think is correct. If not I hope to find out when I start hacking it. --047d7b33d5a08efd3f04efa9b7de Content-Type: text/html; charset=ISO-8859-1
> undo-in-region does not implement undo-only, indeed. I think the way
> to implement undo-only is to change undo-make-selective-list so it
> also skips redo entries (depending on undo-no-redo, obviously) using
> the above while loop.

I don't see how that's a correct solution in the face of arbitrary
regional undos and prefix args. Would you have the redo records
resulting from regional undos still map to t in the undo-equiv-table?
How does your solution account for redo records that undid several
because of prefix-arg? undo-equiv-table only maps to the change group
after the last undone record without information about the (1-
prefix-arg) others.

My proposition accounts for these considerations and I think is
correct. If not I hope to find out when I start hacking it.

--047d7b33d5a08efd3f04efa9b7de--