From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Barry OReilly Newsgroups: gmane.emacs.devel Subject: Re: Improvements to adjust-parens Date: Mon, 25 Nov 2013 20:51:54 -0500 Message-ID: References: <5293C972.2020605@thompsonclan.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=089e013cba629d5bd904ec0ab91a X-Trace: ger.gmane.org 1385430719 3634 80.91.229.3 (26 Nov 2013 01:51:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 26 Nov 2013 01:51:59 +0000 (UTC) Cc: emacs-devel@gnu.org To: Ryan Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 26 02:52:04 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Vl7oo-0000PP-1k for ged-emacs-devel@m.gmane.org; Tue, 26 Nov 2013 02:52:02 +0100 Original-Received: from localhost ([::1]:55884 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vl7on-0007VV-J5 for ged-emacs-devel@m.gmane.org; Mon, 25 Nov 2013 20:52:01 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vl7oj-0007VP-Ls for emacs-devel@gnu.org; Mon, 25 Nov 2013 20:51:59 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vl7oi-0004yw-9K for emacs-devel@gnu.org; Mon, 25 Nov 2013 20:51:57 -0500 Original-Received: from mail-oa0-x232.google.com ([2607:f8b0:4003:c02::232]:42664) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vl7oi-0004yo-0e for emacs-devel@gnu.org; Mon, 25 Nov 2013 20:51:56 -0500 Original-Received: by mail-oa0-f50.google.com with SMTP id n16so5304301oag.37 for ; Mon, 25 Nov 2013 17:51:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=I5eYJcofKISdtU1PK2BD2cm8WQXyB/9hwHI8KiR7s08=; b=Eek1QXRgqbHpxVw9n+b8s6B+kKHe/qfDuqV+pHIsmtApaFna87v7O8Vu75wVY4nLCt 9Wx5ksqr9Y5Yv8JQYmStZcByH3KhgsBfqnNYGa8rekulpBby4XSjstOSBIUznxviO3zm DdbbNcujoV/ujzhOwX2W9Zs0F62RHzKv6knZxfzFzxbZddvmx5IfaKfQvUN3SyQHyc8c 7ArJTHHtn8x4neJh2iWSHBzBBuJuV23ss1g8s270uWjACytzdA8YSaiuwXYg+rfuFku8 EIDbSK32aINIE0FTM7jA1E9XrEFknC1sr+jJwrjD35+V9EXbEX+kZI6KQumy4W46ATR5 AmwA== X-Received: by 10.182.87.42 with SMTP id u10mr27524311obz.22.1385430714765; Mon, 25 Nov 2013 17:51:54 -0800 (PST) Original-Received: by 10.76.156.103 with HTTP; Mon, 25 Nov 2013 17:51:54 -0800 (PST) In-Reply-To: <5293C972.2020605@thompsonclan.org> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4003:c02::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:165732 Archived-At: --089e013cba629d5bd904ec0ab91a Content-Type: text/plain; charset=ISO-8859-1 > > > I have recently started to use your adjust-parens package for Emacs. I > have made a few changes to my copy that I thought you might want to > incorporate upstream. I have attached a patch of all my changes; below are > the ChangeLog entries for my changes (also inclued in the patch): > > * adjust-parens.el (adjust-parens-mode): Convert to minor mode > (global-adjust-parens-mode): Add globalized mode. Uses a custom > var to determine which modes to enable the mode in. > (adjust-parens-p): Only adjust parens after fixing indentation and > moving point to end of indentation. > (adjust-parens-and-indent): Correct handling of prefix arg. Now > only explicit numeric prefix arguments (i.e. not `C-u') affect the > number of parens adjusted, and negative & zero prefix are handled > correctly. > > * adjust-parens-tests.el (apt-mode-test): Add tests for minor mode > enabling/disabling > (apt-indent-dedent-test): Add tests for behavior when indentation > is incorrect or point is not at end of indentation > > The to main changes of interest are the conversion of adjust-parens into a > minor mode that can be enabled and disabled, and the changing the initial > behavior of the TAB key when the current line is wrongly indented or the > point is at the wrong position. I hope you find this patch useful. Please > let me know what you think of it. > > Thanks. adjust-parens is in ELPA which requires a copyright assignment to FSF for non tiny changes. I'm not sure how to check whether you're on the list of those who have completed the paperwork. --089e013cba629d5bd904ec0ab91a Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable

I have recently started to use your adjust-parens package for Emacs. I have made a few changes to my copy that I thought you might want to incorporate upstream. I have attached a patch of all my changes; below are the ChangeLog entries for my changes (also inclued in the patch):

=A0=A0=A0 * adjust-parens.el (adjust-parens-mode): Convert to minor m= ode
=A0=A0=A0 (global-adjust-parens-mode): Add globalized mode. Uses a custom
=A0=A0=A0 var to determine which modes to enable the mode in.
=A0=A0=A0 (adjust-parens-p): Only adjust parens after fixing indentat= ion and
=A0=A0=A0 moving point to end of indentation.
=A0=A0=A0 (adjust-parens-and-indent): Correct handling of prefix arg. Now
=A0=A0=A0 only explicit numeric prefix arguments (i.e. not `C-u')= affect the
=A0=A0=A0 number of parens adjusted, and negative & zero prefix a= re handled
=A0=A0=A0 correctly.

=A0=A0=A0 * adjust-parens-tests.el (apt-mode-test): Add tests for min= or mode
=A0=A0=A0 enabling/disabling
=A0=A0=A0 (apt-indent-dedent-test): Add tests for behavior when indentation
=A0=A0=A0 is incorrect or point is not at end of indentation

The to main changes of interest are the conversion of adjust-parens into a minor mode that can be enabled and disabled, and the changing the initial behavior of the TAB key when the current line is wrongly indented or the point is at the wrong position. I hope you find this patch useful. Please let me know what you think of it.

Thanks. adjust-parens is in ELPA which requires a co= pyright assignment
to FSF for non tiny changes. I'm not sure how to = check whether you're
on the list of those who have completed the pap= erwork.

--089e013cba629d5bd904ec0ab91a--