From: Barry OReilly <gundaetiapo@gmail.com>
Cc: 16411@debbugs.gnu.org
Subject: bug#16411: undo-only bugs
Date: Fri, 14 Feb 2014 13:51:38 -0500 [thread overview]
Message-ID: <CAFM41H3Ld_nqUJhQZwmfYAKxo3EotFHDc0csr7Zy4w=AEPYhJw@mail.gmail.com> (raw)
In-Reply-To: <CAFM41H3=YwZR6NpEQRr9kAcYUzL70pzf-txi51QQx2=mR2FRTQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1190 bytes --]
Here's another bug with recipe. Again, each "insert" should be a
change group.
* ./src/emacs -Q
* In *scratch* at least twice:
* Insert "aaa"
* Undo
* Select the entire buffer
* Undo in region with prefix-arg 4
* Observe the wrongful deletion of the string: "fer." in the Lisp
comment.
undo-elt-in-region has a discrepency between whether (TEXT . POSITION)
and (BEGIN . END) are in the region:
;; (BEGIN . END)
(and (>= (car undo-elt) start)
(<= (cdr undo-elt) end))
^^
;; (TEXT . POSITION)
(and (>= (abs (cdr undo-elt)) start)
(< (abs (cdr undo-elt)) end))
^
One is compared to the end by <= and the other by <. Consequently,
(192 . 195) is deemed in the region, (aaa . 192) outside the region.
With (aaa . 192) outside the region, all subsequent positions of
undo-list-copy are decremented by three, including the next (192 .
195) which becomes (189 . 192). (189 . 192) is deemed in the region,
but that's not valid given the restoration of "aaa" was just excluded.
It's now pear shaped.
I'm collecting these bugs related to the undo system in one bug report
because that is the most organized way for me to address them.
[-- Attachment #2: Type: text/html, Size: 1661 bytes --]
next prev parent reply other threads:[~2014-02-14 18:51 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 22:33 bug#16411: undo-only bugs Barry OReilly
2014-01-10 23:54 ` Stefan Monnier
2014-01-11 3:48 ` Barry OReilly
2014-01-11 4:29 ` Stefan Monnier
2014-01-11 5:09 ` Barry OReilly
2014-01-14 0:49 ` Stefan Monnier
2014-01-14 1:52 ` Stefan Monnier
2014-01-14 14:00 ` Barry OReilly
2014-01-19 0:58 ` Barry OReilly
2014-01-19 3:18 ` Stefan Monnier
2014-01-19 16:57 ` Barry OReilly
2014-02-14 18:51 ` Barry OReilly [this message]
2014-02-14 22:29 ` Barry OReilly
2014-02-18 17:40 ` Barry OReilly
2014-02-26 15:20 ` bug#16411: undo in region corrupts existing text Barry OReilly
2014-02-27 5:02 ` Stefan Monnier
2014-05-13 15:01 ` bug#16411: undo-only bugs Barry OReilly
2014-05-14 18:06 ` Stefan Monnier
2014-05-14 18:45 ` Stefan Monnier
2014-05-14 19:55 ` Stefan Monnier
2014-05-14 21:56 ` Barry OReilly
2014-05-15 2:23 ` Stefan Monnier
2014-05-15 3:51 ` Barry OReilly
2014-05-15 13:00 ` Stefan Monnier
2014-05-28 18:42 ` Barry OReilly
2014-06-19 21:35 ` Stefan Monnier
2014-05-14 13:32 ` Barry OReilly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFM41H3Ld_nqUJhQZwmfYAKxo3EotFHDc0csr7Zy4w=AEPYhJw@mail.gmail.com' \
--to=gundaetiapo@gmail.com \
--cc=16411@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.