From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Barry OReilly Newsgroups: gmane.emacs.bugs Subject: bug#16694: bugs #16694/#16378: Patches Date: Wed, 2 Apr 2014 12:47:55 -0400 Message-ID: References: <52F601AE.5040309@binary-island.eu> <87k3bj40nu.fsf@cougar.home.aneadesign.com> <83wqfiz36v.fsf@gnu.org> <5331D45B.7090704@binary-island.eu> <5335920F.4030008@binary-island.eu> <533C26F3.4040600@binary-island.eu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=089e0149cdc8dfea5e04f6120b70 X-Trace: ger.gmane.org 1396522712 2593 80.91.229.3 (3 Apr 2014 10:58:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 3 Apr 2014 10:58:32 +0000 (UTC) Cc: 16694@debbugs.gnu.org, 16434@debbugs.gnu.org, Clemens =?UTF-8?Q?Sch=C3=BCller?= To: Matthias Dahl Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 03 12:58:25 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WVeK1-00075K-C1 for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Apr 2014 11:52:33 +0200 Original-Received: from localhost ([::1]:39750 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVOKt-0007Pv-Ua for geb-bug-gnu-emacs@m.gmane.org; Wed, 02 Apr 2014 12:48:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVOKj-0007JO-5M for bug-gnu-emacs@gnu.org; Wed, 02 Apr 2014 12:48:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WVOKZ-0006Ti-8K for bug-gnu-emacs@gnu.org; Wed, 02 Apr 2014 12:48:13 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60242) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVOKZ-0006Te-5w for bug-gnu-emacs@gnu.org; Wed, 02 Apr 2014 12:48:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WVOKY-0006u1-Sf for bug-gnu-emacs@gnu.org; Wed, 02 Apr 2014 12:48:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Barry OReilly Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Apr 2014 16:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16694 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16694-submit@debbugs.gnu.org id=B16694.139645728026519 (code B ref 16694); Wed, 02 Apr 2014 16:48:02 +0000 Original-Received: (at 16694) by debbugs.gnu.org; 2 Apr 2014 16:48:00 +0000 Original-Received: from localhost ([127.0.0.1]:33190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WVOKV-0006td-RF for submit@debbugs.gnu.org; Wed, 02 Apr 2014 12:48:00 -0400 Original-Received: from mail-oa0-f54.google.com ([209.85.219.54]:33416) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WVOKS-0006tK-V8; Wed, 02 Apr 2014 12:47:57 -0400 Original-Received: by mail-oa0-f54.google.com with SMTP id n16so572334oag.41 for ; Wed, 02 Apr 2014 09:47:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=wMGUi5/p34yP2rVosMmTrW3A6kKG3VzqEzcSKUyuyQU=; b=Hq2Og/9WPsAoYtVchmD5pcME2jKDb3gf2S4HBSRhDTEW6kSrUFtUEQqL9lrazBN0SV WDd9Urp2RT4yx6yLk+/Z08FXHJrb10YWIpWbCw9djZqgRh4jYBXvdkqPjBwbD/9I28c8 qqShwpxzsmOSthHym1gT5irfaNo86VaA9GNAaeLDcADWJZ2cdw1K5QvGnVB/wCBIVBfe DX4BZImTwt0uZ1C/CT5QmIvCFf1G5Ug/zrEVA+uZvILmrJnqPXf01XsmC3IwFm2bU7cP RkJFEelFzECvivF7qC6hH8nOLoW3MRiN26U4Nm6FMDg85io0M3jqyFO1h0DF9jue+4/d P+iw== X-Received: by 10.182.118.169 with SMTP id kn9mr1004451obb.46.1396457275878; Wed, 02 Apr 2014 09:47:55 -0700 (PDT) Original-Received: by 10.76.6.44 with HTTP; Wed, 2 Apr 2014 09:47:55 -0700 (PDT) In-Reply-To: <533C26F3.4040600@binary-island.eu> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:87647 Archived-At: --089e0149cdc8dfea5e04f6120b70 Content-Type: text/plain; charset=ISO-8859-1 Hi Matthias, thank you for taking the time to update the patch series. Patch 3 undoes something patch 1 introduced, perhaps because you intended a subset of the patches for the emacs-24 branch and the rest for trunk? Could you clarify that? I applied all 4 patches and find './src/emacs -r' works correctly. However, the behavior of './src/emacs -nw -r' is different from emacs-24.3. I have my gnome-terminal configured to white on black, so 24.3's './src/emacs -nw -r' starts with white background. With your patch, './src/emacs -nw -r' starts with black background. Not that I mind the -nw behavior, but I suspect the behavioral difference is unintended. + (when (and (eq face 'default) + (frame-parameter frame 'reverse)) + (let ((fg (face-attribute face :foreground frame)) + (bg (face-attribute face :background frame))) + (set-face-attribute face frame :foreground bg :background fg)))))) Wouldn't there already be a place in code responsible for the swap? (x-handle-reverse-video and tty-handle-reverse-video?) I'm unsure why the fix would entail a new place in code responsible for it. For my information, could you confirm the effect my patch has on your theme problem? --089e0149cdc8dfea5e04f6120b70 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Hi Matthias, thank you for taking the time to update the p= atch series.

Patch 3 undoes something patch 1 introduced, perhaps be= cause you
intended a subset of the patches for the emacs-24 branch and t= he rest
for trunk? Could you clarify that?

I applied all 4 patches and find = './src/emacs -r' works correctly.
However, the behavior of '= ./src/emacs -nw -r' is different from
emacs-24.3. I have my gnome-te= rminal configured to white on black, so
24.3's './src/emacs -nw -r' starts with white background. With = your
patch, './src/emacs -nw -r' starts with black background. N= ot that I
mind the -nw behavior, but I suspect the behavioral difference= is
unintended.

+=A0=A0=A0=A0=A0 (when (and (eq face 'default)
+= =A0=A0=A0 =A0=A0=A0 =A0(frame-parameter frame 'reverse))
+=A0=A0=A0= =A0=A0=A0=A0 (let ((fg (face-attribute face :foreground frame))
+=A0=A0= =A0 =A0=A0=A0=A0=A0 (bg (face-attribute face :background frame)))
+=A0=A0=A0 =A0 (set-face-attribute face frame :foreground bg :background fg= ))))))

Wouldn't there already be a place in code responsible for= the swap?
(x-handle-reverse-video and tty-handle-reverse-video?) I'= m unsure why
the fix would entail a new place in code responsible for it.

For my = information, could you confirm the effect my patch has on your
theme pro= blem?

--089e0149cdc8dfea5e04f6120b70--