From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Barry OReilly Newsgroups: gmane.emacs.bugs Subject: bug#16411: undo in region corrupts existing text Date: Wed, 26 Feb 2014 10:20:17 -0500 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7b5d42fcfdfced04f350bd9e X-Trace: ger.gmane.org 1393428130 14480 80.91.229.3 (26 Feb 2014 15:22:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 26 Feb 2014 15:22:10 +0000 (UTC) To: 16411@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 26 16:22:19 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WIgJK-00020o-Gc for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Feb 2014 16:22:14 +0100 Original-Received: from localhost ([::1]:41301 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIgJK-0004wL-1t for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Feb 2014 10:22:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50694) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIgIG-0003UJ-4o for bug-gnu-emacs@gnu.org; Wed, 26 Feb 2014 10:21:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WIgIB-0005nj-AR for bug-gnu-emacs@gnu.org; Wed, 26 Feb 2014 10:21:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40242) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIgIB-0005nb-1M for bug-gnu-emacs@gnu.org; Wed, 26 Feb 2014 10:21:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WIgIA-0008TW-KT for bug-gnu-emacs@gnu.org; Wed, 26 Feb 2014 10:21:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Barry OReilly Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Feb 2014 15:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16411 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16411-submit@debbugs.gnu.org id=B16411.139342802032509 (code B ref 16411); Wed, 26 Feb 2014 15:21:02 +0000 Original-Received: (at 16411) by debbugs.gnu.org; 26 Feb 2014 15:20:20 +0000 Original-Received: from localhost ([127.0.0.1]:41424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WIgHT-0008SH-Kr for submit@debbugs.gnu.org; Wed, 26 Feb 2014 10:20:20 -0500 Original-Received: from mail-ob0-f172.google.com ([209.85.214.172]:34808) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WIgHR-0008S9-SM for 16411@debbugs.gnu.org; Wed, 26 Feb 2014 10:20:18 -0500 Original-Received: by mail-ob0-f172.google.com with SMTP id wm4so901300obc.31 for <16411@debbugs.gnu.org>; Wed, 26 Feb 2014 07:20:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=1mFaScK2ZF6+UtqImhNOLAaObTw23xqDQM+xqoN9Ges=; b=mhOqXm9eSw709PDCOaXzGKJn9q0DzAKKoR+eyAdXxySEyfcYRDZhJBePdZ6L+DlTFW gEJ9rYZ8/JSb70GMTP7+cVD0CuIeuFjejL2VFNKAwnf0c3Jp6ABQy2RIFGqnT88+UbqY iirFO8U5iKn9gHvryJyFdrT0zpg5oEqXf4rTR/fnFNKVHLqbsW5jXWD8nNOovryZCfVG vR6clWSivmJ2sZm58ygEvpZCjuT2zq2tDphxqdeDU4SaRPMgaBCxYd6lx5J6FvbU412w ctHXZ8Sy0Xg+xufUt7N8AvixlZV6LJvm/+FuoZdlp0fChyFn6sY9y+TFzRKhgt9Zdhl2 FIjw== X-Received: by 10.60.123.74 with SMTP id ly10mr6997005oeb.14.1393428017303; Wed, 26 Feb 2014 07:20:17 -0800 (PST) Original-Received: by 10.76.21.84 with HTTP; Wed, 26 Feb 2014 07:20:17 -0800 (PST) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:86257 Archived-At: --047d7b5d42fcfdfced04f350bd9e Content-Type: text/plain; charset=ISO-8859-1 Ping. Is my fix to the bug described at http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16411#38 acceptable to install? Here is the patch again: diff --git a/lisp/simple.el b/lisp/simple.el index b90382d..01d4f19 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -2434,7 +2434,7 @@ If it crosses the edge, we return nil." ((stringp (car undo-elt)) ;; (TEXT . POSITION) (and (>= (abs (cdr undo-elt)) start) - (< (abs (cdr undo-elt)) end))) + (<= (abs (cdr undo-elt)) end))) ((and (consp undo-elt) (markerp (car undo-elt))) ;; This is a marker-adjustment element (MARKER . ADJUSTMENT). ;; See if MARKER is inside the region. --047d7b5d42fcfdfced04f350bd9e Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Ping. Is my fix to the bug described at
http://debbugs.gnu.org= /cgi/bugreport.cgi?bug=3D16411#38 acceptable to
install? Here is the= patch again:

diff --git a/lisp/simple.el b/lisp/simple.el
index b90382d..01d4f19 = 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -2434,7 +2434,= 7 @@ If it crosses the edge, we return nil."
=A0=A0=A0=A0=A0=A0=A0 = ((stringp (car undo-elt))
=A0=A0=A0=A0=A0=A0=A0=A0 ;; (TEXT . POSITION)
=A0=A0=A0=A0=A0=A0=A0=A0 (= and (>=3D (abs (cdr undo-elt)) start)
-=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0 (< (abs (cdr undo-elt)) end)))
+=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0 (<=3D (abs (cdr undo-elt)) end)))
=A0=A0=A0=A0=A0=A0=A0 ((and = (consp undo-elt) (markerp (car undo-elt)))
=A0=A0=A0=A0=A0=A0=A0=A0 ;; This is a marker-adjustment element (MARKER . A= DJUSTMENT).
=A0=A0=A0=A0=A0=A0=A0=A0 ;; See if MARKER is inside the regi= on.

--047d7b5d42fcfdfced04f350bd9e--