From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Barry OReilly Newsgroups: gmane.emacs.devel Subject: Re: bug#12022: [PATCH] Unable to use anonymous functions for Key Translations Date: Fri, 17 Aug 2012 11:05:52 -0400 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=00248c70fbf1001a5c04c7777f88 X-Trace: ger.gmane.org 1345237990 8349 80.91.229.3 (17 Aug 2012 21:13:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 17 Aug 2012 21:13:10 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 17 23:13:11 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T2Tqv-0006hd-Gc for ged-emacs-devel@m.gmane.org; Fri, 17 Aug 2012 23:13:09 +0200 Original-Received: from localhost ([::1]:47074 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T2Tqu-0003vf-Aw for ged-emacs-devel@m.gmane.org; Fri, 17 Aug 2012 17:13:08 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:33223) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T2O7Z-0007pr-Qi for emacs-devel@gnu.org; Fri, 17 Aug 2012 11:05:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T2O7V-0004cD-BE for emacs-devel@gnu.org; Fri, 17 Aug 2012 11:05:57 -0400 Original-Received: from mail-qa0-f48.google.com ([209.85.216.48]:43350) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T2O7V-0004c8-6G for emacs-devel@gnu.org; Fri, 17 Aug 2012 11:05:53 -0400 Original-Received: by qady1 with SMTP id y1so1880446qad.0 for ; Fri, 17 Aug 2012 08:05:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=azMNxUmWVjFrUazhodnpHAikB5PWCfK2O+EmjeS2YxA=; b=CokZeB0ppo3nWyBIu9MylM1lcMM4IFsXLIUMen2npz4rFl38wVNw4F5TiW2qlLZXYC sJM+edsQjbm5HlFteErICt5cRb9oaPc9E15q1kAeB3Ax0hkI3PBYoyW8psP/uG5AlYyJ +na8RmuFn5NoBnmlyOQrcBZlyZKFxfu4VVQV4rU03PD0/hduWHk/ZK/RZnPmHLFomaDU Hx9o9ucuvvPNRHJ6xJ4m/dMkgeqHCHXMnwqgSmnrbN2l9OVBZnagtziQsyT/F9CNrZmw C8r8LYlKRgTizCKzTgqfLhFmyCiskMYZNZxCf7Kaemk+zrqAn+e8sXkWbGssfWxaYXw2 UDEA== Original-Received: by 10.229.135.196 with SMTP id o4mr3908226qct.154.1345215952591; Fri, 17 Aug 2012 08:05:52 -0700 (PDT) Original-Received: by 10.49.5.194 with HTTP; Fri, 17 Aug 2012 08:05:52 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.216.48 X-Mailman-Approved-At: Fri, 17 Aug 2012 17:13:06 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:152625 Archived-At: --00248c70fbf1001a5c04c7777f88 Content-Type: text/plain; charset=ISO-8859-1 > I installed your patch slightly simplified (FUNCTIONP already does the Ffboundp and SYMBOLP checks). What I'm really doing involves the need for a closure, so I proceeded to enable lexical binding. This causes the test case to fail again. I looked into it and found that DEFUN("functionp", ...) checks EQ (car, Qclosure) but FUNCTIONP does not. We could add the same check to FUNCTIONP, but I'm wondering if one of these functions should leverage the other? --00248c70fbf1001a5c04c7777f88 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable > I installed your patch slightly simplified (FUNCTIONP already does the= Ffboundp and SYMBOLP checks).

What I'm really doing involves th= e need for a closure, so I proceeded to enable lexical binding.=A0 This cau= ses the test case to fail again.=A0 I looked into it and found that DEFUN(&= quot;functionp", ...) checks EQ (car, Qclosure) but FUNCTIONP does not= .=A0 We could add the same check to FUNCTIONP, but I'm wondering if one= of these functions should leverage the other?

--00248c70fbf1001a5c04c7777f88--