From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Barry OReilly Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Re: running each test file independently in test/automated Date: Tue, 17 Sep 2013 09:47:29 -0400 Message-ID: References: <87zjrb7gcj.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11c34854d356ae04e6948f62 X-Trace: ger.gmane.org 1379425656 12622 80.91.229.3 (17 Sep 2013 13:47:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 17 Sep 2013 13:47:36 +0000 (UTC) Cc: emacs-devel@gnu.org To: Kenichi Handa Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 17 15:47:40 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VLvcv-0008CD-HE for ged-emacs-devel@m.gmane.org; Tue, 17 Sep 2013 15:47:37 +0200 Original-Received: from localhost ([::1]:41262 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VLvcv-0003op-6Y for ged-emacs-devel@m.gmane.org; Tue, 17 Sep 2013 09:47:37 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53247) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VLvcr-0003oi-LH for emacs-devel@gnu.org; Tue, 17 Sep 2013 09:47:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VLvcq-0000Cu-HT for emacs-devel@gnu.org; Tue, 17 Sep 2013 09:47:33 -0400 Original-Received: from mail-wi0-x22e.google.com ([2a00:1450:400c:c05::22e]:39778) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VLvco-0000Cb-U3; Tue, 17 Sep 2013 09:47:31 -0400 Original-Received: by mail-wi0-f174.google.com with SMTP id hj3so4975169wib.1 for ; Tue, 17 Sep 2013 06:47:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=2shM52KRae9W7SX5whLYjzr+0JAFNk7snIIMRkWXLYE=; b=AK3iLUTZd6eCIqnj6yXu8w+kjoUO5JQ5o58I2YFQJQWQxZW7bA1zjI7PA6kwP2BgUi 87R9cu6/3cQPEgF4xJ8vrAIGPNa/7GWUAJqUHCgcTmHVWGeJPNzYzO8lGGJxM5qe00QM d3xmy77WAZioRpFvLgO/fkI8u7iz9e7hLSzEYPyIVvA5b7UvdkMXJZRTCE49I2LPbYpI 0TuKjPrs8ckSAXU0atVENV4lTc7TJPYyOy2lw0/dQFCI8PRe9QPCzXgS150w2ANH5we5 RWYdTZshwDM0UAqS/M9zSnHNtP8jAplq/AJCvrwsJ36JYhI9OvSIvJgejXK9Oicsn5fg SixQ== X-Received: by 10.180.211.111 with SMTP id nb15mr2508423wic.55.1379425649381; Tue, 17 Sep 2013 06:47:29 -0700 (PDT) Original-Received: by 10.194.234.234 with HTTP; Tue, 17 Sep 2013 06:47:29 -0700 (PDT) In-Reply-To: <87zjrb7gcj.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::22e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:163386 Archived-At: --001a11c34854d356ae04e6948f62 Content-Type: text/plain; charset=ISO-8859-1 > it is more convenient that the whole testing doesn't stop by an > error of a single test file. > If we don't have to keep the original behavior of "make check", > let's modify the rule of ".el.elc:". So the test code byte compilation rule would not stop Make, but would be captured in the .log file and reported at the end summary report? That is fine to me. We should have ert-summary-report kill-emacs with positive error code if there were such errors. That way the overall 'make check' will still fail if there were build errors. --001a11c34854d356ae04e6948f62 Content-Type: text/html; charset=ISO-8859-1
> it is more convenient that the whole testing doesn't stop by an
> error of a single test file.

> If we don't have to keep the original behavior of "make check",
> let's modify the rule of ".el.elc:".

So the test code byte compilation rule would not stop Make, but would
be captured in the .log file and reported at the end summary report?
That is fine to me.

We should have ert-summary-report kill-emacs with positive error code
if there were such errors. That way the overall 'make check' will
still fail if there were build errors.

--001a11c34854d356ae04e6948f62--