From: Barry OReilly <gundaetiapo@gmail.com>
To: toby-undo-tree@dr-qubit.org, 16377@debbugs.gnu.org
Subject: bug#16377: Undo Tree regression: (error "Unrecognized entry in undo list undo-tree-canary")
Date: Mon, 6 Jan 2014 19:32:45 -0500 [thread overview]
Message-ID: <CAFM41H1VcYe=_nj3s1et+JKWNmgjkrsQN=XoT8KzCofHHToivw@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 2066 bytes --]
Don't know yet if the code change belongs in Undo Tree or Emacs but
the recipe is:
• Start Emacs in scratch buffer with global-undo-tree-mode enabled
• Go to BOB and insert "xxx"
• Select first line
• undo-tree-undo in region
• undo-tree-redo in region
• undo-tree-visualize
• Navigate down (redo)*
• Navigate up (undo)
Upon the navigate up, this error occurs:
Debugger entered--Lisp error: (error "Unrecognized entry in undo list
undo-tree-canary")
signal(error ("Unrecognized entry in undo list undo-tree-canary"))
error("Unrecognized entry in undo list %S" undo-tree-canary)
primitive-undo(1 (undo-tree-canary))
undo-tree-undo-1(1)
undo-tree-visualize-undo(1)
call-interactively(undo-tree-visualize-undo nil nil)
command-execute(undo-tree-visualize-undo)
* Sometimes the navigate down hangs with backtrace:
Debugger entered--Lisp error: (quit)
undo-tree-copy-list((nil))
undo-tree-redo-1(1)
undo-tree-visualize-redo(1)
call-interactively(undo-tree-visualize-redo nil nil)
command-execute(undo-tree-visualize-redo)
Don't know if it's related or not.
This recipe does not cause a problem with Emacs 24.3.
The following commit is suspicious:
commit 0c180ea96c022923ef18a255d0492bdb5ad04e02
Author: Aaron S. Hawley <aaron.s.hawley@gmail.com>
Date: Tue Jan 8 14:13:31 2013 -0500
* lisp/simple.el (primitive-undo): Move from undo.c.
* src/undo.c (Fprimitive_undo): Move to simple.el.
(syms_of_undo): Remove declaration for Sprimitive_undo.
* test/automated/undo-tests.el: New file.
The commit moved primitive-undo from C to Elisp. In the process, it
added an else condition not present in the C code:
+ (t (error "Unrecognized entry in undo list %S" next)))))
The consequence of this bug is that when using Undo Tree, recent undo
history can become completely inaccessible.
I should note that if I don't undo in region, Undo Tree has never run
into any problems with the Emacs on trunk.
[-- Attachment #2: Type: text/html, Size: 2342 bytes --]
next reply other threads:[~2014-01-07 0:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 0:32 Barry OReilly [this message]
2014-01-07 4:14 ` bug#16377: Undo Tree regression: (error "Unrecognized entry in undo list undo-tree-canary") Toby Cubitt
2014-01-22 3:23 ` Barry OReilly
2014-01-22 17:08 ` bug#16523: " Toby Cubitt
2014-01-08 3:37 ` bug#16377: " Toby Cubitt
2014-01-22 0:05 ` Barry OReilly
[not found] ` <20140122141701.GA6728@c3po>
2014-01-22 15:26 ` Barry OReilly
2014-01-22 17:05 ` Toby Cubitt
2014-01-22 18:56 ` Stefan Monnier
2014-01-22 21:30 ` Toby Cubitt
2017-07-06 0:33 ` Keith David Bershatsky
2017-07-06 5:01 ` Keith David Bershatsky
2017-07-06 5:35 ` Stefan Monnier
2017-07-06 6:25 ` Keith David Bershatsky
2017-07-06 9:02 ` Toby Cubitt
2017-07-06 9:47 ` Toby Cubitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFM41H1VcYe=_nj3s1et+JKWNmgjkrsQN=XoT8KzCofHHToivw@mail.gmail.com' \
--to=gundaetiapo@gmail.com \
--cc=16377@debbugs.gnu.org \
--cc=toby-undo-tree@dr-qubit.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.