From: Barry OReilly <gundaetiapo@gmail.com>
To: 15745@debbugs.gnu.org
Subject: bug#15745: [PATCH] Define semantic-idle-symbol-highlight-face with defface
Date: Mon, 28 Oct 2013 17:04:00 -0400 [thread overview]
Message-ID: <CAFM41H1RMRVMpvnRiJzPG0Yu3eB4KaX-h5MuepfbuqXWbbeQow@mail.gmail.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 234 bytes --]
It would be more convenient to customize
semantic-idle-symbol-highlight-face in the manner defface usually
allows. However, semantic-idle-symbol-highlight-face is currently
defined with defvar.
The attached patch implements the fix.
[-- Attachment #1.2: Type: text/html, Size: 279 bytes --]
[-- Attachment #2: semantic-face.diff --]
[-- Type: application/octet-stream, Size: 4026 bytes --]
diff --git a/lisp/cedet/ChangeLog b/lisp/cedet/ChangeLog
index 6862181..289280c 100644
--- a/lisp/cedet/ChangeLog
+++ b/lisp/cedet/ChangeLog
@@ -1,3 +1,12 @@
+2013-10-28 Barry O'Reilly <gundaetiapo@gmail.com>
+
+ * semantic/idle.el (semantic-idle-symbol-highlight-face): Define
+ face using defface instead of defvar.
+ (semantic-idle-symbol-maybe-highlight)
+ (semantic-idle-local-symbol-highlight): Pass face as symbol
+ * pulse.el (pulse-momentary-highlight-overlay)
+ (pulse-momentary-highlight-region): Fix typo in doc
+
2013-10-20 Johan Bockgård <bojohan@gnu.org>
* semantic/db-mode.el (global-semanticdb-minor-mode): Remove hooks
diff --git a/lisp/cedet/pulse.el b/lisp/cedet/pulse.el
index 268beed..4a3b501 100644
--- a/lisp/cedet/pulse.el
+++ b/lisp/cedet/pulse.el
@@ -180,7 +180,7 @@ Be sure to call `pulse-reset-face' after calling pulse."
(defun pulse-momentary-highlight-overlay (o &optional face)
"Pulse the overlay O, unhighlighting before next command.
-Optional argument FACE specifies the fact to do the highlighting."
+Optional argument FACE specifies the face to do the highlighting."
(overlay-put o 'original-face (overlay-get o 'face))
(add-to-list 'pulse-momentary-overlay o)
(if (eq pulse-flag 'never)
@@ -237,7 +237,7 @@ Optional argument FACE specifies the face to do the highlighting."
(defun pulse-momentary-highlight-region (start end &optional face)
"Highlight between START and END, unhighlighting before next command.
-Optional argument FACE specifies the fact to do the highlighting."
+Optional argument FACE specifies the face to do the highlighting."
(let ((o (make-overlay start end)))
;; Mark it for deletion
(overlay-put o 'pulse-delete t)
diff --git a/lisp/cedet/semantic/idle.el b/lisp/cedet/semantic/idle.el
index d024e5d..221292a 100644
--- a/lisp/cedet/semantic/idle.el
+++ b/lisp/cedet/semantic/idle.el
@@ -830,8 +830,14 @@ turned on in every Semantic-supported buffer."
;; of all uses of the symbol that is under the cursor.
;;
;; This is to mimic the Eclipse tool of a similar nature.
-(defvar semantic-idle-symbol-highlight-face 'region
- "Face used for highlighting local symbols.")
+(defface semantic-idle-symbol-highlight-face
+ '((((class color) (background dark))
+ ;; Put this back to something closer to black later.
+ (:background "gray20"))
+ (((class color) (background light))
+ (:background "gray90")))
+ "Face used for highlighting local symbols."
+ :group 'semantic-faces)
(defun semantic-idle-symbol-maybe-highlight (tag)
"Perhaps add highlighting to the symbol represented by TAG.
@@ -857,12 +863,12 @@ visible, then highlight it."
(point) (get-buffer-window (current-buffer) 'visible))
(if (< (semantic-overlay-end region) (point-at-eol))
(pulse-momentary-highlight-overlay
- region semantic-idle-symbol-highlight-face)
+ region 'semantic-idle-symbol-highlight-face)
;; Not the same
(pulse-momentary-highlight-region
(semantic-overlay-start region)
(point-at-eol)
- semantic-idle-symbol-highlight-face))))
+ 'semantic-idle-symbol-highlight-face))))
))
((vectorp region)
(let ((start (aref region 0))
@@ -882,7 +888,7 @@ visible, then highlight it."
(pulse-momentary-highlight-region
start (if (<= end (point-at-eol)) end
(point-at-eol))
- semantic-idle-symbol-highlight-face)))
+ 'semantic-idle-symbol-highlight-face)))
))))
nil))
@@ -913,7 +919,7 @@ Call `semantic-symref-hits-in-region' to identify local references."
target (lambda (start end prefix)
(when (/= start (car Hbounds))
(pulse-momentary-highlight-region
- start end semantic-idle-symbol-highlight-face))
+ start end 'semantic-idle-symbol-highlight-face))
(semantic-throw-on-input 'symref-highlight)
)
(semantic-tag-start tag)
diff --git a/src/eval.c b/src/eval.c
index 1e0a63a..4258b68 100644
next reply other threads:[~2013-10-28 21:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-28 21:04 Barry OReilly [this message]
2013-10-28 21:38 ` bug#15745: [PATCH] Define semantic-idle-symbol-highlight-face with defface Glenn Morris
2013-10-28 22:36 ` Barry OReilly
2013-10-29 2:29 ` Glenn Morris
2013-10-29 15:56 ` Barry OReilly
2013-10-29 22:37 ` Glenn Morris
2013-10-31 1:55 ` Barry OReilly
2013-10-29 1:38 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFM41H1RMRVMpvnRiJzPG0Yu3eB4KaX-h5MuepfbuqXWbbeQow@mail.gmail.com \
--to=gundaetiapo@gmail.com \
--cc=15745@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.