From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Barry OReilly Newsgroups: gmane.emacs.bugs Subject: bug#16694: bugs #16694/#16378: Patches Date: Wed, 2 Apr 2014 15:34:59 -0400 Message-ID: References: <52F601AE.5040309@binary-island.eu> <87k3bj40nu.fsf@cougar.home.aneadesign.com> <83wqfiz36v.fsf@gnu.org> <5331D45B.7090704@binary-island.eu> <5335920F.4030008@binary-island.eu> <533C26F3.4040600@binary-island.eu> <533C5898.9000200@binary-island.eu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 X-Trace: ger.gmane.org 1396520220 21601 80.91.229.3 (3 Apr 2014 10:17:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 3 Apr 2014 10:17:00 +0000 (UTC) Cc: 16694@debbugs.gnu.org, 16434@debbugs.gnu.org, Clemens =?UTF-8?Q?Sch=C3=BCller?= To: Matthias Dahl Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 03 12:16:54 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WVeJX-00075K-Mt for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Apr 2014 11:52:03 +0200 Original-Received: from localhost ([::1]:40314 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVQxR-0007p0-Hc for geb-bug-gnu-emacs@m.gmane.org; Wed, 02 Apr 2014 15:36:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43402) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVQxE-0007hL-KZ for bug-gnu-emacs@gnu.org; Wed, 02 Apr 2014 15:36:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WVQx9-00066G-3a for bug-gnu-emacs@gnu.org; Wed, 02 Apr 2014 15:36:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60347) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVQx8-00066C-W4 for bug-gnu-emacs@gnu.org; Wed, 02 Apr 2014 15:36:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WVQx8-00043r-M5 for bug-gnu-emacs@gnu.org; Wed, 02 Apr 2014 15:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Barry OReilly Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Apr 2014 19:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16694 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16694-submit@debbugs.gnu.org id=B16694.139646730715519 (code B ref 16694); Wed, 02 Apr 2014 19:36:02 +0000 Original-Received: (at 16694) by debbugs.gnu.org; 2 Apr 2014 19:35:07 +0000 Original-Received: from localhost ([127.0.0.1]:33295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WVQwD-000429-Fo for submit@debbugs.gnu.org; Wed, 02 Apr 2014 15:35:05 -0400 Original-Received: from mail-oa0-f45.google.com ([209.85.219.45]:65003) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WVQw8-00041R-4z; Wed, 02 Apr 2014 15:35:00 -0400 Original-Received: by mail-oa0-f45.google.com with SMTP id eb12so843515oac.18 for ; Wed, 02 Apr 2014 12:34:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=oxoFMRLHsUvBcpksIoZPMFUGXj3YL3AcSFDqE7+kVL8=; b=JQZcxy/C0Zcc0XA5TAgjYLzeExhYME8VUGIUaKMEMNOSv1o+Gl9c7TRpEhtJF5XI9U KT6KOQqlDMBD7ticrJiwWcnoR5mjcGn3QyDnD8QhfPRFV4ks/0XGbU5hXwHwNPvYpdYl fxmJcQ1j4lCGAYHJa/nn/WB/NhMG3pWapsVbfpxHlgdP/+rW3OhbedbH7CNmlEjaYxOM J8ahwHLJVD5Pu8DeX+DZTAXwJDpHqsmYbaNCsiVAAr9nLKMGYViAEf5i7qGaabxQxii5 YLyTEpDYbZzx8ZEegOMlvEotsGGIc5GJpFe52+vCbGCSOqiuWztJOdbcBR0peqMCu1FA 1QJQ== X-Received: by 10.60.125.72 with SMTP id mo8mr1677978oeb.36.1396467299121; Wed, 02 Apr 2014 12:34:59 -0700 (PDT) Original-Received: by 10.76.6.44 with HTTP; Wed, 2 Apr 2014 12:34:59 -0700 (PDT) In-Reply-To: <533C5898.9000200@binary-island.eu> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:87616 Archived-At: >> For my information, could you confirm the effect my patch has on >> your theme problem? > I'm sorry but you lost me there. Could you please elaborate more > what it is you want me to comment on? Sorry... and thanks. I wanted to know if the following happened to fix the problem described at http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16694#5 : diff --git a/lisp/faces.el b/lisp/faces.el index e008993..2f8560a 100644 --- a/lisp/faces.el +++ b/lisp/faces.el @@ -1615,7 +1615,8 @@ function for its other effects." ;; Initialize the face if it does not exist, then recalculate. (make-empty-face face) (dolist (frame (frame-list)) - (face-spec-recalc face frame))) + (face-spec-recalc face frame) + (make-face-x-resource-internal face frame))) (defun face-spec-recalc (face frame) "Reset the face attributes of FACE on FRAME according to its specs. @@ -1641,8 +1642,7 @@ then the override spec." (setq spec (face-spec-choose (face-default-spec face) frame)) (face-spec-set-2 face frame spec)) (setq spec (face-spec-choose (get face 'face-override-spec) frame)) - (face-spec-set-2 face frame spec)) - (make-face-x-resource-internal face frame)) + (face-spec-set-2 face frame spec))) (defun face-spec-set-2 (face frame spec) "Set the face attributes of FACE on FRAME according to SPEC." > The patch basically restores the behavior (wrt reverse video) to > what Emacs 24.3 did without undoing any of the other work and fixes. > I've tested everything as far as I could and all your test cases > work just fine on my machine. Confirmed, thanks. I have no further objections to the patch series. Thank you for the work you put into it.