From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Barry OReilly Newsgroups: gmane.emacs.bugs Subject: bug#17887: Regression: mouse-1 click on link does mouse-2 instead Date: Mon, 30 Jun 2014 16:27:06 -0700 Message-ID: References: <871tu6do2v.fsf@web.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=bcaec53d55f54a9a9f04fd15fff9 X-Trace: ger.gmane.org 1404170927 838 80.91.229.3 (30 Jun 2014 23:28:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 30 Jun 2014 23:28:47 +0000 (UTC) Cc: 17887@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 01 01:28:35 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X1kzw-0005xL-18 for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Jul 2014 01:28:32 +0200 Original-Received: from localhost ([::1]:37317 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1kzv-0007Sk-Lh for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Jun 2014 19:28:31 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35914) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1kzX-00078i-P7 for bug-gnu-emacs@gnu.org; Mon, 30 Jun 2014 19:28:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X1kzS-00051i-Qw for bug-gnu-emacs@gnu.org; Mon, 30 Jun 2014 19:28:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47204) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X1kzS-000516-Nz for bug-gnu-emacs@gnu.org; Mon, 30 Jun 2014 19:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1X1kzS-0006yB-Cm for bug-gnu-emacs@gnu.org; Mon, 30 Jun 2014 19:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Barry OReilly Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Jun 2014 23:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17887 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17887-submit@debbugs.gnu.org id=B17887.140417083626702 (code B ref 17887); Mon, 30 Jun 2014 23:28:02 +0000 Original-Received: (at 17887) by debbugs.gnu.org; 30 Jun 2014 23:27:16 +0000 Original-Received: from localhost ([127.0.0.1]:38343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X1kyh-0006wb-1a for submit@debbugs.gnu.org; Mon, 30 Jun 2014 19:27:15 -0400 Original-Received: from mail-we0-f179.google.com ([74.125.82.179]:49503) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X1kye-0006wI-4u for 17887@debbugs.gnu.org; Mon, 30 Jun 2014 19:27:13 -0400 Original-Received: by mail-we0-f179.google.com with SMTP id w62so8708027wes.24 for <17887@debbugs.gnu.org>; Mon, 30 Jun 2014 16:27:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=/FXO9fmUZAgrio0pXXlEGLX8l84inNZNdy6mefgyJwA=; b=Z+YuyfnFpZmAdZETrcWvlz9y4h09VvlbxOwtmqRDNN4Zei5ks8lZUVcaP8itvikmHF wroh66R5Vl+ao/d5mWvle3stAC6mR1gvw3iS36tCT73xoVsu7heccI+ELURYVNLtwEX7 RvIe0lPTjsNrDBYLSKXU4yC0HWns0HpnLLi/pfcR7fDCQjKimt0lvVO3tod9EFU6Hqts trQPhcrZ+yz7d120+ueibTxxYBR6XPjFmdDjUJps25q/OSz+VRDcl+/t0XD6hFsLmm5j 1mZ7ObOW/3OjTR+V5R9H1hUNGl7HKmtIrB1T2hFl4ELUhjJvqg6JtSepI8/+yaO0BuEL bdIw== X-Received: by 10.180.20.206 with SMTP id p14mr32713262wie.26.1404170826060; Mon, 30 Jun 2014 16:27:06 -0700 (PDT) Original-Received: by 10.194.156.233 with HTTP; Mon, 30 Jun 2014 16:27:06 -0700 (PDT) In-Reply-To: <871tu6do2v.fsf@web.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91025 Archived-At: --bcaec53d55f54a9a9f04fd15fff9 Content-Type: text/plain; charset=UTF-8 > Would it solve your problem when your mode (locally) binds > `mouse-1-click-follows-link` to nil? No, in this case mouse-1 does nothing but relocate point. I Git bisected the regression to: 25573f61f9eaf1631c03d16486ffc17fd9b18503 is the first bad commit commit 25573f61f9eaf1631c03d16486ffc17fd9b18503 Author: Stefan Monnier Date: Fri Mar 8 23:15:53 2013 -0500 Separate mouse-1-click-follows-link from mouse-drag-region. * lisp/mouse.el (mouse--down-1-maybe-follows-link): New function. (key-translation-map): Use it to implement mouse-1-click-follows-link. (mouse-drag-line, mouse-drag-track): Remove mouse-1-click-follows-link code. (mouse--remap-link-click-p): Remove. * src/keyboard.c (access_keymap_keyremap): Accept nil return value from functions to mean "no change". * src/keyboard.h (EVENT_START, EVENT_END, POSN_WINDOW, POSN_POSN) (POSN_WINDOW_POSN, POSN_TIMESTAMP): Be careful since events may come from Elisp via unread-command-events. --bcaec53d55f54a9a9f04fd15fff9 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
> Would it solve your problem when your mode (locally) = binds
> `mouse-1-click-follows-link` to nil?

No, in this case = mouse-1 does nothing but relocate point.

I Git bisected the regressi= on to:

25573f61f9eaf1631c03d16486ffc17fd9b18503 is the first bad commit
com= mit 25573f61f9eaf1631c03d16486ffc17fd9b18503
Author: Stefan Monnier <= monnier@iro.umontreal.ca>= ;
Date:=C2=A0=C2=A0 Fri Mar 8 23:15:53 2013 -0500

=C2=A0=C2=A0=C2=A0 S= eparate mouse-1-click-follows-link from mouse-drag-region.
=C2=A0=C2=A0= =C2=A0 * lisp/mouse.el (mouse--down-1-maybe-follows-link): New function.=C2=A0=C2=A0=C2=A0 (key-translation-map): Use it to implement mouse-1-clic= k-follows-link.
=C2=A0=C2=A0=C2=A0 (mouse-drag-line, mouse-drag-track): Remove mouse-1-clic= k-follows-link code.
=C2=A0=C2=A0=C2=A0 (mouse--remap-link-click-p): Rem= ove.
=C2=A0=C2=A0=C2=A0 * src/keyboard.c (access_keymap_keyremap): Accep= t nil return value from
=C2=A0=C2=A0=C2=A0 functions to mean "no ch= ange".
=C2=A0=C2=A0=C2=A0 * src/keyboard.h (EVENT_START, EVENT_END, POSN_WINDOW, P= OSN_POSN)
=C2=A0=C2=A0=C2=A0 (POSN_WINDOW_POSN, POSN_TIMESTAMP): Be care= ful since events may come
=C2=A0=C2=A0=C2=A0 from Elisp via unread-comma= nd-events.

--bcaec53d55f54a9a9f04fd15fff9--