From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Joakim =?UTF-8?Q?H=C3=A5rsman?= Newsgroups: gmane.emacs.bugs Subject: bug#10299: Emacs doesn't handle Unicode characters in keyboard layout on MS Windows Date: Tue, 7 Aug 2012 21:47:38 +0200 Message-ID: References: <8739clgapc.fsf@gnu.org> <83zket20xw.fsf@gnu.org> <83vcph0w9t.fsf@gnu.org> <83obv821wv.fsf@gnu.org> <831us31atj.fsf@gnu.org> <83pqflzr1d.fsf@gnu.org> <836298hrdt.fsf@gnu.org> <83ehnj9zva.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1344368890 22782 80.91.229.3 (7 Aug 2012 19:48:10 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 7 Aug 2012 19:48:10 +0000 (UTC) Cc: lekktu@gmail.com, 10299@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 07 21:48:09 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SyplB-00045L-7X for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Aug 2012 21:48:09 +0200 Original-Received: from localhost ([::1]:37791 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyplA-00038I-6F for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Aug 2012 15:48:08 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:43985) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sypl6-00037u-Au for bug-gnu-emacs@gnu.org; Tue, 07 Aug 2012 15:48:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sypl5-00066g-4e for bug-gnu-emacs@gnu.org; Tue, 07 Aug 2012 15:48:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59043) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sypl4-00066W-Vy for bug-gnu-emacs@gnu.org; Tue, 07 Aug 2012 15:48:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Sypso-0005JI-EQ for bug-gnu-emacs@gnu.org; Tue, 07 Aug 2012 15:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Joakim =?UTF-8?Q?H=C3=A5rsman?= Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Aug 2012 19:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10299 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10299-submit@debbugs.gnu.org id=B10299.134436934120383 (code B ref 10299); Tue, 07 Aug 2012 19:56:02 +0000 Original-Received: (at 10299) by debbugs.gnu.org; 7 Aug 2012 19:55:41 +0000 Original-Received: from localhost ([127.0.0.1]:40356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SypsS-0005Ii-Pf for submit@debbugs.gnu.org; Tue, 07 Aug 2012 15:55:41 -0400 Original-Received: from mail-gg0-f172.google.com ([209.85.161.172]:43231) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SypsR-0005Ib-Fq for 10299@debbugs.gnu.org; Tue, 07 Aug 2012 15:55:39 -0400 Original-Received: by ggnc4 with SMTP id c4so4236117ggn.3 for <10299@debbugs.gnu.org>; Tue, 07 Aug 2012 12:47:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=Dci2Z4G3beCO1f7PGjKXkuj5VuMvsQ0rOUtmgs34k7Y=; b=Ct3WL4KAz/pS4kCSGKqWIGgtSp0z0hMCvRP349iakELz78LWSDEKOchZEUsvypKVzr rSgk5cPnZmLpx0yvJa8d/aoxJHC/Dp/GN819ddfS1/i0fzYNGNgUFGKQZtXS5RK/4Hk2 g/4CeJjlDx+29zM+2jjRVz1U8ZGL1u5K1xpLS67Q5Hu+GPvdXtPbPnIfzDvX7xDH5m9s x02aEhafxa/hR4EESMmmAx7bu9/lTYda8VXkzZvLDSubgvaj95AWI8FCx1Mcal+6Kesm AL1XF3XQa03czxwcjDDJQzs2Jc2mQajBEjKeKGUe/nqn2myEZ88hzudSSw6SdQQmqFrd k/DQ== Original-Received: by 10.50.159.135 with SMTP id xc7mr9892703igb.9.1344368858412; Tue, 07 Aug 2012 12:47:38 -0700 (PDT) Original-Received: by 10.50.45.70 with HTTP; Tue, 7 Aug 2012 12:47:38 -0700 (PDT) In-Reply-To: <83ehnj9zva.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:62924 Archived-At: Your patch works fine for me on Windows XP. Unicode input outside the system code page works fine and so does non-ASCII input that is present in the current code page. Since this seems much cleaner than the previous patch, it is definitely the way to go. I think the critical change was switching to both DefWindowProcW and DispatchMessageW (at least that's what http://social.msdn.microsoft.com/forums/en-US/windowssdk/thread/07afec87-68= c1-4a56-bf46-a38a9c2232e9/ leads you to believe). I think I actually tried both those changes individually, but not both at o= nce. I'll test a patched build on Windows 7 tomorrow as well, sadly I don't have access to anything running Windows 95. Thanks for taking the time to look at this and test it. On 7 August 2012 04:53, Eli Zaretskii wrote: >> Date: Mon, 6 Aug 2012 22:20:01 +0200 >> From: Joakim H=E5rsman >> Cc: lekktu@gmail.com, 10299@debbugs.gnu.org >> >> Sorry for the late reply, I've been away on vacation. > > No sweat. Hope you had a good one. > >> The change to SetWindowTextW for frame titles was needed because >> otherwise the frame title was cut short after the first character >> (presumably because the window class name is a UCS-2 wide string and >> the second byte therefore is null). This is exaclty the case they talk >> about at your link. >> >> If I change w32_set frame text to always call SetWindowText I get a >> default frame title of "e". Changing DispatchMessage to use the wide >> version when appropriate doesn't help either. > > I didn't see any problem with the frame title, with the patch I sent. > I'm curious to hear if you will still see that problem. > >> I'll try your new patch tomorrow and get back with details on how it wor= ked, > > Thank you.