bug#17477: flymake-mode looks at wrong PHP binary

bug#17477: flymake-mode looks at wrong PHP binary

[Joe Borġ]

[-- Attachment #1: Type: text/plain, Size: 330 bytes --]

When executing M+x flymake mode, I get

Flymake: Configuration error has occured while running (/usr/bin/php -f
viewrequest_flymake.php -l). Flymake will be switched OFF

My php is in /usr/local/bin/php

This was installed using package-install, with marmalade repository set.

Regards,
Joseph David Borġ
josephb.org

[-- Attachment #2: Type: text/html, Size: 565 bytes --]

bug#17477: flymake-mode looks at wrong PHP binary

[Leo Liu]

On 2014-05-13 00:26 +0800, Joe Borġ wrote:
> When executing M+x flymake mode, I get
>
> Flymake: Configuration error has occured while running (/usr/bin/php -f
> viewrequest_flymake.php -l). Flymake will be switched OFF
>
> My php is in /usr/local/bin/php
>
> This was installed using package-install, with marmalade repository set.

Could it be that you also have /usr/bin/php? I see flymake-php-init has
no hardcoded path.

Leo

bug#17477: flymake-mode looks at wrong PHP binary

[Joe Borġ]

[-- Attachment #1: Type: text/plain, Size: 581 bytes --]

Hi Leo,

No, only where stated.

Thanks
On 12 May 2014 18:15, "Leo Liu" <sdl.web@gmail.com> wrote:

> On 2014-05-13 00:26 +0800, Joe Borġ wrote:
> > When executing M+x flymake mode, I get
> >
> > Flymake: Configuration error has occured while running (/usr/bin/php -f
> > viewrequest_flymake.php -l). Flymake will be switched OFF
> >
> > My php is in /usr/local/bin/php
> >
> > This was installed using package-install, with marmalade repository set.
>
> Could it be that you also have /usr/bin/php? I see flymake-php-init has
> no hardcoded path.
>
> Leo
>

[-- Attachment #2: Type: text/html, Size: 903 bytes --]

bug#17477: flymake-mode looks at wrong PHP binary

[Glenn Morris]

Joe Borġ wrote:

>> > When executing M+x flymake mode, I get
>> >
>> > Flymake: Configuration error has occured while running (/usr/bin/php -f
>> > viewrequest_flymake.php -l). Flymake will be switched OFF
>> >
>> > My php is in /usr/local/bin/php

I don't know what to tell you.
flymake just calls "php".
It sure sounds like something thinks you have a /usr/bin/php.

>> > This was installed using package-install, with marmalade repository set.

Why is this necessary? flymake is part of Emacs. What did you install?
What version of Emacs is this?

Does this happen with emacs -Q?

bug#17477: flymake-mode looks at wrong PHP binary

[Joe Borġ]

[-- Attachment #1: Type: text/plain, Size: 891 bytes --]

I promise you there is no /usr/bin/php.

I installed flymake-php and want to turn it on.

Emacs 24.3.1 - I've not tried with -Q.



Regards,
Joseph David Borġ
josephb.org


On 12 May 2014 20:08, Glenn Morris <rgm@gnu.org> wrote:

> Joe Borġ wrote:
>
> >> > When executing M+x flymake mode, I get
> >> >
> >> > Flymake: Configuration error has occured while running (/usr/bin/php
> -f
> >> > viewrequest_flymake.php -l). Flymake will be switched OFF
> >> >
> >> > My php is in /usr/local/bin/php
>
> I don't know what to tell you.
> flymake just calls "php".
> It sure sounds like something thinks you have a /usr/bin/php.
>
> >> > This was installed using package-install, with marmalade repository
> set.
>
> Why is this necessary? flymake is part of Emacs. What did you install?
> What version of Emacs is this?
>
> Does this happen with emacs -Q?
>

[-- Attachment #2: Type: text/html, Size: 1498 bytes --]

bug#17477: flymake-mode looks at wrong PHP binary

[Glenn Morris]

Then my crystal ball says that you are using this

https://github.com/ejmr/php-mode/blob/master/php-mode.el

which is

1) not part of Emacs
2) broken in exactly the way you describe (default value of php-executable).

So you should report this to whoever maintains it.

(NB crystal ball comes with no warranty.)

bug#17477: flymake-mode looks at wrong PHP binary

[Joe Borġ]

[-- Attachment #1: Type: text/plain, Size: 556 bytes --]

Yes, you're right - but why does that effect flymake-php?  I ask so I can
try and fix it.



Regards,
Joseph David Borġ
josephb.org


On 12 May 2014 20:31, Glenn Morris <rgm@gnu.org> wrote:

>
> Then my crystal ball says that you are using this
>
> https://github.com/ejmr/php-mode/blob/master/php-mode.el
>
> which is
>
> 1) not part of Emacs
> 2) broken in exactly the way you describe (default value of
> php-executable).
>
> So you should report this to whoever maintains it.
>
> (NB crystal ball comes with no warranty.)
>

[-- Attachment #2: Type: text/html, Size: 1081 bytes --]

bug#17477: flymake-mode looks at wrong PHP binary

[Glenn Morris]

Joe Borġ wrote:

> Yes, you're right - but why does that effect flymake-php?  I ask so I can
> try and fix it.

Because they load flymake.el, then clobber its flymake-php-init function
with their own version, which is identical to the default version apart
from using "/usr/bin/php" (by default), thus breaking flymake.

Simply (setq php-executable "php") and it should work.

I assume they want to cater for cases where "php" is not installed as
"php"; if there are any.

bug#17477: flymake-mode looks at wrong PHP binary

[Glenn Morris]

I'm going to close this because I don't think there is any bug in Emacs
here; but feel free to keep discussing it here if you like.

(If "php" is commonly installed as something other than "php", perhaps
flymake.el needs a flymake-php-program option, similar to the existing
flymake-xml-program. Likewise for "perl" and "texify".)

bug#17477: flymake-mode looks at wrong PHP binary

[Joe Borġ]

[-- Attachment #1: Type: text/plain, Size: 547 bytes --]

Thanks for your help.  I'm going to create a pull request with a fix for
them.



Regards,
Joseph David Borġ
josephb.org


On 13 May 2014 06:59, Glenn Morris <rgm@gnu.org> wrote:

>
> I'm going to close this because I don't think there is any bug in Emacs
> here; but feel free to keep discussing it here if you like.
>
> (If "php" is commonly installed as something other than "php", perhaps
> flymake.el needs a flymake-php-program option, similar to the existing
> flymake-xml-program. Likewise for "perl" and "texify".)
>

[-- Attachment #2: Type: text/html, Size: 1024 bytes --]

bug#17477: flymake-mode looks at wrong PHP binary

[Glenn Morris]

Joe Borġ wrote:

> Thanks for your help.  I'm going to create a pull request with a fix for
> them.

Great! (AFAICS, just defaulting php-executable to "php" would be enough.)

bug#17477: flymake-mode looks at wrong PHP binary

[Joe Borġ]

[-- Attachment #1: Type: text/plain, Size: 410 bytes --]

Yes, that does work fine.  Just a bloody nuisance!  It should default to
`php` or `/usr/bin/env php`



Regards,
Joseph David Borġ
josephb.org


On 13 May 2014 16:45, Glenn Morris <rgm@gnu.org> wrote:

> Joe Borġ wrote:
>
> > Thanks for your help.  I'm going to create a pull request with a fix for
> > them.
>
> Great! (AFAICS, just defaulting php-executable to "php" would be enough.)
>

[-- Attachment #2: Type: text/html, Size: 875 bytes --]