From: Hiroshi Saito <monodie@gmail.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Substitute a guid XML element in org-feed
Date: Sat, 14 Nov 2015 13:15:32 +0900 [thread overview]
Message-ID: <CAFEtL0dQpMyv1uJ8sGLMctqJv_SFEW7wnZeCjGdbhzLZL0ATdA@mail.gmail.com> (raw)
In-Reply-To: <CAFEtL0fj3MZz5eYfcjPXz2UXKWRWgSFNyJXuKtKko9g5ZzTxAQ@mail.gmail.com>
Hi Nicolas,
Thank you for applying my patch.
I'm sorry to say the patch causes an error unless xml package is luckily
loaded. I attached another patch to fix it in my last post:
http://lists.gnu.org/archive/html/emacs-orgmode/2015-10/msg00417.html
Could you please review new patch or revert my first patch?
--
Sincerely,
Hiroshi Saito
2015-10-19 8:49 GMT+09:00 Hiroshi Saito <monodie@gmail.com>:
> Hi Michael,
>
> So sorry for that error. I did not notice.
>
> I wrote an additional patch to fix it. The patch makes sure that the xml
> library is loaded before calling `xml-substitute-special` as with
> `org-feed-parse-rss-entry` and `org-feed-parse-atom-feed`.
>
> --
> Sincerely,
> Hiroshi Saito
>
> 2015-10-19 2:54 GMT+09:00 Michael Brand <michael.ch.brand@gmail.com>:
>> Hi Hiroshi
>>
>> On Sun, Sep 27, 2015 at 8:24 PM, Hiroshi Saito <monodie@gmail.com> wrote:
>>> A guid XML element is not substituted in org-feed. Here is a patch
>>> to fix it.
>>
>> It causes the error
>>
>> if: Symbol's function definition is void: xml-substitute-special
>>
>> because xml is not loaded yet.
>>
>> Michael
next prev parent reply other threads:[~2015-11-14 4:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-27 18:24 [PATCH] Substitute a guid XML element in org-feed Hiroshi Saito
2015-09-30 11:57 ` Nicolas Goaziou
2015-10-18 17:54 ` Michael Brand
2015-10-18 23:49 ` Hiroshi Saito
2015-11-14 4:15 ` Hiroshi Saito [this message]
2015-11-14 8:32 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEtL0dQpMyv1uJ8sGLMctqJv_SFEW7wnZeCjGdbhzLZL0ATdA@mail.gmail.com \
--to=monodie@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.