From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Gary Oberbrunner Newsgroups: gmane.emacs.bugs Subject: bug#30131: 26.0.50; compile.el no longer calls compilation-parse-errors-filename-function Date: Mon, 15 Jan 2018 12:28:15 -0500 Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="94eb2c03c8887887680562d3f071" X-Trace: blaine.gmane.org 1516037359 6644 195.159.176.226 (15 Jan 2018 17:29:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 15 Jan 2018 17:29:19 +0000 (UTC) To: 30131@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 15 18:29:15 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eb8ZF-0000k7-Rn for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Jan 2018 18:29:06 +0100 Original-Received: from localhost ([::1]:49840 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eb8bD-0005SN-PM for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Jan 2018 12:31:07 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43433) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eb8ZG-0003qd-6A for bug-gnu-emacs@gnu.org; Mon, 15 Jan 2018 12:29:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eb8ZC-00069e-2r for bug-gnu-emacs@gnu.org; Mon, 15 Jan 2018 12:29:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49830) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eb8ZB-00069Y-Ve for bug-gnu-emacs@gnu.org; Mon, 15 Jan 2018 12:29:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eb8ZB-0001Oc-Py for bug-gnu-emacs@gnu.org; Mon, 15 Jan 2018 12:29:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gary Oberbrunner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Jan 2018 17:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 30131 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.15160373135320 (code B ref -1); Mon, 15 Jan 2018 17:29:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 15 Jan 2018 17:28:33 +0000 Original-Received: from localhost ([127.0.0.1]:57727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eb8Yj-0001Nk-CL for submit@debbugs.gnu.org; Mon, 15 Jan 2018 12:28:33 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:52290) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eb8Yi-0001NY-6H for submit@debbugs.gnu.org; Mon, 15 Jan 2018 12:28:32 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eb8YY-0005ne-U7 for submit@debbugs.gnu.org; Mon, 15 Jan 2018 12:28:26 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:34966) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eb8YY-0005na-Qw for submit@debbugs.gnu.org; Mon, 15 Jan 2018 12:28:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43234) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eb8YX-0003F5-PK for bug-gnu-emacs@gnu.org; Mon, 15 Jan 2018 12:28:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eb8YT-0005l4-BM for bug-gnu-emacs@gnu.org; Mon, 15 Jan 2018 12:28:21 -0500 Original-Received: from mail-it0-x236.google.com ([2607:f8b0:4001:c0b::236]:43590) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eb8YT-0005kZ-3J for bug-gnu-emacs@gnu.org; Mon, 15 Jan 2018 12:28:17 -0500 Original-Received: by mail-it0-x236.google.com with SMTP id u62so1705243ita.2 for ; Mon, 15 Jan 2018 09:28:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oberbrunner-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=BCOllVWqaBLYVKkDN3zcCZ8lfIRW/wzCTesk7n5WGDc=; b=EOfZE/gXY2F9eQqyY/sjgID/SGeFqgP2Tyt4CosPTB1yLFGhWt1+oVh17MVZ3Svm0v PG+887a6wVjS1Qw0OtzxkaXqeil+Ft76YAZ4vC91ccKAD26kHkwfw/5tiW9HXlfpMvbs cVHX3S/s2is0Ennun+194rFYNwyRM1KFWsxVamE+HtEO6Gw3xmWgHMc7i77fK4F3kxm+ S99msOPmmuLlTUCXIvYUneZwzBM64yAiaqXJxQTZmKQG2fl1qH2accRVoVowJI3F9MA1 KBjQYjCpnSQY1FOPEWw1RL9ICfEQqLa55Gwl5yI4o2oAYbbUIe2olrtCtrEXGIkiXtD8 CF2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=BCOllVWqaBLYVKkDN3zcCZ8lfIRW/wzCTesk7n5WGDc=; b=X5VgExYgkihbUdZg62oma5F3D/aRe4clwPE+Nd2D7TJWP8Iz36Iz8l5EgbFbkDOSyI 4zWN7PMPzHlhZsfxEHJ7jKD40BPq8vVdAMijBvJonKV9IZJFgqtCeX8cH9M3uWFfuxWP mm65gPq42ydKz05p8EgCbgux7nGByLcOz/I2yHlIPxVEqFrEXy0bYCPR2TQTV/it2D86 tu5PZ5tgvQN3T1/vxI7VREI9AlxOFYaHLq+QcZ2pv338dm5Tr4l4BrUs78aZ336Fv+UP lt/1uQIXe++Ah2dEvO5pz6YgTVGC7QIIAW5XCmAxOhX68XOjtjIVN6UiNJks/ipWSOvS B6aQ== X-Gm-Message-State: AKwxyteBX3Q1g9M2NlJAF1s79xgYHV3ZHk321XAtH5PUWgnHWyq6lzBs O/7l+x0mYsTKwwRnQeB4zhOIPBF0PHym61L/grrcrQx4QTQ= X-Google-Smtp-Source: ACJfBovQScq/bAjlWGI6f9D94de9m7N+SXWbofTIUFQkQF2HyWDARPLYFY/6KHJRVRGKJU4uIyji4I/xW5Qxj7GVcL8= X-Received: by 10.36.135.138 with SMTP id f132mr15446293ite.144.1516037295590; Mon, 15 Jan 2018 09:28:15 -0800 (PST) Original-Received: by 10.107.144.85 with HTTP; Mon, 15 Jan 2018 09:28:15 -0800 (PST) X-Originating-IP: [209.6.49.22] X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142179 Archived-At: --94eb2c03c8887887680562d3f071 Content-Type: text/plain; charset="UTF-8" In git rev e335e1949, back in 2001, compilation-parse-errors-filename-function was introduced to compile.el, to postprocess filenames. Somewhere in the last few months, emacs has stopped calling that function from compilation-find-file, so it no longer works. (It's still called from a function that now only is used for display, so it doesn't actually find the processed filename.) This patch re-adds it to the new processing path: modified lisp/progmodes/compile.el @@ -2745,8 +2745,11 @@ compilation-find-file ;; For each directory, try each format string. (while (and fmts (null buffer)) (setq name (expand-file-name (format (car fmts) filename) thisdir) - buffer (and (file-exists-p name) - (find-file-noselect name)) + processed-name (if (boundp 'compilation-parse-errors-filename-function) + (funcall compilation-parse-errors-filename-function name) + name) + buffer (and (file-exists-p processed-name) + (find-file-noselect processed-name)) fmts (cdr fmts))) (setq dirs (cdr dirs))) (while (null buffer) ;Repeat until the user selects an existing file. By the way, I did file an emacs contributor release form some years ago. Hope this is helpful; Gary Oberbrunner -- Gary --94eb2c03c8887887680562d3f071 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
In git rev e335e1949, back in 2001, compilation-parse= -errors-filename-function was introduced to compile.el, to postprocess file= names. Somewhere in the last few months, emacs has stopped calling that fun= ction from compilation-find-file, so it no longer works. (It's still ca= lled from a function that now only is used for display, so it doesn't a= ctually find the processed filename.)

This patch r= e-adds it to the new processing path:

modified=C2= =A0 =C2=A0lisp/progmodes/compile.el
@@ -2745,8 +2745,11 @@ compil= ation-find-file
=C2=A0 =C2=A0 =C2=A0 =C2=A0;; For each directory,= try each format string.
=C2=A0 =C2=A0 =C2=A0 =C2=A0(while (and f= mts (null buffer))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(setq name (= expand-file-name (format (car fmts) filename) thisdir)
-=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 buffer (and (file-exists-p name)<= /div>
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 (find-file-noselect name))
+ =C2=A0 =C2=A0 =C2=A0 processed-name (if (bou= ndp 'compilation-parse-errors-filename-function)
+ (funcall compilation-parse-errors-filename= -function name)
+ =C2=A0= =C2=A0 =C2=A0 =C2=A0name)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 buffer (and (file-exists-p processed-name)
+=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 (find-file-noselect processed-name))
=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0fmts (cdr fmts)))
=C2=A0 = =C2=A0 =C2=A0 =C2=A0(setq dirs (cdr dirs)))
=C2=A0 =C2=A0 =C2=A0(= while (null buffer)=C2=A0 =C2=A0 ;Repeat until the user selects an existing= file.

By the way, I did file an emacs contributor= release form some years ago.

Hope this is helpful= ;

Gary Oberbrunner

--
Gary
--94eb2c03c8887887680562d3f071--