all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Gary Oberbrunner <garyo@oberbrunner.com>
To: 30131@debbugs.gnu.org
Subject: bug#30131: 26.0.50; compile.el no longer calls compilation-parse-errors-filename-function
Date: Mon, 15 Jan 2018 12:28:15 -0500	[thread overview]
Message-ID: <CAFChFyjsQePQTawCL0AtK6Vh-v3HsVyrGOniGGbYn-UdUfj4aA@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1332 bytes --]

In git rev e335e1949, back in 2001,
compilation-parse-errors-filename-function was introduced to compile.el, to
postprocess filenames. Somewhere in the last few months, emacs has stopped
calling that function from compilation-find-file, so it no longer works.
(It's still called from a function that now only is used for display, so it
doesn't actually find the processed filename.)

This patch re-adds it to the new processing path:

modified   lisp/progmodes/compile.el
@@ -2745,8 +2745,11 @@ compilation-find-file
       ;; For each directory, try each format string.
       (while (and fmts (null buffer))
         (setq name (expand-file-name (format (car fmts) filename) thisdir)
-              buffer (and (file-exists-p name)
-                          (find-file-noselect name))
+       processed-name (if (boundp
'compilation-parse-errors-filename-function)
+ (funcall compilation-parse-errors-filename-function name)
+        name)
+              buffer (and (file-exists-p processed-name)
+                          (find-file-noselect processed-name))
               fmts (cdr fmts)))
       (setq dirs (cdr dirs)))
     (while (null buffer)    ;Repeat until the user selects an existing
file.

By the way, I did file an emacs contributor release form some years ago.

Hope this is helpful;

Gary Oberbrunner

-- 
Gary

[-- Attachment #2: Type: text/html, Size: 1918 bytes --]

             reply	other threads:[~2018-01-15 17:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-15 17:28 Gary Oberbrunner [this message]
2018-01-16  0:43 ` bug#30131: 26.0.50; compile.el no longer calls compilation-parse-errors-filename-function Noam Postavsky
2018-01-16  1:09   ` Gary Oberbrunner
2018-01-16  1:16     ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFChFyjsQePQTawCL0AtK6Vh-v3HsVyrGOniGGbYn-UdUfj4aA@mail.gmail.com \
    --to=garyo@oberbrunner.com \
    --cc=30131@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.