From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Gary Oberbrunner Newsgroups: gmane.emacs.devel Subject: project.el: git submodules? Date: Tue, 12 May 2020 11:31:39 -0400 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="80717"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 12 17:44:46 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jYX5I-000KpN-Ew for ged-emacs-devel@m.gmane-mx.org; Tue, 12 May 2020 17:44:44 +0200 Original-Received: from localhost ([::1]:52396 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYX5H-0002lN-EP for ged-emacs-devel@m.gmane-mx.org; Tue, 12 May 2020 11:44:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39108) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYWsu-0001Kx-Kf for emacs-devel@gnu.org; Tue, 12 May 2020 11:31:56 -0400 Original-Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]:38416) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jYWss-0001b2-Up for emacs-devel@gnu.org; Tue, 12 May 2020 11:31:56 -0400 Original-Received: by mail-ed1-x529.google.com with SMTP id r16so11465902edw.5 for ; Tue, 12 May 2020 08:31:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oberbrunner.com; s=google; h=mime-version:from:date:message-id:subject:to; bh=uj2KeeOE1aeTSShGm6lZam/TffY/WEa4v8uCDCzI79Y=; b=FrfUD10xG/kcjGi1ViHYBj2dqcKKB/valEISECcUrB+CofqhPbr0nNYuzUy00AR9rP kaAmADs6s0Tv4KYUfbV3v7cpyHP5Cdg0yapJFpuqrLhpz3xNh4wZuGHlMqylJ0+rHyZz BFzNLbS9zwiGuvBiC+EdJqTCcBaN3WcTUC5N609DHzkqE6HORpye7Kg4GoRGEmvLHBXt HbBJP0ol+UKGAr/eLjNr0IMiG4YootoxjvNw16Eq6VE0NQwMCqaUI3H1TG2YIq0vdkV9 Fjqs+6NnzAagCmc3nvMfHZ+oZG/JF8lGPkKJzr02dzE8dP5WwevVjQureiBIWKfDumtu AYTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=uj2KeeOE1aeTSShGm6lZam/TffY/WEa4v8uCDCzI79Y=; b=h071/FFq4bfufNetz6CCqnw2Ho2wIjQR320O9QyzPSw2dTbVmxLtoCJt4Ebc72tdFV nxRWgvZh59HtsucMGNduwfFXMhwjspqphuyrXuMd1FFa5l1Tz0a8NSHc8sY/N/M0rl0P Cj0y75/gjrRFh716BjxCImAd6OPlQiukgB8lW6hVUFcOGAUl3YdhiqzHl5tcX72JC2pd RU7HXWzGW6vkB1YQ0TTbd5mlWrIEtwrLWW9ZonvdFT5k565F0CX2ieAzj6vNJuxAuba0 zqQfUzATAqIDaNNXCy3lfSE5I91c6Mfd52/oBxTPXUwT1+Tc12nxkK23b64pDRvm7A3N b5zA== X-Gm-Message-State: AGi0PuayiQXSjtkTFYvNAwKHKGMou7gBKtAPJ/umsORbHVRQb1JbiYdE ry1vDK/NlzNoS82uS6+2ahl2pwrNLwsBHq7CZY4wsoJ3YwwHtQ== X-Google-Smtp-Source: APiQypLq/eS9hXZXYGC4WpS9ruAxJdytjNlZfTpY35Urjj3PMiXIC+0UlMVvCcB0NkQeTH8NOv41epTCJx8Wpo0FhzY= X-Received: by 2002:a50:fa8d:: with SMTP id w13mr13483315edr.280.1589297510889; Tue, 12 May 2020 08:31:50 -0700 (PDT) Received-SPF: pass client-ip=2a00:1450:4864:20::529; envelope-from=garyo@oberbrunner.com; helo=mail-ed1-x529.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:249981 Archived-At: In project.el as of 3f2788d4acd53 (Dec 27 2019), there is this code: + (pcase backend + ('Git + ;; Don't stop at submodule boundary. + (or (vc-file-getprop dir 'project-git-root) + (vc-file-setprop dir 'project-git-root + (vc-find-root dir ".git/")))) That is not working in my situation, by which I mean I call (project-current) in a buffer in a git submodule and it returns '(Git . "submodule-root") rather than the actual project root, despite the comment there that says it shouldn't do that. Following through the code I don't see how it's supposed to be detecting that it's in a submodule. Looks like it just looks upwards for the dominating ".git/" dir. In a simple test it appears to work, but not in my real-world case. Before I dig deeper into it, can anyone (Dmitry?) tell me where to look for the submodule-detection logic? -- Gary