From: Gary Oberbrunner <garyo@oberbrunner.com>
To: emacs-devel@gnu.org
Subject: project.el: git submodules?
Date: Tue, 12 May 2020 11:31:39 -0400 [thread overview]
Message-ID: <CAFChFyjddpB5-5YZAnrK9_BnoJXorp3CycpdaEct4qcUQ9fwnw@mail.gmail.com> (raw)
In project.el as of 3f2788d4acd53 (Dec 27 2019), there is this code:
+ (pcase backend
+ ('Git
+ ;; Don't stop at submodule boundary.
+ (or (vc-file-getprop dir 'project-git-root)
+ (vc-file-setprop dir 'project-git-root
+ (vc-find-root dir ".git/"))))
That is not working in my situation, by which I mean I call
(project-current) in a buffer in a git submodule and it returns '(Git
. "submodule-root") rather than the actual project root, despite the
comment there that says it shouldn't do that. Following through the
code I don't see how it's supposed to be detecting that it's in a
submodule. Looks like it just looks upwards for the dominating ".git/"
dir.
In a simple test it appears to work, but not in my real-world case.
Before I dig deeper into it, can anyone (Dmitry?) tell me where to
look for the submodule-detection logic?
--
Gary
next reply other threads:[~2020-05-12 15:31 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 15:31 Gary Oberbrunner [this message]
2020-05-12 15:53 ` project.el: git submodules? Dmitry Gutov
2020-05-12 18:05 ` Michael Welsh Duggan
2020-05-12 18:27 ` Dmitry Gutov
2020-05-12 19:36 ` Stefan Monnier
2020-05-12 19:39 ` Dmitry Gutov
2020-05-12 20:45 ` Michael Welsh Duggan
2020-05-12 20:53 ` Dmitry Gutov
2020-05-12 21:04 ` Stefan Monnier
2020-05-12 21:06 ` Dmitry Gutov
2020-05-12 21:09 ` Stefan Monnier
2020-05-14 0:32 ` Dmitry Gutov
2020-05-14 2:55 ` Stefan Monnier
2020-05-14 15:04 ` Dmitry Gutov
2020-05-14 17:57 ` Stefan Monnier
2020-05-14 19:29 ` Dmitry Gutov
2020-05-14 20:01 ` Stefan Monnier
2020-05-14 20:13 ` Dmitry Gutov
2020-05-14 21:17 ` Dmitry Gutov
2020-05-14 21:38 ` Michael Welsh Duggan
2020-05-15 1:21 ` Dmitry Gutov
2020-05-15 5:11 ` Dmitry Gutov
2020-05-15 7:40 ` Kévin Le Gouguec
2020-05-15 19:17 ` Dmitry Gutov
2020-05-12 20:53 ` Michael Welsh Duggan
2020-05-12 20:51 ` Michael Welsh Duggan
2020-05-12 20:58 ` John Yates
2020-05-13 7:19 ` Andreas Schwab
2020-05-12 18:33 ` Gary Oberbrunner
2020-05-12 19:28 ` Dmitry Gutov
2020-05-12 19:34 ` Gary Oberbrunner
2020-05-12 19:41 ` Dmitry Gutov
2020-05-12 19:44 ` Doug Davis
2020-05-12 19:50 ` Gary Oberbrunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFChFyjddpB5-5YZAnrK9_BnoJXorp3CycpdaEct4qcUQ9fwnw@mail.gmail.com \
--to=garyo@oberbrunner.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.