From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Gary Oberbrunner Newsgroups: gmane.emacs.bugs Subject: bug#30131: 26.0.50; compile.el no longer calls compilation-parse-errors-filename-function Date: Mon, 15 Jan 2018 20:09:12 -0500 Message-ID: References: <876082pra4.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="f4f5e80328d0f855a40562da609e" X-Trace: blaine.gmane.org 1516064897 28357 195.159.176.226 (16 Jan 2018 01:08:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 16 Jan 2018 01:08:17 +0000 (UTC) Cc: 30131@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 16 02:08:13 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebFjY-0006vy-5r for geb-bug-gnu-emacs@m.gmane.org; Tue, 16 Jan 2018 02:08:12 +0100 Original-Received: from localhost ([::1]:50274 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebFlW-0006hR-AI for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Jan 2018 20:10:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34340) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebFlP-0006gl-H3 for bug-gnu-emacs@gnu.org; Mon, 15 Jan 2018 20:10:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebFlK-0006Dr-ER for bug-gnu-emacs@gnu.org; Mon, 15 Jan 2018 20:10:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50011) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ebFlK-0006Dj-7B for bug-gnu-emacs@gnu.org; Mon, 15 Jan 2018 20:10:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ebFlJ-0001NW-Vr for bug-gnu-emacs@gnu.org; Mon, 15 Jan 2018 20:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gary Oberbrunner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Jan 2018 01:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30131 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30131-submit@debbugs.gnu.org id=B30131.15160649615242 (code B ref 30131); Tue, 16 Jan 2018 01:10:01 +0000 Original-Received: (at 30131) by debbugs.gnu.org; 16 Jan 2018 01:09:21 +0000 Original-Received: from localhost ([127.0.0.1]:57908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebFke-0001MU-MM for submit@debbugs.gnu.org; Mon, 15 Jan 2018 20:09:20 -0500 Original-Received: from mail-io0-f180.google.com ([209.85.223.180]:45010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebFkc-0001ME-JJ for 30131@debbugs.gnu.org; Mon, 15 Jan 2018 20:09:18 -0500 Original-Received: by mail-io0-f180.google.com with SMTP id k18so14991188ioc.11 for <30131@debbugs.gnu.org>; Mon, 15 Jan 2018 17:09:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oberbrunner-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=cnqFg8T855+P2q5JNBZSqpA7oosqlYZB15dJtP7M4d0=; b=hBYaRZsphPO8A3DsvyOiIo6/m4jdxV9jgnLv4X5UGJvAAJQgdKri8MgiLiY7ctyUwJ 1C1w5ESAD7hIaLAhypUGKIq2KRqEpJibOY3Ebo/R4UUeWu998sHM4MZYLNW0xiQ0IMZa hGQbir5zEa8nQmjduUHh6oPZiNRIcPex6ak/8Mks2+PClqgQyJJH+2PX7O+jet00dNsd au0Op6U8xF7ZQplqtMpowIiZ6w37vvF4jjDwQsmy1YSie/78BUUCE61fHfqdms1l81dN WFdsK6SPczmjx0eU5tjN2yB9k9LTl+1XYwowaa1E4f9WquXJzNZsi++AeBwE/nxH5HQ6 P5oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=cnqFg8T855+P2q5JNBZSqpA7oosqlYZB15dJtP7M4d0=; b=iW87VjA0sN7KjGcyjK7u6iyPpA/KGAZYHoD7Ah4TwCEuBx/7flKkxNnTZ1mDbDgDsJ hAn3AYaSJmo/rbyU+cWnpMd6jlQvLj5GSMJQO9hMbHGxykh4LaQvGA7kDzyocambI+Yo 9Gzcv2Os/yeFd5p2RUvPfMMb+I7wFCP2LZ8EiPTQ1YeoL8MZy1o4pSB82c0wORWdwsK0 5MqSS0IjQDoJM+6EDL2K49pC4AuY8nRoStzBtCtKsxS/aJpNa6yJXNq04lEQbdRf2vvm TJBj7LS119Dxpg+l6a7ALkvPNEr/d+8FTS3M6vtngRxAm8ijxHXMLX6gHQXjX73EBQdU 4NAw== X-Gm-Message-State: AKwxytf2t5HzwyAo8McHqjy3JB9APmmvnEtZa9kK3EXvxgtVBSESqjqm QUT7EDwE03hqxhjp/a8tGN9TGwqoywsfp2Au54rGIw== X-Google-Smtp-Source: ACJfBoszFAzeK5tNLFzwdHTite3p9OBDog3eDV0mucsqyBQBjZR1jsfR0BOizsyTwCuw38woDOHov3UyDI5n36lm7LU= X-Received: by 10.107.79.19 with SMTP id d19mr2064714iob.263.1516064952826; Mon, 15 Jan 2018 17:09:12 -0800 (PST) Original-Received: by 10.107.144.85 with HTTP; Mon, 15 Jan 2018 17:09:12 -0800 (PST) X-Originating-IP: [209.6.49.22] In-Reply-To: <876082pra4.fsf@users.sourceforge.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142193 Archived-At: --f4f5e80328d0f855a40562da609e Content-Type: text/plain; charset="UTF-8" My apologies. I retract this patch. I had a bug on my end that made it look like it wasn't calling my function, or not in the right place. But I just retested it and it works fine. -- Gary On Mon, Jan 15, 2018 at 7:43 PM, Noam Postavsky < npostavs@users.sourceforge.net> wrote: > Gary Oberbrunner writes: > > > In git rev e335e1949, back in 2001, > > compilation-parse-errors-filename-function was introduced to > > compile.el, to postprocess filenames. Somewhere in the last few > > months, emacs has stopped calling that function from > > compilation-find-file, so it no longer works. (It's still called from > > a function that now only is used for display, so it doesn't actually > > find the processed filename.) > > As far as I can tell, it was never called from compilation-find-file. > Not in e335e1949 that you referenced above, not in 25.3, 25.4, nor 24.3. > > In all recent Emacs versions, including latest emacs-26 and master, it > is called from compilation-get-file-structure. > > (defun compilation-get-file-structure (file &optional fmt) > [...] > ;; If compilation-parse-errors-filename-function is > ;; defined, use it to process the filename. > (when compilation-parse-errors-filename-function > (setq filename > (funcall compilation-parse-errors-filename-function > filename))) > -- Gary --f4f5e80328d0f855a40562da609e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
My apologies. I retract this patch. I had a bug on my end = that made it look like it wasn't calling my function, or not in the rig= ht place. But I just retested it and it works fine.

-- G= ary

On= Mon, Jan 15, 2018 at 7:43 PM, Noam Postavsky <npostavs@users= .sourceforge.net> wrote:
Ga= ry Oberbrunner <garyo@oberbrunn= er.com> writes:

> In git rev e335e1949, back in 2001,
> compilation-parse-errors-filename-function was introduced to
> compile.el, to postprocess filenames. Somewhere in the last few
> months, emacs has stopped calling that function from
> compilation-find-file, so it no longer works. (It's still called f= rom
> a function that now only is used for display, so it doesn't actual= ly
> find the processed filename.)

As far as I can tell, it was never called from compilation-find-file.
Not in e335e1949 that you referenced above, not in 25.3, 25.4, nor 24.3.
In all recent Emacs versions, including latest emacs-26 and master, it
is called from compilation-get-file-structure.

(defun compilation-get-file-structure (file &optional fmt)
=C2=A0 [...]
=C2=A0 =C2=A0 ;; If compilation-parse-errors-filename-function is
=C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; defined, use it to process the filename.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (when compilation-parse-errors-filename-fu= nction
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (setq filename
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (funcall compilatio= n-parse-errors-filename-function
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0filename)))



--
Gary
--f4f5e80328d0f855a40562da609e--