From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jakub =?UTF-8?Q?Je=C4=8Dm=C3=ADnek?= Newsgroups: gmane.emacs.bugs Subject: bug#64205: Fix missing cell border when using orgtbl-to-table.el function Date: Wed, 21 Jun 2023 16:08:13 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000071bdf05fea44d9c" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9048"; mail-complaints-to="usenet@ciao.gmane.io" To: 64205@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 21 17:10:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qBzTU-0002EI-Fo for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Jun 2023 17:10:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qBzTC-0002Kc-Qg; Wed, 21 Jun 2023 11:10:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBzTA-0002Iz-48 for bug-gnu-emacs@gnu.org; Wed, 21 Jun 2023 11:10:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qBzT8-0004FV-3a for bug-gnu-emacs@gnu.org; Wed, 21 Jun 2023 11:10:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qBzT7-00073s-VD for bug-gnu-emacs@gnu.org; Wed, 21 Jun 2023 11:10:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Jakub =?UTF-8?Q?Je=C4=8Dm=C3=ADnek?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Jun 2023 15:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64205 X-GNU-PR-Package: emacs Original-Received: via spool by 64205-submit@debbugs.gnu.org id=B64205.168736014627061 (code B ref 64205); Wed, 21 Jun 2023 15:10:01 +0000 Original-Received: (at 64205) by debbugs.gnu.org; 21 Jun 2023 15:09:06 +0000 Original-Received: from localhost ([127.0.0.1]:33957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBzSD-00072P-Pa for submit@debbugs.gnu.org; Wed, 21 Jun 2023 11:09:06 -0400 Original-Received: from mail-yw1-f179.google.com ([209.85.128.179]:51664) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qByVa-0005Ak-2X for 64205@debbugs.gnu.org; Wed, 21 Jun 2023 10:08:30 -0400 Original-Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-570114e1feaso67501717b3.3 for <64205@debbugs.gnu.org>; Wed, 21 Jun 2023 07:08:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687356504; x=1689948504; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=q5u84epxEFKwapmIp4x91tm4ExR2jhD5GJuSj1Y/dRE=; b=lZNbMhzKhyy3uleO559+E7IBjoybRKRMGRfBJnkVtWUfVtyRPu2PybYvkicXP67qKK HLS/8+4/1Hyp78T526MhLqnd2hysPlBermhubURT7NuWUnt7I/+rwonba9LfrDYy/Cyv M8PCmGkdVv40e6EPwoQaxmvu8dHt6LZcaXccuIMMldr6P0rcggXdy4D8vjcRfq/XT3C8 TM+0EUs2IocSoMe0gnh4X6slB7g/LfdONSXOg84etTOsmpNvwzXWjJZgMMwisiFkSx3D K9uMNzaABj15DiGQTuCyFWVVWVlC0qzxMKfT+U7r1CqSIG4DiH15FI8eLuVv9jiZ/HBJ uQ3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687356504; x=1689948504; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=q5u84epxEFKwapmIp4x91tm4ExR2jhD5GJuSj1Y/dRE=; b=ZvbdR5BinOUB+wdRa3jHsxY8fCAG2+pb2Y7cveeGxomqB87vAbh21+8oFgOpjgw0ZO c0KfPHLOYymZuHZsxd85tJnQO8wKjVAjfBS+Ba3LI+Bh8wg8Whxqvekb49xDdPjAVF4E RZWJRfpnIWzlJaF7PUbrNt4tZ8Rp9TxH1+3mYCU87A6QUk9JKlsXbnpI14+So2mEXTiJ Dmuj5IhMQiBzxF4YelR97j65s879LRl9bAvY0wLS88kRjhYtMQTKX0/rcTek4gcDQkC7 DFJ4PMt4vhhUj6TImHHGKoWi3Ynqk7lA7McIPrgy4IiFpNYb82skcjTQ3FgYQ766ko+A mRBA== X-Gm-Message-State: AC+VfDwDHc1+MB03akmyKo9TaXbBMkj8Su4Fz9vAehTvy8pNpAM9rQBp smsEDyuLmtV/LKUmUnYnrQQkRLEzyG5PKDvPTslYD6+YIRQ= X-Google-Smtp-Source: ACHHUZ4ETZd87Iyn5CFlkkvhviEwa+lXEwHv+GnSLP/kID2BPRldsfUZQOmWoAmcL0ZZ2lOe9dPH66nkz8oaio2oBK0= X-Received: by 2002:a0d:cb17:0:b0:568:d586:77bd with SMTP id n23-20020a0dcb17000000b00568d58677bdmr15448882ywd.1.1687356503934; Wed, 21 Jun 2023 07:08:23 -0700 (PDT) X-Mailman-Approved-At: Wed, 21 Jun 2023 11:09:04 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263831 Archived-At: --000000000000071bdf05fea44d9c Content-Type: multipart/alternative; boundary="000000000000071bdc05fea44d9a" --000000000000071bdc05fea44d9a Content-Type: text/plain; charset="UTF-8" Hello Robert, thank you for your response. I'm sending a new patch in the attachment. I've also instrumented the function using the `elp' package, here are the results: Function Name Call Count Elapsed Time Average Time orgtbl-to-table.el-old 1001 2.6707780000 0.0026681098 orgtbl-to-table.el-new 1001 2.4684200000 0.0024659540 New version is indeed a little bit faster. Best, Jakub --000000000000071bdc05fea44d9a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello Robert, thank you for your response.

<= div>I'm sending a new patch in the attachment. I've also instrument= ed the function using the `elp' package, here are the results:

Function Name =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Call Coun= t =C2=A0Elapsed Time =C2=A0Average Time
orgtbl-to-table.el-old =C2=A0100= 1 =C2=A0 =C2=A0 =C2=A0 =C2=A02.6707780000 =C2=A00.0026681098
orgtbl-to-t= able.el-new =C2=A01001 =C2=A0 =C2=A0 =C2=A0 =C2=A02.4684200000 =C2=A00.0024= 659540

New version is indeed a little bit fast= er.

Best, Jakub
--000000000000071bdc05fea44d9a-- --000000000000071bdf05fea44d9c Content-Type: application/octet-stream; name="0001-Fix-orgtbl-to-table.el-function-to-include-last-cell.patch" Content-Disposition: attachment; filename="0001-Fix-orgtbl-to-table.el-function-to-include-last-cell.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lj5sf3u90 RnJvbSBkY2I3ZGZiMjAxNTczOTBkZDRiMjM0YzkyOWNlNDVkMDU4ZGE0OGQ1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/SmFrdWI9MjBKZT1DND04RG09QzM9QURuZWs/ PSA8amVjbWluZWsua0BnbWFpbC5jb20+CkRhdGU6IFdlZCwgMjEgSnVuIDIwMjMgMTU6NTA6MzEg KzAyMDAKU3ViamVjdDogW1BBVENIXSBGaXggb3JndGJsLXRvLXRhYmxlLmVsIGZ1bmN0aW9uIHRv IGluY2x1ZGUgbGFzdCBjZWxsIGJvcmRlcgoKKiBsaXNwL29yZy9vcmctdGFibGUuZWwgKG9yZ3Ri bC10by10YWJsZS5lbCk6IFBlcmZvcm0gY2hhcmFjdGVyCnJlcGxhY2VtZW50IGluIHRoZSB0ZW1w IGJ1ZmZlciBhbmQgZml4IG1pc3NpbmcgY2VsbCBib3JkZXIuIChCdWcgIzY0MjA1KQotLS0KIGxp c3Avb3JnL29yZy10YWJsZS5lbCB8IDEwICsrKysrKystLS0KIDEgZmlsZSBjaGFuZ2VkLCA3IGlu c2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9vcmcvb3JnLXRh YmxlLmVsIGIvbGlzcC9vcmcvb3JnLXRhYmxlLmVsCmluZGV4IDQyZjIzNDc5MGM1Li42ODEwZmQ4 ZGM1YSAxMDA2NDQKLS0tIGEvbGlzcC9vcmcvb3JnLXRhYmxlLmVsCisrKyBiL2xpc3Avb3JnL29y Zy10YWJsZS5lbApAQCAtNjEzMiw5ICs2MTMyLDEzIEBAIHN1cHBvcnRlZC4iCiAgICh3aXRoLXRl bXAtYnVmZmVyCiAgICAgKGluc2VydCAob3JndGJsLXRvLW9yZ3RibCB0YWJsZSBwYXJhbXMpKQog ICAgIChvcmctdGFibGUtYWxpZ24pCi0gICAgKHJlcGxhY2UtcmVnZXhwLWluLXN0cmluZwotICAg ICAiLXwiICItKyIKLSAgICAgKHJlcGxhY2UtcmVnZXhwLWluLXN0cmluZyAifC0iICIrLSIgKGJ1 ZmZlci1zdWJzdHJpbmcgMSAoYnVmZmVyLXNpemUpKSkpKSkKKyAgICAoZ290by1jaGFyIChwb2lu dC1taW4pKQorICAgICh3aGlsZSAocmUtc2VhcmNoLWZvcndhcmQgIi18IiBuaWwgdCkKKyAgICAg IChyZXBsYWNlLW1hdGNoICItKyIpKQorICAgIChnb3RvLWNoYXIgKHBvaW50LW1pbikpCisgICAg KHdoaWxlIChyZS1zZWFyY2gtZm9yd2FyZCAifC0iIG5pbCB0KQorICAgICAgKHJlcGxhY2UtbWF0 Y2ggIistIikpCisgICAgKGJ1ZmZlci1zdHJpbmcpKSkKIAogKGRlZnVuIG9yZ3RibC10by11bmlj b2RlICh0YWJsZSBwYXJhbXMpCiAgICJDb252ZXJ0IHRoZSBgb3JndGJsLW1vZGUnIFRBQkxFIGlu dG8gYSB0YWJsZSB3aXRoIHVuaWNvZGUgY2hhcmFjdGVycy4KLS0gCjIuMzkuMQoK --000000000000071bdf05fea44d9c--