From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Justin Burkett Newsgroups: gmane.emacs.devel Subject: Re: Proposed patch for lookup-key Date: Thu, 14 Dec 2017 20:31:35 -0500 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="94eb2c0da4821c5817056056f6a7" X-Trace: blaine.gmane.org 1513301511 30931 195.159.176.226 (15 Dec 2017 01:31:51 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 15 Dec 2017 01:31:51 +0000 (UTC) To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 15 02:31:46 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePeqn-0007cs-FD for ged-emacs-devel@m.gmane.org; Fri, 15 Dec 2017 02:31:45 +0100 Original-Received: from localhost ([::1]:43716 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ePeqs-0003bp-U5 for ged-emacs-devel@m.gmane.org; Thu, 14 Dec 2017 20:31:50 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41917) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ePeqk-0003bh-Ap for emacs-devel@gnu.org; Thu, 14 Dec 2017 20:31:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ePeqf-0006BD-KB for emacs-devel@gnu.org; Thu, 14 Dec 2017 20:31:42 -0500 Original-Received: from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]:36978) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ePeqf-000673-9J for emacs-devel@gnu.org; Thu, 14 Dec 2017 20:31:37 -0500 Original-Received: by mail-wm0-x231.google.com with SMTP id f140so14722042wmd.2 for ; Thu, 14 Dec 2017 17:31:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=burkett-cc.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=zkJeK3Cybly6EWop0SEOrwiW8qbtEmUkouOCueZuaoA=; b=Syw3rRUCZPTDbejyiipMdTKFhJ5V2DtDFrwKbq4Lzb4h9HO1St+eqw33PkJTmtBqO5 m6xdSO1vywX42nVZiwEsk/IItj7XKsVjScFELCbiyondMzuPIlCcGbUu2W4Q/P2TQz48 z3O91WkXoTlvpj1vbIovy4e+qGmQ/oR6DG8kArWrJn6yqfAQbhPqiPhomLLG0+CuIuKT HNUc/963dYVjY5F/ZE6ijnZCuSuB0JFf2T8X1fp6THAx/Hm695wmZeF9TZznHGl6J9R7 PmvE4rkxHEmelz7wCjJmgI5BQxHEma6WR/MHWEu5huOlvqyoGqZVj0RKH82G+GlVH5hs 3gYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=zkJeK3Cybly6EWop0SEOrwiW8qbtEmUkouOCueZuaoA=; b=fo+q0Vn5YTt1cpmF0LZrP+I+liFpRNrE2AbVyOWS0gGz8zAadjNuMXyY9AvIvVvkq4 arQXYyVBeFg54r3zowe6YVsSJ99WUQdTucaxrnsTNCe7w78qYW9PFKm7EN/iBm94Q0xh NDrAHPEe50p8haqx+7RDzekCWkShpLoW6jybliC2L0eRxR+TOniv/95ydd6vRDkWzNP+ sNGtfI1VAedPnE+64Ev6empaPlHPJWMNDCa2N1DcIJq5ea/j6lDs4vdxTlxNDjMjiG+J H18ykrUJgq4/Ve8dKrif779qxVnpJz+0iMtlq6MgGL9Pfie//umSdFKwnR7U3mMmbTaP JarQ== X-Gm-Message-State: AKGB3mI3SpXK/5FMq9kkLD6gWKpe2l5ezYCI+vnNRGK8sQ0HBcScD45r jlPQXPZnLRokbk+I7mSmuqEqVZ32xh7ZjeQ9o5iqt+Kx X-Google-Smtp-Source: ACJfBos5P0Qey7HXq/t19xJ3f8tSyi/7nZCg19tmVFwLwGKAK4PzmPyQYiyD/rSFmpRahKlpd1finlySqWmQzF4tHYI= X-Received: by 10.80.160.198 with SMTP id 64mr15009739edo.242.1513301496022; Thu, 14 Dec 2017 17:31:36 -0800 (PST) Original-Received: by 10.80.132.101 with HTTP; Thu, 14 Dec 2017 17:31:35 -0800 (PST) X-Originating-IP: [104.138.194.173] In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:221078 Archived-At: --94eb2c0da4821c5817056056f6a7 Content-Type: multipart/alternative; boundary="94eb2c0da4821c5812056056f6a5" --94eb2c0da4821c5812056056f6a5 Content-Type: text/plain; charset="UTF-8" Here's a similar patch for `key-binding` Justin On Thu, Dec 14, 2017 at 2:44 PM, Justin Burkett wrote: > Hi all, > > I'd like to be able to access more information about key bindings of the > form (DESCRIPTION . DEF) and menu-items. As far as I can tell there's no > easy way to do this using built-in tools in a robust way (i.e., without > manually having to write a lookup-key function). > > I'm wondering if the attached patch would be acceptable. The idea was to > add an optional argument to lookup-key to prevent it from stripping this > information about the key bindings. > > In principle, I might also like to do something similar for the > key-binding function, but the current patch is sufficient for my purposes. > > I have assigned copyright to the FSF, but this would be my first commit > against Emacs. I apologize in advance for overlooking some convention. > > Thanks, > Justin > --94eb2c0da4821c5812056056f6a5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Here's a similar patch for `key-binding`

Justin=C2=A0

On Thu, Dec 14, 2017 at 2:44 PM, Justin Burkett <justin@burke= tt.cc> wrote:
Hi all,=C2=A0

I'd like to be able to access more= information about key bindings of the form (DESCRIPTION . DEF) and menu-it= ems. As far as I can tell there's no easy way to do this using built-in= tools in a robust way (i.e., without manually having to write a lookup-key= function).=C2=A0

I'm wondering if the attache= d patch would be acceptable. The idea was to add an optional argument to lo= okup-key to prevent it from stripping this information about the key bindin= gs.=C2=A0

In principle, I might also like to do so= mething similar for the key-binding function, but the current patch is suff= icient for my purposes.=C2=A0

I have assigned copy= right to the FSF, but this would be my first commit against Emacs. I apolog= ize in advance for overlooking some convention.=C2=A0

<= div>Thanks,=C2=A0
= Justin=C2=A0

--94eb2c0da4821c5812056056f6a5-- --94eb2c0da4821c5817056056f6a7 Content-Type: application/octet-stream; name="0001-Allow-key-binding-to-return-full-menu-item-entries.patch" Content-Disposition: attachment; filename="0001-Allow-key-binding-to-return-full-menu-item-entries.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jb78mvin1 RnJvbSBkMzdiOWI2OThkNzhmN2JjODMwYWZmOWVkMGNiZWY2ZjdmMDE1YzM4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKdXN0aW4gQnVya2V0dCA8anVzdGluQGJ1cmtldHQuY2M+CkRh dGU6IFRodSwgMTQgRGVjIDIwMTcgMjA6MjY6NDcgLTA1MDAKU3ViamVjdDogW1BBVENIXSBBbGxv dyBrZXktYmluZGluZyB0byByZXR1cm4gZnVsbCBtZW51LWl0ZW0gZW50cmllcwoKKiBzcmMva2V5 Ym9hcmQuYyAocGFyc2VfbWVudV9pdGVtKTogQWRqdXN0IGNhbGwgdG8gRmtleV9iaW5kaW5nCiog c3JjL2tleW1hcC5jIChGY29tbWFuZF9yZW1hcHBpbmcpOiBBZGp1c3QgY2FsbCB0byBGa2V5X2Jp bmRpbmcKKEZrZXlfYmluZGluZyk6IEFkZCBtZW51cyBhcmcKLS0tCiBzcmMva2V5Ym9hcmQuYyB8 ICAyICstCiBzcmMva2V5bWFwLmMgICB8IDEyICsrKysrKysrLS0tLQogMiBmaWxlcyBjaGFuZ2Vk LCA5IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2tleWJv YXJkLmMgYi9zcmMva2V5Ym9hcmQuYwppbmRleCAxMGVhZDBjMWFiLi5jNmYyMzVmYjhiIDEwMDY0 NAotLS0gYS9zcmMva2V5Ym9hcmQuYworKysgYi9zcmMva2V5Ym9hcmQuYwpAQCAtNzg5Nyw3ICs3 ODk3LDcgQEAgcGFyc2VfbWVudV9pdGVtIChMaXNwX09iamVjdCBpdGVtLCBpbnQgaW5tZW51YmFy KQogCWlmIChDT05TUCAoa2V5aGludCkgJiYgIU5JTFAgKFhDQVIgKGtleWhpbnQpKSkKIAkgIHsK IAkgICAga2V5cyA9IFhDQVIgKGtleWhpbnQpOwotCSAgICB0ZW0gPSBGa2V5X2JpbmRpbmcgKGtl eXMsIFFuaWwsIFFuaWwsIFFuaWwpOworCSAgICB0ZW0gPSBGa2V5X2JpbmRpbmcgKGtleXMsIFFu aWwsIFFuaWwsIFFuaWwsIFFuaWwpOwogCiAJICAgIC8qIFdlIGhhdmUgYSBzdWdnZXN0ZWQga2V5 LiAgSXMgaXQgYm91bmQgdG8gdGhlIGNvbW1hbmQ/ICAqLwogCSAgICBpZiAoTklMUCAodGVtKQpk aWZmIC0tZ2l0IGEvc3JjL2tleW1hcC5jIGIvc3JjL2tleW1hcC5jCmluZGV4IDZmYWM0NzhjZGEu LjFkNTNmOGY4YjYgMTAwNjQ0Ci0tLSBhL3NyYy9rZXltYXAuYworKysgYi9zcmMva2V5bWFwLmMK QEAgLTExODgsNyArMTE4OCw3IEBAIHJlbWFwcGluZyBpbiBhbGwgY3VycmVudGx5IGFjdGl2ZSBr ZXltYXBzLiAgKi8pCiAgIEFTRVQgKGNvbW1hbmRfcmVtYXBwaW5nX3ZlY3RvciwgMSwgY29tbWFu ZCk7CiAKICAgaWYgKE5JTFAgKGtleW1hcHMpKQotICAgIGNvbW1hbmQgPSBGa2V5X2JpbmRpbmcg KGNvbW1hbmRfcmVtYXBwaW5nX3ZlY3RvciwgUW5pbCwgUXQsIHBvc2l0aW9uKTsKKyAgICBjb21t YW5kID0gRmtleV9iaW5kaW5nIChjb21tYW5kX3JlbWFwcGluZ192ZWN0b3IsIFFuaWwsIFF0LCBw b3NpdGlvbiwgUW5pbCk7CiAgIGVsc2UKICAgICBjb21tYW5kID0gRmxvb2t1cF9rZXkgKEZjb25z IChRa2V5bWFwLCBrZXltYXBzKSwKIAkJCSAgIGNvbW1hbmRfcmVtYXBwaW5nX3ZlY3RvciwgUW5p bCwgUW5pbCk7CkBAIC0xNjEwLDcgKzE2MTAsNyBAQCBsaWtlIGluIHRoZSByZXNwZWN0aXZlIGFy Z3VtZW50IG9mIGBrZXktYmluZGluZycuICAqLykKIAogLyogR0MgaXMgcG9zc2libGUgaW4gdGhp cyBmdW5jdGlvbiBpZiBpdCBhdXRvbG9hZHMgYSBrZXltYXAuICAqLwogCi1ERUZVTiAoImtleS1i aW5kaW5nIiwgRmtleV9iaW5kaW5nLCBTa2V5X2JpbmRpbmcsIDEsIDQsIDAsCitERUZVTiAoImtl eS1iaW5kaW5nIiwgRmtleV9iaW5kaW5nLCBTa2V5X2JpbmRpbmcsIDEsIDUsIDAsCiAgICAgICAg ZG9jOiAvKiBSZXR1cm4gdGhlIGJpbmRpbmcgZm9yIGNvbW1hbmQgS0VZIGluIGN1cnJlbnQga2V5 bWFwcy4KIEtFWSBpcyBhIHN0cmluZyBvciB2ZWN0b3IsIGEgc2VxdWVuY2Ugb2Yga2V5c3Ryb2tl cy4KIFRoZSBiaW5kaW5nIGlzIHByb2JhYmx5IGEgc3ltYm9sIHdpdGggYSBmdW5jdGlvbiBkZWZp bml0aW9uLgpAQCAtMTYzNSw4ICsxNjM1LDEyIEBAIHBvc2l0aW9uIGFzIHJldHVybmVkIGJ5IGBl dmVudC1zdGFydCcgYW5kIGBldmVudC1lbmQnLCBhbmQgdGhlIGxvb2t1cAogb2NjdXJzIGluIHRo ZSBrZXltYXBzIGFzc29jaWF0ZWQgd2l0aCBpdCBpbnN0ZWFkIG9mIEtFWS4gIEl0IGNhbiBhbHNv CiBiZSBhIG51bWJlciBvciBtYXJrZXIsIGluIHdoaWNoIGNhc2UgdGhlIGtleW1hcCBwcm9wZXJ0 aWVzIGF0IHRoZQogc3BlY2lmaWVkIGJ1ZmZlciBwb3NpdGlvbiBpbnN0ZWFkIG9mIHBvaW50IGFy ZSB1c2VkLgorCitBIG5vbi1uaWwgdmFsdWUgZm9yIE1FTlVTIG1ha2VzIGBrZXktYmluZGluZ2Ag cmV0dXJuIGZ1bGwgbWVudS1pdGVtcworaW5zdGVhZCBvZiBqdXN0IHRoZSBhc3NvY2lhdGVkIGRl ZmluaXRpb24uCiAgICovKQotICAoTGlzcF9PYmplY3Qga2V5LCBMaXNwX09iamVjdCBhY2NlcHRf ZGVmYXVsdCwgTGlzcF9PYmplY3Qgbm9fcmVtYXAsIExpc3BfT2JqZWN0IHBvc2l0aW9uKQorICAg ICAoTGlzcF9PYmplY3Qga2V5LCBMaXNwX09iamVjdCBhY2NlcHRfZGVmYXVsdCwgTGlzcF9PYmpl Y3Qgbm9fcmVtYXAsCisgICAgICBMaXNwX09iamVjdCBwb3NpdGlvbiwgTGlzcF9PYmplY3QgbWVu dXMpCiB7CiAgIExpc3BfT2JqZWN0IHZhbHVlOwogCkBAIC0xNjYyLDcgKzE2NjYsNyBAQCBzcGVj aWZpZWQgYnVmZmVyIHBvc2l0aW9uIGluc3RlYWQgb2YgcG9pbnQgYXJlIHVzZWQuCiAgICAgfQog CiAgIHZhbHVlID0gRmxvb2t1cF9rZXkgKEZjb25zIChRa2V5bWFwLCBGY3VycmVudF9hY3RpdmVf bWFwcyAoUXQsIHBvc2l0aW9uKSksCi0JCSAgICAgICBrZXksIGFjY2VwdF9kZWZhdWx0LCBRbmls KTsKKwkJICAgICAgIGtleSwgYWNjZXB0X2RlZmF1bHQsIG1lbnVzKTsKIAogICBpZiAoTklMUCAo dmFsdWUpIHx8IElOVEVHRVJQICh2YWx1ZSkpCiAgICAgcmV0dXJuIFFuaWw7Ci0tIAoyLjE1LjEK Cg== --94eb2c0da4821c5817056056f6a7--