From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Justin Burkett Newsgroups: gmane.emacs.bugs Subject: bug#71648: 30.0.50; Allow which-key to report on translation bindings Date: Wed, 19 Jun 2024 11:09:36 -0400 Message-ID: References: <87plsdxhnw.fsf@gmail.com> <867celoz4q.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5444"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71648@debbugs.gnu.org, Robert Pluim , Jeremy Bryant To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 19 17:11:19 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sJwxz-00018A-ME for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 Jun 2024 17:11:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJwxi-00015I-2L; Wed, 19 Jun 2024 11:11:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJwxf-00013N-T5 for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2024 11:10:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sJwxf-0002fC-DD for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2024 11:10:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sJwxi-0004Bm-5U for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2024 11:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Justin Burkett Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Jun 2024 15:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71648 X-GNU-PR-Package: emacs Original-Received: via spool by 71648-submit@debbugs.gnu.org id=B71648.171880985916090 (code B ref 71648); Wed, 19 Jun 2024 15:11:02 +0000 Original-Received: (at 71648) by debbugs.gnu.org; 19 Jun 2024 15:10:59 +0000 Original-Received: from localhost ([127.0.0.1]:47839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJwxf-0004BQ-AB for submit@debbugs.gnu.org; Wed, 19 Jun 2024 11:10:59 -0400 Original-Received: from mail-ed1-f48.google.com ([209.85.208.48]:45167) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJwxd-0004BA-2S for 71648@debbugs.gnu.org; Wed, 19 Jun 2024 11:10:58 -0400 Original-Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-57d1679ee83so542548a12.2 for <71648@debbugs.gnu.org>; Wed, 19 Jun 2024 08:10:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=burkett-cc.20230601.gappssmtp.com; s=20230601; t=1718809788; x=1719414588; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=wZ0JgyXRHOcDXxNj5W9lTT/1vYnbR0zPQsQxp1xdJ3Q=; b=wipohiP1yITPgews9HP6va/UE40MY+dE6EIUdshAHUaKLQzcoC2HN3kHry+IJdcoRV J2UPfRUfAhNW+UneNh8M38kHr1V6c0NvQDGA2G8XHspNkQFIBSlt+OoBeik1wkg+hOxs qPztDizQBzV9WiZ0hl3IBJT0p+c+jou7cV769OTF35WKta/R9qLainFir1h1amFgOnK8 tEWZp8dNsrq2dKFPao8JohXelMce0fVbg7xn9UcumhrD7NNaq5NST3HWTOj+hxKz/WhY 7SLnKOr+W/ccHocNL4FfSfHiq8vcs7QQUELWdycYRdZFY0LXLPeR5PbLtHVwfUwZhE9Z T60w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718809788; x=1719414588; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wZ0JgyXRHOcDXxNj5W9lTT/1vYnbR0zPQsQxp1xdJ3Q=; b=ExtOBLFWMuw+bqkJd9QMgJQJir4Q2Q/5HPSROTlnujcjEgfWeWMqBdqd8FfZ+4bm9+ hf703L2ODcoAbVpjR0ldO4irzowv+UV35V4k5WuxjfKV1MFvOAWMGiwn2RE7/QFzxBCy TUacn+PvYQdeQWkjRy1TWoGVaDejQDjD+0Hw1vycrrer+/3S4tgES+ftGSkUFr4WGMCR LIFi+/hWqDTL7n/GVpL8pVyJ/kw8Ht9IDPZhQHgmYEBJt/HqzbRA5ip7U3MNiCmvtr/6 toruyo3uuuHGJUNpjQ++u95fD6bYuha+2hRoPe5POfYw//W+NRhSvEbhcGnEFDfHR6D6 cvlw== X-Forwarded-Encrypted: i=1; AJvYcCWLL1jDO8S7Agqr/I+8eJMzGPKKNALg2wEKFCNP6Oz3imiNqfJuBr8PqQRrhVnT2+dqGINR3P6N4BPc1GnQQrzhmbekQX4= X-Gm-Message-State: AOJu0YwdX0K2o6QzlDASqysvBWwKKdMYJMmKSOYvLd6+GAHuW5kbWwPn mdxPO6sGDe+xf7HYFAs+wcCvY46y5nI80HbcvFVIlbnh75UfFOjvp3K2PdJy6j2jPz65Gy80x1a fsmRccijYKi3IrkjqaKdGk9ymu5UPameVWFc3mQ== X-Google-Smtp-Source: AGHT+IH/fzxqVUe6wtIeS1epT53e6tAdjx1CT7TRTdys3U8E7K22r0iSLvW6LfaOCqgv32BLAmND8I2jDnX3+eBq8o8= X-Received: by 2002:a50:c089:0:b0:57c:6868:2aea with SMTP id 4fb4d7f45d1cf-57d07e86b3dmr1615030a12.23.1718809787833; Wed, 19 Jun 2024 08:09:47 -0700 (PDT) In-Reply-To: <867celoz4q.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287485 Archived-At: The purpose of which-key was to show the commands that are available following an incomplete key sequence. If I understand correctly, these maps don't hold commands and anyway would be processed before which-key "sees" the current incomplete key sequence. If I understand correctly, if "C-d x" translates to "C-c x" then which-key I believe would see the sequence "C-c x" and find the bindings following that sequence. I'm not sure how or why we would want to display the information that "C-d x" translates to "C-c x". Justin On Wed, Jun 19, 2024 at 9:12=E2=80=AFAM Eli Zaretskii wrote: > > > From: Robert Pluim > > Date: Wed, 19 Jun 2024 14:04:35 +0200 > > > > `which-key-mode' currently only looks at keymaps, not translation > > keymaps such as `key-translation-map' and `function-key-map'. In order > > to aid discoverability, perhaps it should do the following > > > > (maybe with a user option) > > > > @@ -1942,8 +1949,10 @@ which-key--get-keymap-bindings > > > > (defun which-key--get-current-bindings (&optional prefix filter) > > "Generate a list of current active bindings." > > - (let (bindings) > > - (dolist (map (current-active-maps t) bindings) > > + (let (bindings > > + (maps (nconc (current-active-maps t) > > + (list key-translation-map function-key-map)))) > > + (dolist (map maps bindings) > > (when (cdr map) > > (setq bindings > > (which-key--get-keymap-bindings > > > > Let's have the relevant people on-board of this discussion.