Re: URGENT - which-key FSF contributor status

[Justin Burkett <justin@burkett.cc>]

On Sat, Jun 15, 2024 at 1:09 PM Philip Kaludercic <philipk@posteo.net> wrote:
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: Philip Kaludercic <philipk@posteo.net>
> >> Cc: jb@jeremybryant.net,  justin@burkett.cc,  emacs-devel@gnu.org
> >> Date: Sat, 15 Jun 2024 12:58:00 +0000
> >>
> >> Eli Zaretskii <eliz@gnu.org> writes:
> >>
> >> >> From: Philip Kaludercic <philipk@posteo.net>
> >> >> Cc: Eli Zaretskii <eliz@gnu.org>,  Justin Burkett <justin@burkett.cc>,
> >> >>  emacs-devel@gnu.org
> >> >> Date: Sat, 15 Jun 2024 09:05:52 +0000
> >> >>
> >> >> We have found out that Bar has completed the CA.  That means we can
> >> >> proceed with adding which-key, perhaps even by Emacs 30 (Eli?)?
> >> >
> >> > Yes.  If you do this _very_ quickly.
> >>
> >> I have pushed a working branch under "feature/which-key-in-core".
> >> Please take a look to see if I missed something obvious, and if it seems
> >> fine I can merge it into master right away.
> >
> > Thanks.  A couple of comments:
> >
> > The :version tags of the defcustoms and deffaces will need to change.
>
> I can change the current tags to :package-version and also add :version
> "30.1" tags.
>
> > Some faces use attributes such as underline or bold without testing
> > for their availability first and without offering any fallbacks if
> > they aren't.  Is it okay to have those displayed using the default
> > face?
>
> My guess is that this is just decoration, but someone who actually uses
> which-key should comment on that.  Specifically it appears to involve
> the
>
> - which-key-special-key-face
> - which-key-highlighted-command-face
>
> faces.

That's right. These faces are there to optionally highlight some of
the bindings. If a font does not support underlining or bold face, I'm
guessing these faces would just ignore that property. Is that right?
If so, these faces will just fall back to the unhighlighted version.

I'm wondering if there is a recommended way to handle the circumstance
where you want to highlight an entry with say bold face and have a
fallback in place in case bold is not available. I suppose we could
just pick a different fallback color.

Justin

>
> --
>         Philip Kaludercic on peregrine