From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Justin Burkett Newsgroups: gmane.emacs.devel Subject: Re: Patch for fit-window-to-buffer Date: Wed, 4 Mar 2020 15:49:50 -0500 Message-ID: References: <1ff48e60-d78a-6e44-28e0-3aff795984b9@gmx.at> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="00000000000056956f05a00d91e4" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="16118"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 04 22:15:59 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j9bN1-00043E-52 for ged-emacs-devel@m.gmane-mx.org; Wed, 04 Mar 2020 22:15:59 +0100 Original-Received: from localhost ([::1]:39834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9bN0-0007Dg-4V for ged-emacs-devel@m.gmane-mx.org; Wed, 04 Mar 2020 16:15:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59978) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9ayD-0004ey-JX for emacs-devel@gnu.org; Wed, 04 Mar 2020 15:50:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j9ayC-0002Cf-IU for emacs-devel@gnu.org; Wed, 04 Mar 2020 15:50:21 -0500 Original-Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]:37339) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j9ayB-0002AH-Sh for emacs-devel@gnu.org; Wed, 04 Mar 2020 15:50:20 -0500 Original-Received: by mail-ed1-x52d.google.com with SMTP id t7so3966401edr.4 for ; Wed, 04 Mar 2020 12:50:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=burkett-cc.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QQ6eTBcwYt1MYloiMsADWqvylkoQqvF10aV1V0vb3Xs=; b=xrAnG1x7up2woF87iaTrYEYz2GMttIqqefJdJdrZ+CvpwENF8qwLZ3r3u3MVnRE9Hz k+wzStvMLHaPJOg/WImNy6kC9IemMfpEO/pVfnqN0tgJx/lPuqy/qT0QFduUaolzVYja xRXvFGUDb2ooTqbTrMhjpwgzrNnxkTbhrluzSvGfK/s8MvtvWKoAmGH11jro/1g5JYfX TSQseNb9S/68/3Lv1X+IXEIdaffLrV1z4hm/Uo5B4wIiiEOa9DzHVjHPLRze+KMWWPMj swGCfJDIxbbQU2OWFdn3RmuSL5wjw7xckJ/497UyW+OIUvDIFlhVYDbc275AZyIhIYco 3+yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QQ6eTBcwYt1MYloiMsADWqvylkoQqvF10aV1V0vb3Xs=; b=sworX8K6hUproT1rWYWlmzCEfXDeWOEOpX3FJEkJPoSD2ytYFeg+EAKsebBF3b2rH2 9w4w4JFb21evwV3oHSTebun9lwJIRJZYrszHPUL8BT5ykYqytWdrdAgoKwsI0qlI2OhQ DD0oXRJ+lK/Ri4jTwbakbPQMZEcWRJdFNhVUF8HujXzUTl+mzBypPD5FlbsdPONoUv9w e2DU6HyTFQOYkfLxjWEaJ2tV01FaD4Zvj+d7x/hAOHgaISbStltNzN1CzxdVAdLbQxzJ V2S8U2gNMbDE1hyEsqaoLmw8f3uxei4HX4EZt2kwAZLJTbVx3n2/av0G1xXemue26ZWr O7Bw== X-Gm-Message-State: ANhLgQ0pazCYdr0VetiDWxQa0FfjCmrBwv7kgTKWIYxskxKKGOHNJHQf uwH16LmKeqTGA3/pQc1Kw/DmI3LpNl8= X-Google-Smtp-Source: ADFU+vvUuxVvD0pw0IFFfeC8qKB5HD5YCP5Qm5frYEclc7mxzECMdjTDegn2HJ2zzg5MsRQ4F0cqTg== X-Received: by 2002:a50:c94d:: with SMTP id p13mr4818108edh.78.1583355018290; Wed, 04 Mar 2020 12:50:18 -0800 (PST) Original-Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com. [209.85.128.45]) by smtp.gmail.com with ESMTPSA id u13sm1198301ejt.1.2020.03.04.12.50.17 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Mar 2020 12:50:17 -0800 (PST) Original-Received: by mail-wm1-f45.google.com with SMTP id g134so3747344wme.3 for ; Wed, 04 Mar 2020 12:50:17 -0800 (PST) X-Received: by 2002:a05:600c:224e:: with SMTP id a14mr5144716wmm.58.1583355016926; Wed, 04 Mar 2020 12:50:16 -0800 (PST) In-Reply-To: <1ff48e60-d78a-6e44-28e0-3aff795984b9@gmx.at> X-Gmail-Original-Message-ID: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::52d X-Mailman-Approved-At: Wed, 04 Mar 2020 16:15:21 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:245241 Archived-At: --00000000000056956f05a00d91e4 Content-Type: multipart/alternative; boundary="00000000000056956905a00d91e2" --00000000000056956905a00d91e2 Content-Type: text/plain; charset="UTF-8" > The 'point-max' fix could be improved: Since 'window-text-pixel-size' > has to make the buffer shown in WINDOW current before processing its > text anyway, it would IMO be more efficient to wrap the entire > 'window-text-pixel-size' call into a > > (with-current-buffer (window-buffer window) > > form and thus avoid selecting WINDOW while providing the right buffer > for 'window-text-pixel-size' right away. Can you try that? > I think the (point-max) is unnecessary here actually. According to the docstring for window-text-pixel-size, nil should work here, no? > Finally, the (frame-pixel-width) argument looks fishy too - it should > probably be (frame-pixel-width (window-frame window)). Can you verify > that as well? Yes, I made that change and the previous one in the patch attached. Both work with my test case. Thanks, Justin --00000000000056956905a00d91e2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

> The 'point-max' fix could be improved: Si= nce 'window-text-pixel-size'
> has to make the buffer shown i= n WINDOW current before processing its
> text anyway, it would IMO be= more efficient to wrap the entire
> 'window-text-pixel-size'= call into a
>
> (with-current-buffer (window-buffer window)>
> form and thus avoid selecting WINDOW while providing the righ= t buffer
> for 'window-text-pixel-size' right away.=C2=A0 Can= you try that?
>

I think the (point-max) is unnecessary here a= ctually. According to the docstring for window-text-pixel-size, nil should = work here, no?

> Finally, the (frame-pixel-width) argument looks= fishy too - it should
> probably be (frame-pixel-width (window-frame= window)).=C2=A0 Can you verify
> that as well?

Yes, I made th= at change and the previous one in the patch attached. Both work with my tes= t case.=C2=A0

Thanks,
Justin
--00000000000056956905a00d91e2-- --00000000000056956f05a00d91e4 Content-Type: application/octet-stream; name="0001-lisp-window.el-fit-window-to-buffer-Don-t-use-wrong-.patch" Content-Disposition: attachment; filename="0001-lisp-window.el-fit-window-to-buffer-Don-t-use-wrong-.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k7dsmro10 RnJvbSA2MDRiZGU2YWFlOTM5MzRmOGU2N2QwY2RhNzBmMGU0MDA0YjUwY2M4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKdXN0aW4gQnVya2V0dCA8anVzdGluQGJ1cmtldHQuY2M+CkRh dGU6IFR1ZSwgMyBNYXIgMjAyMCAyMjowMToyOSAtMDUwMApTdWJqZWN0OiBbUEFUQ0hdICogbGlz cC93aW5kb3cuZWwgKGZpdC13aW5kb3ctdG8tYnVmZmVyKTogRG9uJ3QgdXNlIHdyb25nCiB3aW5k b3cgZGF0YQoKLS0tCiBsaXNwL3dpbmRvdy5lbCB8IDQgKystLQogMSBmaWxlIGNoYW5nZWQsIDIg aW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL3dpbmRvdy5l bCBiL2xpc3Avd2luZG93LmVsCmluZGV4IGJkODI1YzA5ZTEuLjAzOWIxMzM3NDQgMTAwNjQ0Ci0t LSBhL2xpc3Avd2luZG93LmVsCisrKyBiL2xpc3Avd2luZG93LmVsCkBAIC05MTI0LDggKzkxMjQs OCBAQCBmaXQtd2luZG93LXRvLWJ1ZmZlcgogCSAgICAgICA7OyB3aWRlciB0aGFuIGl0cyBmcmFt ZSdzIHBpeGVsIHdpZHRoLCBpdHMgaGVpZ2h0CiAJICAgICAgIDs7IHJlbWFpbnMgdW5hbHRlcmVk LgogCSAgICAgICAod2lkdGggKCsgKGNhciAod2luZG93LXRleHQtcGl4ZWwtc2l6ZQotCQkJICAg ICAgIHdpbmRvdyAod2luZG93LXN0YXJ0KSAocG9pbnQtbWF4KQotCQkJICAgICAgIChmcmFtZS1w aXhlbC13aWR0aCkKKwkJCSAgICAgICB3aW5kb3cgKHdpbmRvdy1zdGFydCB3aW5kb3cpIG5pbAor CQkJICAgICAgIChmcmFtZS1waXhlbC13aWR0aCAod2luZG93LWZyYW1lIHdpbmRvdykpCiAJCQkg ICAgICAgOzsgQWRkIG9uZSBsaW5lLWhlaWdodCB0byBhc3N1cmUgdGhhdAogCQkJICAgICAgIDs7 IHdlJ3JlIG9uIHRoZSBzYWZlIHNpZGUuICBUaGlzCiAJCQkgICAgICAgOzsgb3ZlcnNob290cyB3 aGVuIHRoZSBmaXJzdCBsaW5lIGJlbG93Ci0tIAoyLjIxLjEgKEFwcGxlIEdpdC0xMjIuMykKCg== --00000000000056956f05a00d91e4--