From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Justin Burkett Newsgroups: gmane.emacs.devel Subject: Re: Patch for beginning-of-visual-line and end-of-visual-line Date: Sat, 12 Aug 2017 09:14:47 -0400 Message-ID: References: <83inhuq74r.fsf@gnu.org> <83fucxqonl.fsf@gnu.org> <83wp69htl2.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="089e0822a7d48b4be505568e38d8" X-Trace: blaine.gmane.org 1502543739 12407 195.159.176.226 (12 Aug 2017 13:15:39 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 12 Aug 2017 13:15:39 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Aug 12 15:15:32 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dgWGC-0002NK-BJ for ged-emacs-devel@m.gmane.org; Sat, 12 Aug 2017 15:15:24 +0200 Original-Received: from localhost ([::1]:52673 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dgWGI-0000u1-Js for ged-emacs-devel@m.gmane.org; Sat, 12 Aug 2017 09:15:30 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60728) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dgWGB-0000t7-Bk for emacs-devel@gnu.org; Sat, 12 Aug 2017 09:15:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dgWG8-0002y8-8D for emacs-devel@gnu.org; Sat, 12 Aug 2017 09:15:23 -0400 Original-Received: from mail-qt0-x22c.google.com ([2607:f8b0:400d:c0d::22c]:37098) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dgWG7-0002vz-W7 for emacs-devel@gnu.org; Sat, 12 Aug 2017 09:15:20 -0400 Original-Received: by mail-qt0-x22c.google.com with SMTP id 16so33658927qtz.4 for ; Sat, 12 Aug 2017 06:15:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=burkett-cc.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=aTExMgT3tP1gYNmisDcF5aQRpMakAP4aNy/DC35p/5M=; b=daSxVjE7ifcpcDLq/t/Vpx1HHa++16fDZUSNrONAuIZG5YOtqsgFkmLnU4MyEBqS8d A5ztfZUgRQPkEJmgL3Uaoj1v2gXHNF57wQe8Fkfh0LpRXJXm7ypYFCHUzxfqyB4XV0lY NuHCmCxhNn/lGA/13u7gyzC5Nn29S2JiAMZ7W88AqTck+3kSt+MM3ij5zWuo1L+3or5E Ye5MCIMvPeX9Nlqs7e1CCdAhOgsFQx8I4Bvx8GtZ0iAEw3tsM5oJ53ee21kYhKJBn4nH tZCrUUMb5rDy2mZkPSwOPAZ9vRpheW/bDh867UH0rym9l1ERW8Z1BwIhLDVnRssAwPMK JaQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=aTExMgT3tP1gYNmisDcF5aQRpMakAP4aNy/DC35p/5M=; b=JAGj1byet67bKiVYKDq6kHcCQOr5g+3Lm7aPxdW+S2tmiyl1HB216gyYTdUTeca6fl GNNcCbaimHn6QtE4gC40Wr8llNTJ+dcUhjX1mxSzVlff94JY1maPofMxqTJVVz23SeiW HpvzTzowDW+dRrqJ6Zy+519mvlOyw+iH5kOZt60wtfMp+aG3wXMtb4/QSqRhV1tDDhIQ Fvq5aqOq02Aw1Nh/gYsGNh5ChBqpi11hTKNGpGyqS4uLCSdr2UW6h8fu4gJhURDLAIDY acKlSbxTmYw9r0dUcFJ25azlAKfR97nmhlHuTxfiAoZEctdG36sLLbjNu0h/Hqc441iu ED1g== X-Gm-Message-State: AHYfb5jTHboZwDeKRhirNRz76K8CEASJeMdq6D4AriuTXBVUboNeB5DA Ge3b6W1TrYDikl8h X-Received: by 10.237.53.83 with SMTP id b19mr24214439qte.312.1502543719323; Sat, 12 Aug 2017 06:15:19 -0700 (PDT) Original-Received: from mail-qt0-f182.google.com (mail-qt0-f182.google.com. [209.85.216.182]) by smtp.gmail.com with ESMTPSA id v38sm2214427qtg.68.2017.08.12.06.15.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 12 Aug 2017 06:15:18 -0700 (PDT) Original-Received: by mail-qt0-f182.google.com with SMTP id p3so33679793qtg.2; Sat, 12 Aug 2017 06:15:17 -0700 (PDT) X-Received: by 10.200.11.134 with SMTP id h6mr25677853qti.236.1502543717548; Sat, 12 Aug 2017 06:15:17 -0700 (PDT) Original-Received: by 10.140.30.139 with HTTP; Sat, 12 Aug 2017 06:14:47 -0700 (PDT) In-Reply-To: <83wp69htl2.fsf@gnu.org> X-Gmail-Original-Message-ID: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::22c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217481 Archived-At: --089e0822a7d48b4be505568e38d8 Content-Type: text/plain; charset="UTF-8" > The return value is unspecified, and I don't think I see why we should specify it. No problem. Thanks again On Sat, Aug 12, 2017 at 8:13 AM, Eli Zaretskii wrote: > > From: Justin Burkett > > Date: Sat, 12 Aug 2017 07:54:16 -0400 > > Cc: emacs-devel@gnu.org > > > > So I think this behavior is correct, perhaps we should describe this > > special case in the doc string. This function must end up at the > > beginning of a visual line, and in your case there's only one such > > place. Note that (beginning-of-visual-line 1) and > > (beginning-of-visual-line) all end up in the same place in this case. > > > > That's fine with me. While we're at it, move-beginning-of-line has the > same inconsistency in the docstring. > > I've fixed the doc strings of both these functions, thanks. > > > Also, it would be nice to specify what the return value of these > functions is if the docstring will change. > > The return value is unspecified, and I don't think I see why we should > specify it. > --089e0822a7d48b4be505568e38d8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
>=C2=A0The return valu= e is unspecified, and I don't think I see why we should
specify it.
No problem. Thanks again

On Sat, Aug 12, 2017 at 8:13 AM, = Eli Zaretskii <eliz@gnu.org> wrote:
> From: Justin Burkett <justin@burkett.cc>
> Date: Sat, 12 Aug 2017 07:54:16 -0400
> Cc: emacs-devel@gnu.org
>
>=C2=A0 So I think this behavior is correct, perhaps we should describe = this
>=C2=A0 special case in the doc string. This function must end up at the=
>=C2=A0 beginning of a visual line, and in your case there's only on= e such
>=C2=A0 place. Note that (beginning-of-visual-line 1) and
>=C2=A0 (beginning-of-visual-line) all end up in the same place in this = case.
>
> That's fine with me. While we're at it, move-beginning-of-line= has the same inconsistency in the docstring.

I've fixed the doc strings of both these functions, thanks.

> Also, it would be nice to specify what the return value of these funct= ions is if the docstring will change.

The return value is unspecified, and I don't think I see why we = should
specify it.

--089e0822a7d48b4be505568e38d8--