From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Justin Burkett Newsgroups: gmane.emacs.devel Subject: Re: Include which-key.el in the Emacs distribution Date: Tue, 8 Sep 2020 14:11:07 -0400 Message-ID: References: <83sgbskwq8.fsf@gnu.org> <87pn6wi2zs.fsf@gnu.org> <83mu20kusi.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000000153fb05aed14477" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34221"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Kangas , "Alfred M. Szmidt" , Amin Bandali , emacs-devel To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 08 20:12:27 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFi6V-0008k3-13 for ged-emacs-devel@m.gmane-mx.org; Tue, 08 Sep 2020 20:12:27 +0200 Original-Received: from localhost ([::1]:33286 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFi6U-0006xi-40 for ged-emacs-devel@m.gmane-mx.org; Tue, 08 Sep 2020 14:12:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46444) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFi5r-0006EZ-I7 for emacs-devel@gnu.org; Tue, 08 Sep 2020 14:11:47 -0400 Original-Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]:40988) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kFi5n-0006EQ-Mr for emacs-devel@gnu.org; Tue, 08 Sep 2020 14:11:47 -0400 Original-Received: by mail-ed1-x52d.google.com with SMTP id ay8so16972880edb.8 for ; Tue, 08 Sep 2020 11:11:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=burkett-cc.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=t0jxm7+ooTg9GaLldh0hEGqh2vPD8hW6U+HQubuNmG4=; b=vKPMqlfh58juyqf+rzBk/w9/y7BGJdb2NPTLoOKt+YYw/Tjhka766Jl4jYdcaxyYfD g8I00vlflQRIgIIwczp2XN0EQPgTkW3L+kG/Yxuspb090oUppJ8iY4vn+hTXLIwrIais eapVXPQT54LFThaP5LXZHC4h0yJZqvisCUbxpXgOhjw+kSQIQAFvdPbqyL6FwUk/buXT Hkh9qX7OdB5CVUszHlQvn0G4xf5BrqcPfcqKUdBp8OiR1/fLI2GPZTRdqEkNLWjJhD7p cz4+5LhKC110AUvYqdHhUwLSRxxZzkyiV6NXheDY1DwcMYOj5u/ZhuRrlzAh8FZSNWLN U2EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=t0jxm7+ooTg9GaLldh0hEGqh2vPD8hW6U+HQubuNmG4=; b=TYdDeFgS9paiMNBqKVp7JVNc3gC2N2xpuqJ8qOi5md7O6pvnV8Tv+7+E9ig8Ck6vSu hlEo4x/cbAfTjD490jPXOCNNd+iGr2RvSiCl5PHXG5tovncmy1VVLIpDakAFRUYdjgck llEg34zmzUKXEwjSRyy056Df/swKMJqHmWmD6RHREKQ/jjRK+WJRDDH2hRndbRiFIJIv E8PySlLN2d6wJxb4xQImI0ppFT+sFiOGLw8Z+E0cVL+vS6JVoGYibsH1C0rqqEJcYDPM IPAhUagFTZ420ED5a3fYT2DIarBRRnToFJFvn3he8vO1QnpXV/uSjLXV8WyfTxC5pksY BYQQ== X-Gm-Message-State: AOAM533LapEsyaZAKrVrTnfh7SY6urIONG0IsppXvg1RDao9iIU53fPV EkAmFr1tT4I46GLRUyniqEieQZh4OLeaelP01DU= X-Google-Smtp-Source: ABdhPJz7vAIpeOPfmxqhqwxOWFdkn8Mfdj6eoDlWBny3yR2/LFV8tmEFu04iItpqZkto3wIw9v6CsQ== X-Received: by 2002:a50:9b5e:: with SMTP id a30mr196176edj.49.1599588702424; Tue, 08 Sep 2020 11:11:42 -0700 (PDT) Original-Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com. [209.85.128.47]) by smtp.gmail.com with ESMTPSA id q11sm123192eds.16.2020.09.08.11.11.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Sep 2020 11:11:41 -0700 (PDT) Original-Received: by mail-wm1-f47.google.com with SMTP id e11so169047wme.0; Tue, 08 Sep 2020 11:11:41 -0700 (PDT) X-Received: by 2002:a05:600c:22d1:: with SMTP id 17mr357959wmg.58.1599588695880; Tue, 08 Sep 2020 11:11:35 -0700 (PDT) In-Reply-To: <83mu20kusi.fsf@gnu.org> X-Gmail-Original-Message-ID: Received-SPF: none client-ip=2a00:1450:4864:20::52d; envelope-from=justin@burkett.cc; helo=mail-ed1-x52d.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:254792 Archived-At: --0000000000000153fb05aed14477 Content-Type: text/plain; charset="UTF-8" > I don't see the relevance, sorry. When I type "C-h" with > which-key-mode on, I see a paging hint at the bottom line, and that > hint simply doesn't work (and nothing else I tried does). By > contrast, the vanilla "C-h" doesn't say anything about > describe-prefix-bindings, so the problem will rarely if ever happen. > Ah, if it's just about the hint, then yes, that should be hidden in that case. IMO, this UI needs to be improved, certainly if we want to turn this > mode on by default. For starters, how about using the usual Emacs > scrolling keys for showing the next/previous page? > I wasn't advocating for it to be on by default, but yes, the UI could probably be improved. It's a difficult problem (at least for me), because I wanted which-key to be passive and not interfere with how emacs processes key sequences. That's why I used the help-char escape mechanism to do the paging. As far as the default keys, that's an easy change of course. On Tue, Sep 8, 2020 at 2:06 PM Eli Zaretskii wrote: > > From: Justin Burkett > > Date: Tue, 8 Sep 2020 13:54:08 -0400 > > Cc: Amin Bandali , Eli Zaretskii , > Stefan Kangas , > > emacs-devel > > > > I.e., you cannot paginate through the commands if you are issuing C-h > > and have which-key-mode on. > > > > You also can't invoke describe-prefix-bindings from C-h in vanilla > > emacs. > > I don't see the relevance, sorry. When I type "C-h" with > which-key-mode on, I see a paging hint at the bottom line, and that > hint simply doesn't work (and nothing else I tried does). By > contrast, the vanilla "C-h" doesn't say anything about > describe-prefix-bindings, so the problem will rarely if ever happen. > > IMO, this UI needs to be improved, certainly if we want to turn this > mode on by default. For starters, how about using the usual Emacs > scrolling keys for showing the next/previous page? > --0000000000000153fb05aed14477 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

I don't see the relevance, sorry.=C2=A0 When I type "C-h" wit= h
which-key-mode on, I see a paging hint at the bottom line, and that
hint simply doesn't work (and nothing else I tried does).=C2=A0 By
contrast, the vanilla "C-h" doesn't say anything about
describe-prefix-bindings, so the problem will rarely if ever happen.
<= /blockquote>

Ah, if it's just about the hint, then y= es, that should be hidden in that case.

IMO, this UI needs to be impro= ved, certainly if we want to turn this
mode on by default.=C2=A0 For starters, how about using the usual Emacs
scrolling keys for showing the next/previous page?
<= br>
I wasn't advocating for it to be on by default, but yes, = the UI could probably be improved. It's a difficult problem (at least f= or me), because I wanted which-key to be passive and not interfere with how= emacs processes key sequences. That's why I used the help-char escape = mechanism to do the paging. As far as the default keys, that's an easy = change of course.

On Tue, Sep 8, 2020 at 2:06 PM Eli Zaretskii = <eliz@gnu.org> wrote:
> From: Justin Burkett &= lt;justin@burkett.cc>
> Date: Tue, 8 Sep 2020 13:54:08 -0400
> Cc: Amin Bandali <bandali@gnu.org>, Eli Zaretskii <eliz@gnu.org>, Stefan Kangas <stefan@marxist.se>,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0emacs-devel <emacs-devel@gnu.org>
>
>=C2=A0 I.e., you cannot paginate through the commands if you are issuin= g C-h
>=C2=A0 and have which-key-mode on.
>
> You also can't invoke describe-prefix-bindings from C-h in vanilla=
> emacs.

I don't see the relevance, sorry.=C2=A0 When I type "C-h" wit= h
which-key-mode on, I see a paging hint at the bottom line, and that
hint simply doesn't work (and nothing else I tried does).=C2=A0 By
contrast, the vanilla "C-h" doesn't say anything about
describe-prefix-bindings, so the problem will rarely if ever happen.

IMO, this UI needs to be improved, certainly if we want to turn this
mode on by default.=C2=A0 For starters, how about using the usual Emacs
scrolling keys for showing the next/previous page?
--0000000000000153fb05aed14477--