From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Filipe Silva Newsgroups: gmane.emacs.devel Subject: Re: Native line numbers, final testing Date: Tue, 11 Jul 2017 18:20:04 -0300 Message-ID: References: <83y3s9pm2a.fsf@gnu.org> <87r2y1z45o.fsf@lylat> <83vandp7wz.fsf@gnu.org> <87mv8pyy7f.fsf@lylat> <83shigpoxq.fsf@gnu.org> <87mv8nkh31.fsf@lylat> <83bmp3pnmb.fsf@gnu.org> <87eftzju5g.fsf@lylat> <837ezqq3gd.fsf@gnu.org> <874luuyuqy.fsf@lylat> <83wp7po86m.fsf@gnu.org> <87fuecc7vg.fsf@lylat> <83y3s2n5pa.fsf@gnu.org> <878tk1rmjx.fsf@lylat> <83a84gn4z9.fsf@gnu.org> <837ezkmwfg.fsf@gnu.org> <874lumps82.fsf@lylat> <8337a5ja4p.fsf@gnu.org> <83van0i5wl.fsf@gnu.org> <87iniy7ksy.fsf@lylat> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a11c17dc26f57b00554114397" X-Trace: blaine.gmane.org 1499808082 12419 195.159.176.226 (11 Jul 2017 21:21:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 11 Jul 2017 21:21:22 +0000 (UTC) Cc: Eli Zaretskii , James Cloos , Emacs developers To: Alex Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 11 23:21:15 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dV2an-0002o2-MD for ged-emacs-devel@m.gmane.org; Tue, 11 Jul 2017 23:21:13 +0200 Original-Received: from localhost ([::1]:48982 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dV2at-0007OR-24 for ged-emacs-devel@m.gmane.org; Tue, 11 Jul 2017 17:21:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49476) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dV2ak-0007LR-HP for emacs-devel@gnu.org; Tue, 11 Jul 2017 17:21:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dV2ah-0004xs-Cf for emacs-devel@gnu.org; Tue, 11 Jul 2017 17:21:10 -0400 Original-Received: from mail-oi0-f52.google.com ([209.85.218.52]:33962) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dV2ah-0004xO-5n; Tue, 11 Jul 2017 17:21:07 -0400 Original-Received: by mail-oi0-f52.google.com with SMTP id l130so4176177oib.1; Tue, 11 Jul 2017 14:21:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=TH6PGvLOArNHakinR+VYbUbmbu9bNV9lK28lUBxVmHQ=; b=l6/EXM+aTPemm42qLhjoAOz/RcNFsr6ol2gFEbNn2gMdVHuRs2hmi2OCKg3NqDQUKA n+BrZ0ZNey9wUBQ1npduc1zXEGNpMjOBTUbnPuyW2Fk7BYAvNA91hzpPgliUMpndpcz7 97o/SVjyO9w6EhWgc6BJmZVjEmHd9wIih3y2W1/bUNcXYyoOtqA58IYcfCWz6kGBSams Ja8RtSew9cjZYSjBwPBp0gVuzJiW+SC1sLORC/heTenU/rMlxqzN44AeqxDAIiIaPIhe 8VzugTB9y4yXweaCb0rTZEOMFs9AuxfrRvwulG/cO2B0jUMIvKGQQEJq3p9juMzg0jSG cYlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=TH6PGvLOArNHakinR+VYbUbmbu9bNV9lK28lUBxVmHQ=; b=Z9m99XxsA88FUu+FKJSr1RZK6SdtuGFeHSyXlbDS8SOLQeoQ9FOzTO0ZwDPadJvRDR b8hEa/43LmQ5at/xNMjDKoh8TwCanuryHLqH5PGRUk6Jn3WRy/+qYQUxJNKVcJ7r4Sy7 Cpi/yuZR0KKYPZFwPx0dA0TutvT1s4TREQF+firRPR83/QB+3sIMIGGuv+QpKQSq0pFL NbMBA98v1oW3TrP6suoWtEr5VIigmyKT37siKV69UbA1UZl+miGT5mEnXh+XM/nGjhoZ kDmsNA/+2HBOvDMbjxpR6NpRkF3dEMyQAV+h60nhwdSqmuHOB25VJevABfpclAtuqwfw T57g== X-Gm-Message-State: AIVw111GOSVjjHHyjO3o/1CpNN0UkvaP7NLUOGQL9Jw57GPgiVWngf7W M8WWEZH426jZqWbjPccvmINgB/rCXQ== X-Received: by 10.202.73.207 with SMTP id w198mr1524439oia.27.1499808006099; Tue, 11 Jul 2017 14:20:06 -0700 (PDT) Original-Received: by 10.182.85.69 with HTTP; Tue, 11 Jul 2017 14:20:04 -0700 (PDT) Original-Received: by 10.182.85.69 with HTTP; Tue, 11 Jul 2017 14:20:04 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.218.52 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216505 Archived-At: --001a11c17dc26f57b00554114397 Content-Type: text/plain; charset="UTF-8" Sorry, ai mean the native line number feature, not this thing alex is talking about. On Jul 11, 2017 6:18 PM, "Filipe Silva" wrote: Eli, just a thought: wouldn't it be appropriate to ship a minor mode wrapping this feature? Or do you think it is better to just leave it to the community? On Jul 11, 2017 5:59 PM, "Alex" wrote: > Eli Zaretskii writes: > > > Here's the patch I propose to fix your variable-pitch problem: > > > > diff --git a/lisp/faces.el b/lisp/faces.el > > index c3693d1..52a4db5 100644 > > --- a/lisp/faces.el > > +++ b/lisp/faces.el > > @@ -2467,7 +2467,7 @@ trailing-whitespace > > > > ;; Definition stolen from linum.el. > > (defface line-number > > - '((t :inherit (shadow default))) > > + '((t :inherit (shadow default) :family "Monospace Serif")) > > "Face for displaying line numbers. > > This face is used when `display-line-numbers' is non-nil. > > > > This gives me a smaller line numbers by default, since I apparently have > not configured an appropriate serif font (my default font is DejaVu Sans > Mono). > > What about just inheriting from fixed-pitch rather than default? > > --001a11c17dc26f57b00554114397 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Sorry, ai mean the native line number feature, not t= his thing alex is talking about.

On Jul 11, 2017 6:18 PM, "Filipe Silva" <filipe.silva@gmail.com> wrot= e:
Eli, = just a thought: =C2=A0wouldn't it be appropriate to ship a minor mode w= rapping this feature?=C2=A0

Or= do you think it is better to just leave it to the community?



On Jul 11, = 2017 5:59 PM, "Alex" <agrambot@gmail.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">Eli Zaretskii <eliz@gnu.org> writes:

> Here's the patch I propose to fix your variable-pitch problem:
>
> diff --git a/lisp/faces.el b/lisp/faces.el
> index c3693d1..52a4db5 100644
> --- a/lisp/faces.el
> +++ b/lisp/faces.el
> @@ -2467,7 +2467,7 @@ trailing-whitespace
>
>=C2=A0 ;; Definition stolen from linum.el.
>=C2=A0 (defface line-number
> -=C2=A0 '((t :inherit (shadow default)))
> +=C2=A0 '((t :inherit (shadow default) :family "Monospace Ser= if"))
>=C2=A0 =C2=A0 "Face for displaying line numbers.
>=C2=A0 This face is used when `display-line-numbers' is non-nil. >

This gives me a smaller line numbers by default, since I apparently have not configured an appropriate serif font (my default font is DejaVu Sans Mono).

What about just inheriting from fixed-pitch rather than default?


--001a11c17dc26f57b00554114397--