all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Guillaume Pasquet <guillaume@bitimplosion.com>
To: help-gnu-emacs@gnu.org
Subject: Wrong minimum emacs version in flymake.el
Date: Thu, 9 Dec 2021 14:21:50 +0000	[thread overview]
Message-ID: <CAEpr+AVoTpZBsXBUjqKoDrwTt5UcmjGRBw_+dxDMa6J6syQ29A@mail.gmail.com> (raw)

Hi,

I've notice that flymake.el in master states that it requires minimum emacs
26.1, however this doesn't seem to be true as it makes use of the
`string-replace` function, which was introduced in Emacs 28 AFAIK.

Please either update the minimum emacs requirement for flymake or
substitute the `string-replace` call with `replace-regexp-in-string` to
maintain compatibility as I have done here:

https://github.com/Etenil/flymake/commit/9f5f76907b1c258645f65728dd71e7cacffe6d22


Best regards,

Guillaume


             reply	other threads:[~2021-12-09 14:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-09 14:21 Guillaume Pasquet [this message]
2021-12-09 14:51 ` Wrong minimum emacs version in flymake.el Emanuel Berg via Users list for the GNU Emacs text editor
2021-12-09 15:02 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEpr+AVoTpZBsXBUjqKoDrwTt5UcmjGRBw_+dxDMa6J6syQ29A@mail.gmail.com \
    --to=guillaume@bitimplosion.com \
    --cc=help-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.