From: E Sabof <esabof@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 14548@debbugs.gnu.org
Subject: bug#14548: 24.3.1; [PATCH] image-dired-dired-toggle-marked-thumbs conflicts with other modes using overlays
Date: Thu, 13 Jun 2013 15:39:49 +0100 [thread overview]
Message-ID: <CAEp6Dyawy0Q5qEZ1tABjjoBGsgM=c2iaZSDRBn460XsRndYrgg@mail.gmail.com> (raw)
In-Reply-To: <jwvobbaf63b.fsf-monnier+emacs@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 645 bytes --]
On Thu, Jun 13, 2013 at 3:18 PM, Stefan Monnier <monnier@iro.umontreal.ca>wrote:
> >> ! (let* ((cur-ovs (overlays-in (point) (1+ (point))))
> >> ! (thumb-ov (car (cl-remove-if-not
> >> ! (lambda (ov) (overlay-get ov
> 'thumb-file))
> >> ! cur-ovs))))
> >> ! (if thumb-ov
> >> ! (delete-overlay thumb-ov)
>
> BTW, now that I actually look at the code, I twonder why it doesn't use
> remove-overlays.
>
>
> Stefan
>
It's a toggler. It will remove the overlay if present, or create one. And
remove-overlays always returns nil.
Evgeni
[-- Attachment #2: Type: text/html, Size: 1238 bytes --]
prev parent reply other threads:[~2013-06-13 14:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 13:28 bug#14548: 24.3.1; [PATCH] image-dired-dired-toggle-marked-thumbs conflicts with other modes using overlays E Sabof
2013-06-11 19:08 ` Glenn Morris
2013-06-11 21:56 ` Stefan Monnier
2013-06-11 22:12 ` Glenn Morris
2013-06-11 23:00 ` E Sabof
2013-06-12 12:01 ` E Sabof
2013-06-12 19:25 ` Stefan Monnier
2013-06-13 5:11 ` Glenn Morris
2013-06-13 14:18 ` Stefan Monnier
2013-06-13 14:39 ` E Sabof [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEp6Dyawy0Q5qEZ1tABjjoBGsgM=c2iaZSDRBn460XsRndYrgg@mail.gmail.com' \
--to=esabof@gmail.com \
--cc=14548@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.