bug#13886: 24.3; vc-annotate won't show the log entry with git backend and hidden annotatation

bug#13886: 24.3; vc-annotate won't show the log entry with git backend and hidden annotatation

[E Sabof]

[-- Attachment #1: Type: text/plain, Size: 884 bytes --]

While in vc-annotate mode, with a git backend, if one hides the
annotations with vc-annotate-toggle-annotation-visiblity, and
tries to run vc-annotate-show-log-revision-at-line, it will display the
message "Cannot extract revision number from the current line".
Fixable by changing (move-beginning-of-line 1) to (forward-line 0) here:

(defun vc-git-annotate-extract-revision-at-line ()
  (save-excursion
    (forward-line 0)
    (when (looking-at "\\([0-9a-f^][0-9a-f]+\\) \\(\\([^(]+\\) \\)?")
      (let ((revision (match-string-no-properties 1)))
(if (match-beginning 2)
    (let ((fname (match-string-no-properties 3)))
      ;; Remove trailing whitespace from the file name.
      (when (string-match " +\\'" fname)
(setq fname (substring fname 0 (match-beginning 0))))
      (cons revision
    (expand-file-name fname (vc-git-root default-directory))))
  revision)))))

Evgeni

[-- Attachment #2: Type: text/html, Size: 1570 bytes --]

bug#13886: 24.3; vc-annotate won't show the log entry with git backend and hidden annotatation

[Dmitry Gutov]

Version: 24.4

Thanks for the report, fixed in 115219.

Though I've changed it to use `beginning-of-line' for better
consistency, because implementations of this command in other backends
do that.

bug#13886: 24.3; vc-annotate won't show the log entry with git backend and hidden annotatation

[E Sabof]

[-- Attachment #1: Type: text/plain, Size: 346 bytes --]

Sounds good, if it still fixes the problem. Thanks!

Evgeni


On Mon, Nov 25, 2013 at 2:30 AM, Dmitry Gutov <dgutov@yandex.ru> wrote:

> Version: 24.4
>
> Thanks for the report, fixed in 115219.
>
> Though I've changed it to use `beginning-of-line' for better
> consistency, because implementations of this command in other backends
> do that.
>

[-- Attachment #2: Type: text/html, Size: 695 bytes --]