From: E Sabof <esabof@gmail.com>
To: Tassilo Horn <tsdh@gnu.org>
Cc: 13887@debbugs.gnu.org
Subject: bug#13887: 24.3; doc-view will render blurry images when image-magick is available
Date: Thu, 7 Mar 2013 22:57:58 +0000 [thread overview]
Message-ID: <CAEp6DyYmZdNMVpkVM3TNQbwvofwiGw08SiEq8Dn2=SyMDY-Lkg@mail.gmail.com> (raw)
In-Reply-To: <CAEp6DyZYVdTDU5tAWMvL7vhNFiCp+zvBqt-pXW3j8ZVzi-zLzw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3046 bytes --]
Couldn't tell the difference to be honest.
Evgeni
On Thu, Mar 7, 2013 at 4:15 PM, E Sabof <esabof@gmail.com> wrote:
> I mean pressing + or - moves the page horizontally, instead of changing
> the size. I think the way it opens the document is ok.
>
> I'll have a look at the patch and let you know.
>
> Evgeni
>
>
> On Thu, Mar 7, 2013 at 3:55 PM, Tassilo Horn <tsdh@gnu.org> wrote:
>
>> E Sabof <esabof@gmail.com> writes:
>>
>> > I had a look at it, there are some issues with zooming. It doesn't
>> > work when I open a document that is larger than the window,
>>
>> Does that mean that you'd like to set the hscoll when the window is
>> smaller than the images so that the center of the image is displayed at
>> the center of the window?
>>
>> Hm, this could at least be done once when initially opening some
>> document. When switching pages, the current hscroll is preserved and I
>> consider that a good thing. It shouldn't re-center then.
>>
>> > and sometimes in other cases.
>>
>> I know there were some issues/errors when the image of a page isn't
>> there already. That should be fixed by this version of the patch.
>>
>> --8<---------------cut here---------------start------------->8---
>> === modified file 'lisp/doc-view.el'
>> --- lisp/doc-view.el 2013-02-28 04:02:36 +0000
>> +++ lisp/doc-view.el 2013-03-07 08:14:09 +0000
>> @@ -1250,7 +1250,7 @@
>> (when doc-view-pending-cache-flush
>> (clear-image-cache)
>> (setq doc-view-pending-cache-flush nil))
>> - (let ((ol (doc-view-current-overlay))
>> + (let* ((ol (doc-view-current-overlay))
>> (image (if (and file (file-readable-p file))
>> (if (not (and doc-view-scale-internally
>> (fboundp 'imagemagick-types)))
>> @@ -1258,9 +1258,20 @@
>> (unless (member :width args)
>> (setq args `(,@args :width ,doc-view-image-width)))
>> (apply 'create-image file 'imagemagick nil args))))
>> - (slice (doc-view-current-slice)))
>> + (slice (doc-view-current-slice))
>> + (img-width (and image (car (image-size image))))
>> + (displayed-img-width (if (and image slice)
>> + (* (/ (float (nth 2 slice))
>> + (car (image-size image 'pixels)))
>> + img-width)
>> + img-width))
>> + (window-width (window-width (selected-window))))
>> (setf (doc-view-current-image) image)
>> (move-overlay ol (point-min) (point-max))
>> + (when (and image (> window-width displayed-img-width))
>> + (overlay-put ol 'before-string
>> + (propertize " " 'display
>> + `(space :align-to (+ center (-0.5 .
>> ,displayed-img-width))))))
>> (overlay-put ol 'display
>> (cond
>> (image
>> --8<---------------cut here---------------end--------------->8---
>>
>> Bye,
>> Tassilo
>>
>
>
[-- Attachment #2: Type: text/html, Size: 4194 bytes --]
next prev parent reply other threads:[~2013-03-07 22:57 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 3:40 bug#13887: 24.3; doc-view will render blurry images when image-magick is available E Sabof
2013-03-06 8:05 ` Tassilo Horn
2013-03-06 12:13 ` E Sabof
2013-03-06 13:01 ` Tassilo Horn
2013-03-06 14:19 ` E Sabof
2013-03-06 19:43 ` Tassilo Horn
2013-03-07 15:17 ` E Sabof
2013-03-07 15:55 ` Tassilo Horn
2013-03-07 16:15 ` E Sabof
2013-03-07 22:57 ` E Sabof [this message]
2013-03-08 7:57 ` Tassilo Horn
[not found] ` <CAEp6DybMJkagHjRaXPiA_ED_dntOk=5USr+P9DfqRPZ_JrrKww@mail.gmail.com>
2013-03-09 7:25 ` bug#13887: Fwd: " E Sabof
2013-03-09 7:26 ` E Sabof
2013-03-11 9:11 ` Tassilo Horn
2013-03-11 16:57 ` Eli Zaretskii
2013-03-11 18:20 ` Tassilo Horn
2013-03-11 18:45 ` Eli Zaretskii
2013-03-11 20:27 ` Tassilo Horn
2013-03-11 20:59 ` Eli Zaretskii
2013-03-11 22:08 ` E Sabof
2013-03-11 23:41 ` E Sabof
2013-03-12 1:00 ` E Sabof
2013-03-12 8:09 ` Tassilo Horn
2013-03-12 16:50 ` Eli Zaretskii
2013-03-12 18:00 ` Tassilo Horn
2013-03-12 16:52 ` Eli Zaretskii
2013-03-12 17:46 ` E Sabof
2013-03-12 21:11 ` Eli Zaretskii
2013-03-14 3:28 ` E Sabof
2013-03-14 3:56 ` E Sabof
2013-03-14 7:24 ` Tassilo Horn
2013-03-14 15:23 ` E Sabof
2013-03-14 16:48 ` Tassilo Horn
2013-03-14 21:42 ` Tassilo Horn
2013-03-15 1:11 ` E Sabof
2013-03-15 12:52 ` Stefan Monnier
2013-03-15 13:34 ` E Sabof
2013-03-15 17:51 ` Stefan Monnier
2013-03-15 23:26 ` E Sabof
2013-03-16 13:41 ` Stefan Monnier
2013-03-16 23:30 ` E Sabof
2013-03-15 13:55 ` Tassilo Horn
2013-03-15 14:08 ` E Sabof
2013-03-20 15:58 ` E Sabof
2019-09-26 17:16 ` Lars Ingebrigtsen
2019-10-14 6:04 ` Lars Ingebrigtsen
2013-03-14 13:26 ` Stefan Monnier
2013-03-14 15:30 ` Tassilo Horn
2013-03-14 15:53 ` E Sabof
2013-03-14 16:19 ` Stefan Monnier
2013-03-06 18:16 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEp6DyYmZdNMVpkVM3TNQbwvofwiGw08SiEq8Dn2=SyMDY-Lkg@mail.gmail.com' \
--to=esabof@gmail.com \
--cc=13887@debbugs.gnu.org \
--cc=tsdh@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.