From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: E Sabof Newsgroups: gmane.emacs.bugs Subject: bug#14548: 24.3.1; [PATCH] image-dired-dired-toggle-marked-thumbs conflicts with other modes using overlays Date: Wed, 12 Jun 2013 00:00:52 +0100 Message-ID: References: <1qr4g8lb29.fsf@fencepost.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=002354790f1c6e8be604dee8deb7 X-Trace: ger.gmane.org 1370991716 21066 80.91.229.3 (11 Jun 2013 23:01:56 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 11 Jun 2013 23:01:56 +0000 (UTC) Cc: 14548@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 12 01:01:55 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UmXZb-0001Vt-H0 for geb-bug-gnu-emacs@m.gmane.org; Wed, 12 Jun 2013 01:01:55 +0200 Original-Received: from localhost ([::1]:34425 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UmXZb-0001Uh-4U for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Jun 2013 19:01:55 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UmXZU-0001UP-G3 for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2013 19:01:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UmXZS-0003vf-4j for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2013 19:01:48 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53095) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UmXZS-0003va-1X for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2013 19:01:46 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1UmXZi-00022b-Jb for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2013 19:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: E Sabof Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jun 2013 23:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14548 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 14548-submit@debbugs.gnu.org id=B14548.13709916777761 (code B ref 14548); Tue, 11 Jun 2013 23:02:02 +0000 Original-Received: (at 14548) by debbugs.gnu.org; 11 Jun 2013 23:01:17 +0000 Original-Received: from localhost ([127.0.0.1]:57330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UmXYz-000216-0L for submit@debbugs.gnu.org; Tue, 11 Jun 2013 19:01:17 -0400 Original-Received: from mail-qe0-f43.google.com ([209.85.128.43]:51483) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UmXYx-00020u-7p for 14548@debbugs.gnu.org; Tue, 11 Jun 2013 19:01:15 -0400 Original-Received: by mail-qe0-f43.google.com with SMTP id q19so1895622qeb.16 for <14548@debbugs.gnu.org>; Tue, 11 Jun 2013 16:00:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Ju+Ys9+S4jutCc6WmNtNXDirBj1GZuUuv3OBGyZHMNk=; b=FzLGIXJOTQ5N1yCyE21ZA04gq5OZyWHolU2wv5/2cDdAZVI7GTTZrvPBs1RV74igew 6zQ6tt/L90BZNCGdaimRCtEqbSaDZRc7w8Vml6XiRBnIAazRyCEQ6orjNGWN8YPhRYnN AUoaZo5cNi9v1nQTjjzFDXKn8H4Mne7at22oOu5smQGZvHYfgrnc6Dx4/xX49YIHuS4S gWKj7ync8RbHYvZVQgULCOhZ9+oZj4LMWhJ/XXHi3qFPRawyjysofVnNikK5UUvaY5SN 3fpad0JN3a2ImAfgWHY1NxggwKWlpOIwXzZrSSGPiujX06cvooGRbpLajojTDJYmYzxy jdxQ== X-Received: by 10.229.136.213 with SMTP id s21mr2216016qct.9.1370991652405; Tue, 11 Jun 2013 16:00:52 -0700 (PDT) Original-Received: by 10.49.18.162 with HTTP; Tue, 11 Jun 2013 16:00:52 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:74997 Archived-At: --002354790f1c6e8be604dee8deb7 Content-Type: text/plain; charset=ISO-8859-1 On Tue, Jun 11, 2013 at 11:12 PM, Glenn Morris wrote: > Stefan Monnier wrote: > > >> The idea seems fine, but as written it won't work without requiring > >> cl-lib at run-time. > > > > That's fine for non-preloaded packages. > > I meant that image-dired does not presently require cl-lib at runtime, > so to be a complete solution the patch should have included that change > too. > Basically, whenever a line contains an overlay and this function is evoked, it thinks it already has a thumbnail, and won't put a new one there. I can rewrite the function so it doesn't use cl-remove-if-not, although I assumed that avoidance of the execution/expansion distinction was one of the reasons cl-lib was created. Evgeni --002354790f1c6e8be604dee8deb7 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable --002354790f1c6e8be604dee8deb7--