From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: E Sabof Newsgroups: gmane.emacs.bugs Subject: bug#13887: 24.3; doc-view will render blurry images when image-magick is available Date: Thu, 14 Mar 2013 15:53:28 +0000 Message-ID: References: <87sj46493q.fsf@thinkpad.tsdh.de> <877gle1etb.fsf@thinkpad.tsdh.de> <838v5tx4av.fsf@gnu.org> <87txohx0g0.fsf@thinkpad.tsdh.de> <831ubllqr0.fsf@gnu.org> <87zjy9vg0r.fsf@thinkpad.tsdh.de> <83y5dtk606.fsf@gnu.org> <83li9sk1bh.fsf@gnu.org> <83hakgjpbi.fsf@gnu.org> <87a9q6dmo2.fsf@thinkpad.tsdh.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7bdc8b0a13344f04d7e486ac X-Trace: ger.gmane.org 1363276458 23488 80.91.229.3 (14 Mar 2013 15:54:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 14 Mar 2013 15:54:18 +0000 (UTC) Cc: 13887@debbugs.gnu.org To: Tassilo Horn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 14 16:54:41 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UGAU8-00077i-3e for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Mar 2013 16:54:28 +0100 Original-Received: from localhost ([::1]:43468 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UGATl-0003NH-Lg for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Mar 2013 11:54:05 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:42124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UGATe-0003KP-VL for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2013 11:54:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UGATW-0006hF-OX for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2013 11:53:58 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50188) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UGATW-0006gy-LY for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2013 11:53:50 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UGAUf-0004eH-T3 for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2013 11:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: E Sabof Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Mar 2013 15:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13887 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13887-submit@debbugs.gnu.org id=B13887.136327649917861 (code B ref 13887); Thu, 14 Mar 2013 15:55:01 +0000 Original-Received: (at 13887) by debbugs.gnu.org; 14 Mar 2013 15:54:59 +0000 Original-Received: from localhost ([127.0.0.1]:54296 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UGAUX-0004ds-TO for submit@debbugs.gnu.org; Thu, 14 Mar 2013 11:54:58 -0400 Original-Received: from mail-qa0-f45.google.com ([209.85.216.45]:54791) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UGAUQ-0004dZ-1m for 13887@debbugs.gnu.org; Thu, 14 Mar 2013 11:54:52 -0400 Original-Received: by mail-qa0-f45.google.com with SMTP id g10so2934659qah.11 for <13887@debbugs.gnu.org>; Thu, 14 Mar 2013 08:53:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=jpAE/0FBl+IT2Eg/EsDivmOs8o6oyCaX8K2QN21anAo=; b=I6dBnQdVEKY2mVgkR0weJJyeQ3GAvFVRlIafferdjWC5w97WcZrQyiP0OwLJ08ERSE JIPBiBHbAdwZVJwoTJdJpF+2sBc4ODaSSF+y75eTalzamdUtZw/7C4kkeXZPZ7xDENbj U9u134nF2L/SOhJI8hWcMnPJD+C+uw0snJwxZ60ZbjdK60iwn9HTUgKWkiZih1P+BlPP 338O6QlPi2nohhpG5sr50z63UFCHOWI2Mp53UhJ3t4hvV2x3bwV9bXj/KimSbw7EKVBD 0qQRyd+O7jed6WuncpoKmk75xyzbmjMSdmTVkorUD0FHJVaidyzq4Tq7SPDYF02gr3kj wjPA== X-Received: by 10.49.87.40 with SMTP id u8mr3109852qez.62.1363276408761; Thu, 14 Mar 2013 08:53:28 -0700 (PDT) Original-Received: by 10.49.70.233 with HTTP; Thu, 14 Mar 2013 08:53:28 -0700 (PDT) In-Reply-To: <87a9q6dmo2.fsf@thinkpad.tsdh.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:72477 Archived-At: --047d7bdc8b0a13344f04d7e486ac Content-Type: text/plain; charset=ISO-8859-1 Tested the trunk version of doc-view with "emacs -Q". I am still not getting not getting an inital overlay. However I do get overlays after I zoom and split. (I still get occasional pages with no overlays after spltting if I use my default configuration) Also If you zoom/split/delete windows for a while, doc-view stops centering overlays in new windows. Evgeni On Thu, Mar 14, 2013 at 3:30 PM, Tassilo Horn wrote: > Stefan Monnier writes: > > >> + (unless (eq (window-buffer) (current-buffer)) > >> + (set-window-buffer (selected-window) (current-buffer))) > > > > This can't be the right fix: doc-view.el is just a major-mode that > > controls how a particular buffer is displayed, and not which buffer to > > display in which window. > > > > [ I see Tassilo has a better patch already, so I'll let him take care of > > it, but I just wanted to point out "the obvious". ] > > I've committed my patch now. Evgeni, please report back if it really > solves the issue for you, so that I can close this issue. > > Stefan, do you think the horizontal centering of images in case the > window is wider than the image should be customizable? Currently it's > not which is fine with me and is what other viewers also do. > > Bye, > Tassilo > --047d7bdc8b0a13344f04d7e486ac Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Tested the trunk version of doc-view with "emacs -Q&q= uot;. I am still not getting not getting an inital overlay. However I do ge= t overlays after I zoom and split. (I still get occasional pages with no ov= erlays after spltting if I use my default configuration)

Also If you zoom/split/delete windows for a while, doc= -view stops centering overlays in new windows.

Evgeni


On Thu, Mar 14, 2013 at 3:30 PM, Tassilo Horn <tsdh@gnu.org> wrot= e:
Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> + =A0 =A0 =A0 =A0(unless (eq (window-buffer) (current-buffer))
>> + =A0 =A0 =A0 =A0 =A0(set-window-buffer (selected-window) (current= -buffer)))
>
> This can't be the right fix: doc-view.el is just a major-mode that=
> controls how a particular buffer is displayed, and not which buffer to=
> display in which window.
>
> [ I see Tassilo has a better patch already, so I'll let him take c= are of
> =A0 it, but I just wanted to point out "the obvious". =A0]
I've committed my patch now. =A0Evgeni, please report back = if it really
solves the issue for you, so that I can close this issue.

Stefan, do you think the horizontal centering of images in case the
window is wider than the image should be customizable? =A0Currently it'= s
not which is fine with me and is what other viewers also do.

Bye,
Tassilo

--047d7bdc8b0a13344f04d7e486ac--