Oops. Is there anything that can be salvaged from my patch? Aside from fixing the bug, it also adds a unit test and refactors the logic for finding a function's argument list into a separate function that's not part of the help system.

On Oct 13, 2017 10:51 PM, "Noam Postavsky" <npostavs@users.sourceforge.net> wrote:
John Williams <jrw@pobox.com> writes:

> Subject: [PATCH] Fixed compiler warnings for advised functions.

I think this bug was already fixed in emacs-26, see [1: 6e2d6d54e1],
Bug#14860 (https://debbugs.gnu.org/cgi/bugreport.cgi?bug=14860).

[1: 6e2d6d54e1]: 2017-07-14 11:27:21 -0400
  * lisp/emacs-lisp/bytecomp.el: Fix bug#14860.
  http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=6e2d6d54e1236216462c13655ea1fe573d9672e7