From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: John Williams Newsgroups: gmane.emacs.bugs Subject: bug#28803: [PATCH] Fixed compiler warnings for advised functions. Date: Sat, 14 Oct 2017 17:30:46 -0700 Message-ID: References: <87infi9t0p.fsf@users.sourceforge.net> <874lr19trw.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1508027551 21759 195.159.176.226 (15 Oct 2017 00:32:31 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 15 Oct 2017 00:32:31 +0000 (UTC) Cc: 28803@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 15 02:32:26 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3Wqi-0003AI-Tw for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Oct 2017 02:32:13 +0200 Original-Received: from localhost ([::1]:55573 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3Wqo-0004cT-Ov for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Oct 2017 20:32:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50537) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3Wqb-0004bB-I6 for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2017 20:32:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e3WqY-000882-F0 for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2017 20:32:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60313) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e3WqY-00087u-AN for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2017 20:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e3WqY-0004d4-1R for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2017 20:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: John Williams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 Oct 2017 00:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28803 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28803-submit@debbugs.gnu.org id=B28803.150802747517732 (code B ref 28803); Sun, 15 Oct 2017 00:32:01 +0000 Original-Received: (at 28803) by debbugs.gnu.org; 15 Oct 2017 00:31:15 +0000 Original-Received: from localhost ([127.0.0.1]:40761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3Wpm-0004bv-RW for submit@debbugs.gnu.org; Sat, 14 Oct 2017 20:31:15 -0400 Original-Received: from mail-wm0-f49.google.com ([74.125.82.49]:50540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3Wpl-0004bc-5B for 28803@debbugs.gnu.org; Sat, 14 Oct 2017 20:31:13 -0400 Original-Received: by mail-wm0-f49.google.com with SMTP id u138so27221910wmu.5 for <28803@debbugs.gnu.org>; Sat, 14 Oct 2017 17:31:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=gTEVo3Ti98Nd/DW2Ofgs5uMEll7CBDJcxjiPcHd6nOc=; b=IktOUXfc4u+CFGJninPaVU72Q4tCdp/wE0GQmGb3dpH6NPfJSqK3oehR2j3/Ro5AnI a3ZZ4kMJwO46XUw+Rw4EI+E2304B6MA9m/HGFiGXrkmQgnfV7yUuW4G2hMJyGpyrjulj z8maTsm34HlN7nBsf05nBPJSsQjGdRUbKa32YxrG4ja3YsT+f/VmYkyhe1cgu7Ray6oH Nr7yRFPG9c2uDKiIjwybmp9CiICpj349ZxZX3KUxEP3WjK47IMA72twSBG7/Vt7gVD/s 7QBUWY/1nIhPvps294WuLNnVkZ22RmgBycG90o8kTjdgSaETUDizBvhrV3kiceyAPE4N zmBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=gTEVo3Ti98Nd/DW2Ofgs5uMEll7CBDJcxjiPcHd6nOc=; b=Qgj5CjBtV09raHtaFrYYDbgCgJ0uIEnfedkn9srj+hBd/dlrb15eye67OXJba1b92A 0G04n180nt5Kg8Zx4VlNe1J4eRtyAAY4OyTegCfx5uGCGJ9V9j26yTOxqlNt410WtZY0 SKxjRj5b/q0rkJ72qMgo9lt60DkZC4WW+sexyOv22u4Ttg12n3usNIroba5vjT/qWrzU 9Pom1ZNjvueExM4176Uki4DNGM1vUAIxAzB59ubQuFuLglWolnJbfpPXvs6JWjfUtt3l c4qjg2KBqcf2Q2vNXOab7NIlZc0lwNG9peejpANmH76rijU8FXkGUr52MVXvgVNvvr1a Y4wg== X-Gm-Message-State: AMCzsaUwiHtTBArbdg1KOx2+6GTtzouvx+JsMzJOitgXuCSfkt5WKzRT XQdtdcY7QkD6xTAqD6XjN/vZZDY1lMmrfZyymoM= X-Google-Smtp-Source: AOwi7QBDgP/cm1uGVYssF0kHd5BuplNIj2TPMu8u8pR2AskUPBtv1PJe3tmVmPaqeUkZ99TUuQDhequgGNhWDPsEiXo= X-Received: by 10.28.63.145 with SMTP id m139mr4929238wma.5.1508027467273; Sat, 14 Oct 2017 17:31:07 -0700 (PDT) Original-Received: by 10.28.111.93 with HTTP; Sat, 14 Oct 2017 17:30:46 -0700 (PDT) In-Reply-To: <874lr19trw.fsf@users.sourceforge.net> X-Google-Sender-Auth: NAKosUoMCTPqDP_fXXhxSPpLVDE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138431 Archived-At: On Sat, Oct 14, 2017 at 4:47 PM, Noam Postavsky wrote: > John Williams writes: > >> Oops. Is there anything that can be salvaged from my patch? Aside >> from fixing the bug, it also adds a unit test and refactors the logic >> for finding a function's argument list into a separate function >> that's not part of the help system. > > We could add the test, it seems to be passing in emacs-26. Have you > assigned copyright to Emacs? (It's okay if you haven't, the patch is > small enough to go in regardless, we would just need to mark it.) No; how would I go about doing that? The organization of the dev site is a bit confusing to me. > I don't think there's much need for moving the function argument > retrieval out of the help system. It's not a huge deal to me, but it seems weird that something like nadvice.el would depend on the help system (which it would in my patch if I hadn't moved that function--I assume the fix that was already committed does something similar). > (By the way, if you've spent some time looking at help-function-arglist, > perhaps you have some ideas about Bug#26270? > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=26270) I took a look at your patch, and without having tried running it, it seems pretty reasonable to me. A unit test of some sort would be nice, but since there don't seem to be any for help-function-arglist yet, accepting the patch as-is would leave the unit test situation no worse than it was before. I'm not a regular contributor, though, so my opinion is worth what you paid for it.