From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Campbell Barton Newsgroups: gmane.emacs.devel Subject: Re: Support for undo-amalgamate in a version of the atomic-change-group macro (with patch) Date: Mon, 8 Nov 2021 16:41:48 +1100 Message-ID: References: <2d2efa59-cf88-5238-0db6-58d55e6c5c98@gmail.com> <87v913b6g7.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000a4f0c805d0407329" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21539"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , Emacs developers To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 08 06:45:27 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjxTC-0005SP-MN for ged-emacs-devel@m.gmane-mx.org; Mon, 08 Nov 2021 06:45:26 +0100 Original-Received: from localhost ([::1]:48352 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mjxTB-0005JN-NT for ged-emacs-devel@m.gmane-mx.org; Mon, 08 Nov 2021 00:45:25 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38930) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjxPv-0003No-A4 for emacs-devel@gnu.org; Mon, 08 Nov 2021 00:42:03 -0500 Original-Received: from [2607:f8b0:4864:20::102f] (port=46896 helo=mail-pj1-x102f.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mjxPt-0004SH-HF for emacs-devel@gnu.org; Mon, 08 Nov 2021 00:42:02 -0500 Original-Received: by mail-pj1-x102f.google.com with SMTP id f20-20020a17090a639400b001a772f524d1so173197pjj.5 for ; Sun, 07 Nov 2021 21:42:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XD2NQB5CAmYLonU0vTCiGIBkiHnXs1A6235pIZD254E=; b=PsCTvEpEWWrds26DnYhYHMw8i05QjCGrx4PqvkaHcB6DDk/JvhXg4mygANqp1e1fz7 7TmtM8+L28VDC07YApbyGCjZKUpWV2JtbQERh7BNbmPqBuEWoMxi3AIMnno9V7BvKr+h wMkaPfvI3nFcN3Sn9fj5oV+seGIcJ3Pt+8LgQUgtJBe3OrMoR3Ol8Z84GpFxaOPE71zV GXyZtbxzgOv0A2BTlfbKjxyUCLMpq8y/Ep9c2GWyuHZ+r6ClSmTUZL2X5aa1LfzI7xAM RJGTkwBhUx5vG8RKeZBJ0LeD+6iCPylH4rCVckalHzOdZReeGOyxRYV5QScPynKwc9MF 2MFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XD2NQB5CAmYLonU0vTCiGIBkiHnXs1A6235pIZD254E=; b=uW3TRno4FCVYhlB5nGhbtQdXYim+6Gd/t0BfFN/Eu1QYmM1sdhDCA69gqW+/6vUy8k DRlAx7OSrNT81aRaEzgliBw1to9TQrER/sgQjbMHE7IhziGoco35cT5/zC0uPE6bgiyY mpi7ZODIaMkaqrMb1yFqzng6dz3uo3fDMKJw8AgEoC2cvujRPk7F5X9JBVtTJIOMWgm9 DdgvL+E9PNpTQ5qMmPWoyPv2hB19xFvGSeNqBVSlVQXwWYfy5rPLv5bUdFDaZrx/Q2uL VcEU/n8BRFa67qJrd/HvgNVD8PncUwjeEJ1FyB2q4sOtcRaW603qziQqPJxqjIAREnJM HrxQ== X-Gm-Message-State: AOAM533Q90PAmw3l421jPKmWQUf3cg0Qx/Pi4JIjUSU/Vjyc4mB6MnRm voRd3WEC063h5Ue8leomF64UwUC5fX7gRv1uXhw= X-Google-Smtp-Source: ABdhPJxpKoIDFHYTdxT5/XGjfi7pZsrmPK5HSCHhPgFNSFapsKbLw9/MpDdm9AN4gmzmLzdvQNy1yVI+LXvlsyWrvoA= X-Received: by 2002:a17:90b:4c02:: with SMTP id na2mr49653060pjb.94.1636350120221; Sun, 07 Nov 2021 21:42:00 -0800 (PST) In-Reply-To: <87v913b6g7.fsf@gnus.org> X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::102f (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::102f; envelope-from=ideasman42@gmail.com; helo=mail-pj1-x102f.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:279017 Archived-At: --000000000000a4f0c805d0407329 Content-Type: text/plain; charset="UTF-8" On Mon, Nov 8, 2021 at 3:46 PM Lars Ingebrigtsen wrote: > > Stefan Monnier writes: > > > The less verbose name is better, indeed. > > Could even be `with-single-undo`. > > I like it. > > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no Updated the patch, for what it's worth - I'm not so keen on the name `with-single-undo'. - `with-undo-amagamate' hints this is a wrapper for undo-amalgamate-change-group. - The term "amagamate" emphasizes that any undo barriers are merged, whereas "single" reads as if a single undo step might always be added (which isn't the case). ... another alternative is `with-undo-collapse` which is used in some of the packages that include this functionality on MELPA. Although I'd err on the side of not introducing new terminology to describe concepts already used elsewhere hence with-`undo-amagamate'. -- - Campbell --000000000000a4f0c805d0407329 Content-Type: text/x-patch; charset="US-ASCII"; name="emacs-with-undo-amalgamate.diff" Content-Disposition: attachment; filename="emacs-with-undo-amalgamate.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kvq8dxr10 Y29tbWl0IDI5NjRmYTEyNmEwNTliYjZmNjEwYzQzZmQ4YmNmMWU3MDBhM2YxMDcKQXV0aG9yOiBD YW1wYmVsbCBCYXJ0b24gPGlkZWFzbWFuNDJAZ21haWwuY29tPgpEYXRlOiAgIE1vbiBOb3YgOCAx NjozMzozOSAyMDIxICsxMTAwCgogICAgQWRkICd3aXRoLXVuZG8tYW1hbGdhbWF0ZScgbWFjcm8K CiAgICBUaGlzIGFsbG93cyBjb21tYW5kcyB0byBiZSBtYWRlIHdpdGhvdXQgYWRkaW5nIHVuZG8t YmFycmllcnMsIGUuZy4KICAgIGttYWNyby1leGVjLXJpbmctaXRlbS4KCmRpZmYgLS1naXQgYS9s aXNwL3N1YnIuZWwgYi9saXNwL3N1YnIuZWwKaW5kZXggZjZkYmQwMDUzMi4uNzNiNzk5YzY1YiAx MDA2NDQKLS0tIGEvbGlzcC9zdWJyLmVsCisrKyBiL2xpc3Avc3Vici5lbApAQCAtMzU0Miw2ICsz NTQyLDI5IEBAIGF0b21pYy1jaGFuZ2UtZ3JvdXAKIAkgICAgIChhY2NlcHQtY2hhbmdlLWdyb3Vw ICxoYW5kbGUpCiAJICAgKGNhbmNlbC1jaGFuZ2UtZ3JvdXAgLGhhbmRsZSkpKSkpKQoKKyhkZWZt YWNybyB3aXRoLXVuZG8tYW1hbGdhbWF0ZSAoJnJlc3QgYm9keSkKKyAgIkxpa2UgYHByb2duJyBi dXQgcGVyZm9ybSBCT0RZIHdpdGggYW1hbGdhbWF0ZWQgdW5kbyBiYXJyaWVycy4KKworVGhpcyBh bGxvd3MgbXVsdGlwbGUgb3BlcmF0aW9ucyB0byBiZSB1bmRvbmUgaW4gYSBzaW5nbGUgc3RlcC4K K1doZW4gdW5kbyBpcyBkaXNhYmxlZCB0aGlzIGJlaGF2ZXMgbGlrZSBgcHJvZ24nLiIKKyAgKGRl Y2xhcmUgKGluZGVudCAwKSAoZGVidWcgdCkpCisgIChsZXQgKChoYW5kbGUgKG1ha2Utc3ltYm9s ICItLWNoYW5nZS1ncm91cC1oYW5kbGUtLSIpKSkKKyAgICBgKGxldCAoKCxoYW5kbGUgKHByZXBh cmUtY2hhbmdlLWdyb3VwKSkKKyAgICAgICAgICAgOzsgRG9uJ3QgdHJ1bmNhdGUgYW55IHVuZG8g ZGF0YSBpbiB0aGUgbWlkZGxlIG9mIHRoaXMuCisgICAgICAgICAgIDs7IFRoaXMgZ3VhcmFudGVl cyB0aGUgcmVzdWx0aW5nIHVuZG8gc3RlcCBpcyBjb21wbGV0ZSwKKyAgICAgICAgICAgOzsgc28g dGhlIHVzZXIgY2FuJ3QgdW5kbyBpbnRvIGFuIGludGVybWVkaWF0ZSBzdGVwCisgICAgICAgICAg IDs7IHBlcmZvcm1lZCB3aXRoaW4gdGhlIGJvZHkgb2YgdGhpcyBtYWNyby4KKyAgICAgICAgICAg KHVuZG8tb3V0ZXItbGltaXQgbmlsKQorICAgICAgICAgICAodW5kby1saW1pdCBtb3N0LXBvc2l0 aXZlLWZpeG51bSkKKyAgICAgICAgICAgKHVuZG8tc3Ryb25nLWxpbWl0IG1vc3QtcG9zaXRpdmUt Zml4bnVtKSkKKyAgICAgICAodW53aW5kLXByb3RlY3QKKyAgICAgICAgICAgKHByb2duCisgICAg ICAgICAgICAgKGFjdGl2YXRlLWNoYW5nZS1ncm91cCAsaGFuZGxlKQorICAgICAgICAgICAgICxA Ym9keSkKKyAgICAgICAgIChwcm9nbgorICAgICAgICAgICAoYWNjZXB0LWNoYW5nZS1ncm91cCAs aGFuZGxlKQorICAgICAgICAgICAodW5kby1hbWFsZ2FtYXRlLWNoYW5nZS1ncm91cCAsaGFuZGxl KSkpKSkpCisKIChkZWZ1biBwcmVwYXJlLWNoYW5nZS1ncm91cCAoJm9wdGlvbmFsIGJ1ZmZlcikK ICAgIlJldHVybiBhIGhhbmRsZSBmb3IgdGhlIGN1cnJlbnQgYnVmZmVyJ3Mgc3RhdGUsIGZvciBh IGNoYW5nZSBncm91cC4KIElmIHlvdSBzcGVjaWZ5IEJVRkZFUiwgbWFrZSBhIGhhbmRsZSBmb3Ig QlVGRkVSJ3Mgc3RhdGUgaW5zdGVhZC4K --000000000000a4f0c805d0407329--