From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: immerrr again Newsgroups: gmane.emacs.bugs Subject: bug#21657: 25.0.50; Python mode goes into an infinite loop Date: Tue, 13 Oct 2015 08:42:07 +0300 Message-ID: References: <87wpuv7kdt.fsf@secretsauce.net> <561C78BE.6070109@dancol.org> <561C9126.70608@dancol.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1444715016 21457 80.91.229.3 (13 Oct 2015 05:43:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 13 Oct 2015 05:43:36 +0000 (UTC) Cc: 21657@debbugs.gnu.org, Dima Kogan , Luke Powers To: Daniel Colascione Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 13 07:43:26 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZlsMv-0003Qv-8X for geb-bug-gnu-emacs@m.gmane.org; Tue, 13 Oct 2015 07:43:25 +0200 Original-Received: from localhost ([::1]:60710 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlsMu-0006pW-HF for geb-bug-gnu-emacs@m.gmane.org; Tue, 13 Oct 2015 01:43:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39148) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlsMc-0006ay-6K for bug-gnu-emacs@gnu.org; Tue, 13 Oct 2015 01:43:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZlsMY-0002G5-Rp for bug-gnu-emacs@gnu.org; Tue, 13 Oct 2015 01:43:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48712) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZlsMY-0002G1-No for bug-gnu-emacs@gnu.org; Tue, 13 Oct 2015 01:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZlsMY-0002jp-Bi for bug-gnu-emacs@gnu.org; Tue, 13 Oct 2015 01:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: immerrr again Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Oct 2015 05:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21657 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 21657-submit@debbugs.gnu.org id=B21657.144471493010455 (code B ref 21657); Tue, 13 Oct 2015 05:43:02 +0000 Original-Received: (at 21657) by debbugs.gnu.org; 13 Oct 2015 05:42:10 +0000 Original-Received: from localhost ([127.0.0.1]:37683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZlsLh-0002iX-DQ for submit@debbugs.gnu.org; Tue, 13 Oct 2015 01:42:09 -0400 Original-Received: from mail-yk0-f171.google.com ([209.85.160.171]:35956) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZlsLf-0002iQ-Fa for 21657@debbugs.gnu.org; Tue, 13 Oct 2015 01:42:08 -0400 Original-Received: by ykey125 with SMTP id y125so6787239yke.3 for <21657@debbugs.gnu.org>; Mon, 12 Oct 2015 22:42:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=r/K309bwl64jGmNENa1MSU7QEDpxI61uP2CvETzgYLc=; b=Af7xQE8gSZ0klOVZH6EatRXr3n1W2uOf8KRIGgtuNjXOfatT/Yr6ewoKrs4Ue45Dfn CL4Hn7UJDle0Eh32A6dggYKT07/FV2BoYtUC24SuPhxF9I1akCe8R5I+9+PO/iaeqJhv r4OF8kWCvcrqdhcSQGO3qWW2jIoQ3aaUnS6MGCl4kA3UQ/zARt0jflDWKpzJ4a8N0Rm9 G/H5Ey/E4Mvs8wPtaznzo813nuODUiD/A1flaFNcr2hvb9FGM2gUQdAY1POxA02062jr UggSsP4HMFsgszqXWzk9ERQd3nO6HccbFj/qpVst83xhNCP2VTCE88iKaWgVkedsiclj iJrw== X-Received: by 10.129.79.129 with SMTP id d123mr22906371ywb.159.1444714927079; Mon, 12 Oct 2015 22:42:07 -0700 (PDT) Original-Received: by 10.13.212.197 with HTTP; Mon, 12 Oct 2015 22:42:07 -0700 (PDT) In-Reply-To: <561C9126.70608@dancol.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:107562 Archived-At: On Tue, Oct 13, 2015 at 8:05 AM, Daniel Colascione wrote: > I saw your message after I sent mine. How exactly is it supposed to > work? I can't reliably repro the condition that leads to the variable > being inherited across buffers (even with Torsten Bronger's testcase), > so I can't test it. It doesn't seem like adding a DEFSYM should make a > difference here though. Can you explain why your patch works? > Apparently, I was testing a version that was older than [1] since it was reproduced reliably. With it, the variable indeed seems properly buffer-local. I think I misread commit metadata in git blame thinking that the commit was from the last year, so I presumed that my Emacs version already had it. I couldn't find any docs about obarray initialization procedure (DEFSYM code-generation and alike), that was the only place where Fmake_variable_buffer_local was invoked on intern("foo") instead of a DEFSYM-initialized variable and I didn't have much time to deduce from sources how these two approaches differ, so I simply changed it to look like the others and ensured that it worked after the change. Feel free to ignore that patch if it is unnecessary. 1. https://github.com/emacs-mirror/emacs/commit/0360b7f2c4f0358106e229de4dfe91a67445a50c