all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: immerrr again <immerrr@gmail.com>
To: Daniel Colascione <dancol@dancol.org>
Cc: 21657@debbugs.gnu.org, Dima Kogan <dima@secretsauce.net>,
	Luke Powers <luke.powers@openx.com>
Subject: bug#21657: 25.0.50; Python mode goes into an infinite loop
Date: Tue, 13 Oct 2015 08:42:07 +0300	[thread overview]
Message-ID: <CAERznn_Z9-iB9OHM_VJayn4bpZMsAbgzn3JUoVpSxVRnk+POjg@mail.gmail.com> (raw)
In-Reply-To: <561C9126.70608@dancol.org>

On Tue, Oct 13, 2015 at 8:05 AM, Daniel Colascione <dancol@dancol.org> wrote:
> I saw your message after I sent mine. How exactly is it supposed to
> work? I can't reliably repro the condition that leads to the variable
> being inherited across buffers (even with Torsten Bronger's testcase),
> so I can't test it. It doesn't seem like adding a DEFSYM should make a
> difference here though. Can you explain why your patch works?
>

Apparently, I was testing a version that was older than [1] since it
was reproduced reliably. With it, the variable indeed seems properly
buffer-local. I think I misread commit metadata in git blame thinking
that the commit was from the last year, so I presumed that my Emacs
version already had it. I couldn't find any docs about obarray
initialization procedure (DEFSYM code-generation and alike), that was
the only place where Fmake_variable_buffer_local was invoked on
intern("foo") instead of a DEFSYM-initialized variable and I didn't
have much time to deduce from sources how these two approaches differ,
so I simply changed it to look like the others and ensured that it
worked after the change. Feel free to ignore that patch if it is
unnecessary.

1. https://github.com/emacs-mirror/emacs/commit/0360b7f2c4f0358106e229de4dfe91a67445a50c





      reply	other threads:[~2015-10-13  5:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-09 22:22 bug#21657: 25.0.50; Python mode goes into an infinite loop Dima Kogan
2015-10-09 23:16 ` Luke Powers
2015-10-13  3:21   ` Daniel Colascione
2015-10-13  4:58     ` immerrr again
2015-10-13  5:05       ` Daniel Colascione
2015-10-13  5:42         ` immerrr again [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAERznn_Z9-iB9OHM_VJayn4bpZMsAbgzn3JUoVpSxVRnk+POjg@mail.gmail.com \
    --to=immerrr@gmail.com \
    --cc=21657@debbugs.gnu.org \
    --cc=dancol@dancol.org \
    --cc=dima@secretsauce.net \
    --cc=luke.powers@openx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.