From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Carlos Pita Newsgroups: gmane.emacs.bugs Subject: bug#51309: 28.0.60; [Feature Request] Allow to customize tab-bar button images Date: Thu, 21 Oct 2021 17:30:51 -0300 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23103"; mail-complaints-to="usenet@ciao.gmane.io" To: 51309@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 21 22:32:30 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mdejl-0005o2-3H for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Oct 2021 22:32:29 +0200 Original-Received: from localhost ([::1]:56144 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mdejj-0000H9-C1 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Oct 2021 16:32:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41040) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mdejK-0008UO-ED for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2021 16:32:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47170) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mdejK-0007Ml-03 for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2021 16:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mdejJ-0001yV-RP for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2021 16:32:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Carlos Pita Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Oct 2021 20:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51309 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16348482705155 (code B ref -1); Thu, 21 Oct 2021 20:32:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 21 Oct 2021 20:31:10 +0000 Original-Received: from localhost ([127.0.0.1]:58716 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdeiU-0001Kq-JY for submit@debbugs.gnu.org; Thu, 21 Oct 2021 16:31:10 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:57706) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdeiT-0001Jk-B2 for submit@debbugs.gnu.org; Thu, 21 Oct 2021 16:31:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40896) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mdeiS-0007Md-Dy for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2021 16:31:09 -0400 Original-Received: from mail-yb1-xb2c.google.com ([2607:f8b0:4864:20::b2c]:43825) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mdeiQ-0006aX-GE for bug-gnu-emacs@gnu.org; Thu, 21 Oct 2021 16:31:08 -0400 Original-Received: by mail-yb1-xb2c.google.com with SMTP id r184so2035653ybc.10 for ; Thu, 21 Oct 2021 13:31:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=Ri4t/IorAxuSuvZ6VwpzyzZo2kKRz//COjEaf8nN/DY=; b=W2qW1V/9qmuThDi3wzaqxmEmqmOhYcIGy47sUWaaqCpt6QNQuEl9DKqFFKzJtxa6nl I9l0OW5NJqH4wumwwcRcgBOrkGrXD1lu5y1sTEyIrHCMEa/qucIV4mliQOdri6Y2bQQf 7vBGdzY1jmjDt2I9OsU5TJZkgujB7C+uWdSUR9Ar5VerUqHj7X3/OuclwkzdbgnyrhZP hALGzM4QtB1HczpkofUyd6m+zq7z/B6ib4yGABP3ODxsrrbTFCG4Giv5jjF9Hhm7jTyb vO+6FhsGdgcbDjaWhJzFwxZT/5bPU53bJoHgT/H5qFqfkqchQ5UKXJ4pNQ/1p3tcMddW cKNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=Ri4t/IorAxuSuvZ6VwpzyzZo2kKRz//COjEaf8nN/DY=; b=M+hCkDq39e6bA1jMSIG1J3e4js+rlcXc81lhgBhzLoW0/IGP0asFMeCRy6gpTnl3fV bkurxuBn9g2VUCnpZMG7QEw2rMiGw1jOM2FvhjzoeFedpVr1UQi54vhEAcy0UZ1Genth hCOWW0FwtGja7AD9yDBfAXQtFtRbewN0SYkDBaiIQag8KFvx5lSyTkJJgkC2G9R2gIbz h+okAqxxMBdv2AeDHvoX4azr0dfg7yEKJi5c9v4iz/UleOjeUBfIdraow3LCLbdIW53R kvSR5e5WY8C8TMpRQVG9JyXpmHuqsx834VtqMen/3mCXvCwh+lBI2AQXzVMvoCFawwRl njQw== X-Gm-Message-State: AOAM530ignBZA4Gha4AlqOsHpg1M3ziXky9sWB0OwsK2rLW2zZaq5IVR eEBTqvFZ++wTEpufQtNzUgSura665Y1aiuXLdzFBJBbIWp4= X-Google-Smtp-Source: ABdhPJy5M8XU88hY5CzKViEi5uylVE5AdfXrkas19Tj1yTYr9hwAfvZJd3F/uxTRnf3T4rTRHab6xVSeY1cfPnow3NE= X-Received: by 2002:a25:5545:: with SMTP id j66mr8470331ybb.288.1634848264175; Thu, 21 Oct 2021 13:31:04 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::b2c; envelope-from=carlosjosepita2@gmail.com; helo=mail-yb1-xb2c.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217816 Archived-At: Hi Juri, > This definitely should be customizable, but it's unclear what do you > want to customize: only the file path to the image, or allow to set > the button propertized with an image with image properties like > :margin/:ascent? Probably the entire (image ...) descriptor. So it's possible to use svg images (with rsvg enabled which now is the default) that will work fine at any resolution. Also, even if the images are correctly centered, they look vertically misaligned wrt text, this is pretty common and tweaking the ascent may help, I guess. And perhaps setting a nil descriptor should be allowed as a way to disable the image altogether. > Could you send such a button string with an image that looks good > on HiDPI screens? Then we could try to make a customizable option > based on your design. Vectorized images will do it. Otherwise you will have to provide pixmaps at twice the resolution and, anyway, with fractional scaling they might end up being blurry again (although not so much as when scaling up x2). I assume there are not many devices with higher scaling factors running emacs out there, yet... There are plenty of free svg icons for light and dark themes here: https://github.com/microsoft/vscode-icons/tree/main/icons. Best regards, Carlos