From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Carlos Pita Newsgroups: gmane.emacs.bugs Subject: bug#37755: Logic in init_fringe_bitmap should be moved to backends (maybe rif->define_fringe_bitmap) Date: Sun, 20 Oct 2019 13:32:36 -0300 Message-ID: References: <83a7a2gxp0.fsf@gnu.org> <83a79v620e.fsf@gnu.org> <83y2xf4d00.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="144104"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37755@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 20 18:34:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iME9j-000bMF-84 for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Oct 2019 18:34:11 +0200 Original-Received: from localhost ([::1]:40434 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iME9h-0004Td-SP for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 Oct 2019 12:34:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33267) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iME8h-0003cF-LE for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2019 12:33:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iME8f-0000Jr-Mu for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2019 12:33:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46362) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iME8e-0000JL-VB for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2019 12:33:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iME8e-00073a-Ro for bug-gnu-emacs@gnu.org; Sun, 20 Oct 2019 12:33:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Carlos Pita Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Oct 2019 16:33:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37755 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37755-submit@debbugs.gnu.org id=B37755.157158917627081 (code B ref 37755); Sun, 20 Oct 2019 16:33:04 +0000 Original-Received: (at 37755) by debbugs.gnu.org; 20 Oct 2019 16:32:56 +0000 Original-Received: from localhost ([127.0.0.1]:55178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iME8W-00072j-5e for submit@debbugs.gnu.org; Sun, 20 Oct 2019 12:32:56 -0400 Original-Received: from mail-yb1-f174.google.com ([209.85.219.174]:41097) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iME8U-00072K-4y for 37755@debbugs.gnu.org; Sun, 20 Oct 2019 12:32:54 -0400 Original-Received: by mail-yb1-f174.google.com with SMTP id 206so3326372ybc.8 for <37755@debbugs.gnu.org>; Sun, 20 Oct 2019 09:32:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6IIXJOMYY0fPW2ba3wsXO4HjK5Y9xUzWPqtRyU81T04=; b=jsFeA4iVfGTrFV9Wr6iowOZKzFcqFuhoVbr9stJI8ypHzkKV1uvNnCNG7N59fS8qta kNd3WemQohazpiwWq67QZ9KYParyH82gum+ql61yQz1iRJ0t4Ln/Xw4o0tzHfiJhPJH3 HR3kN5jqJk98NP6PLxiIwBNwn6isyvvVcVzcljdyE71Sv3IsupIQJSxLgyYf+9FQjwhc 2YMfS/gZnMKJMRUhzztTevzSvktlaFG1C9cl1e1/gN4zoGjyasbf5xgN254MRwCgOa8s 1VMwvx2kc88wzbQDCZYJoLue2RjI4btdCYFuRF92B00CHn4z7EmNz+O/Lvuj5SzALcmS NEaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6IIXJOMYY0fPW2ba3wsXO4HjK5Y9xUzWPqtRyU81T04=; b=MLM+HOvyfkDrCFAeXJ3pvSlLOgieZ+zJVSLam2s7VZYAgHB/LsuienLiIOxGJYddU9 LqDlkTF0IEIu2OOzNF7DW3E4U2eS6X6CNAFxB1JQDtSTbMfn+V/ODVkGEwM0U2GYYVPB q26kA2tvM1slKNz2WobXAC/apC0XvrXsO8R7cTqeMmzyVYLjjptERxuBByTcv4fWFmBN nbYFr5HA8NyyW9ZpFkH0gJzWkeyTnwHHJ0W+0GporBHursTnrefx640WuN1Al9j4wf1P RGZxCd5egD1PglCvLwyqczIs2+OXIang5bYZRNRM1p/EzDACihEsMHLHjUTyMigqFQ9V NFbg== X-Gm-Message-State: APjAAAWJHKx5FXwG9E7pKzFClFgpC+ZnMEDBwpy5KATwXFphLcj4JZqp FR5zlByrQ7FPIIUlYaHFYHTtXqVIJPIRV+ILrnjJyxQtCS8= X-Google-Smtp-Source: APXvYqwdxYPUR30SLIkZ4dpGN5N3cLEQp6v/mf5XpEuR3+OimYPOIuzzYGC2N4gGz9qdhxJBQJZHq1oXewmHXz84U5s= X-Received: by 2002:a25:be48:: with SMTP id d8mr13648557ybm.353.1571589168386; Sun, 20 Oct 2019 09:32:48 -0700 (PDT) In-Reply-To: <83y2xf4d00.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169835 Archived-At: > I don't see that call in the patch, nor any changes in gui_init_fringe > that would modify its current effect. Because nothing changed in gui_init_fringe itself. It did and does: for (bt = NO_FRINGE_BITMAP + 1; bt < MAX_STANDARD_FRINGE_BITMAPS; bt++) rif->define_fringe_bitmap (bt, fb->bits, fb->height, fb->width); for ( ; bt < max_used_fringe_bitmap; bt++) rif->define_fringe_bitmap (bt, fb->bits, fb->height, fb->width); The change affects rif->define_fringe_bitmap instead. It now does: - Create platform-dependent structures from platform-independent bitmaps. Previously this was divided between init and define as: - Init: manipulate platform-independent bitmaps in a platform-dependent way. - Define: use this platform-dependently shuffled bitmaps to create platform-dependent structures. So the only thing that have moved down the initialization sequence is the bit-shuffling gymnastics which, if any, are done in gui_init_fringe now. > Sure, but I said define-fringe-bitmap, which is the Lisp name of > Fdefine_fringe_bitmap. I meant to remark that they do quite different things not that you mistake one for the other, sorry if I wasn't clear. > > I suggest you take a look at the modified pseudo code I posted quite a > > few message above. > > I will, but I'd like to see the full patch as well. You have already seen it :) > If RIF is the problem, we could make each terminal backend do this > initialization unconditionally at dump time. According to my rationale above, I don't see any problem at all. But, as I have said, I ignore everything about the dumper. Yet, I find it hard to believe that whatever this dumper thing is, it needs the bits to be in little-endian, 8-bit per row format, or any other rif-specific pattern. Hope it's clearer now.