From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Carlos Pita Newsgroups: gmane.emacs.bugs Subject: bug#31764: 26.1; Point in VC change log is not centered as documented Date: Fri, 8 Jun 2018 18:28:55 -0300 Message-ID: References: <87vaatf5fn.fsf@gmail.com> <83k1r9t6ew.fsf@gnu.org> <83h8mdt4uq.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1528493291 17764 195.159.176.226 (8 Jun 2018 21:28:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 8 Jun 2018 21:28:11 +0000 (UTC) Cc: 31764@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 08 23:28:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fROvS-0004Mt-NA for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Jun 2018 23:28:02 +0200 Original-Received: from localhost ([::1]:38249 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fROxY-00022b-27 for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Jun 2018 17:30:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59818) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fROxS-00022J-06 for bug-gnu-emacs@gnu.org; Fri, 08 Jun 2018 17:30:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fROxO-0006aN-PJ for bug-gnu-emacs@gnu.org; Fri, 08 Jun 2018 17:30:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60440) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fROxO-0006aF-L5 for bug-gnu-emacs@gnu.org; Fri, 08 Jun 2018 17:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fROxO-0003NM-Dq for bug-gnu-emacs@gnu.org; Fri, 08 Jun 2018 17:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Carlos Pita Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Jun 2018 21:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31764 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31764-submit@debbugs.gnu.org id=B31764.152849336312904 (code B ref 31764); Fri, 08 Jun 2018 21:30:02 +0000 Original-Received: (at 31764) by debbugs.gnu.org; 8 Jun 2018 21:29:23 +0000 Original-Received: from localhost ([127.0.0.1]:40104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fROwl-0003M4-IP for submit@debbugs.gnu.org; Fri, 08 Jun 2018 17:29:23 -0400 Original-Received: from mail-io0-f180.google.com ([209.85.223.180]:41965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fROwj-0003Lq-TI for 31764@debbugs.gnu.org; Fri, 08 Jun 2018 17:29:22 -0400 Original-Received: by mail-io0-f180.google.com with SMTP id t5-v6so17468217ioa.8 for <31764@debbugs.gnu.org>; Fri, 08 Jun 2018 14:29:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=epCUdkROLovKcmZ45GEsm3rBITlynbc6+xXdW1Au0fA=; b=CE8iD3ZmmHs2tkiEZTKGG37ZEhvWIQ5DT4Q7BPALyq4Fb1HZP0M+2Lqqk867kGagEz 67oc8AuRbjVKu80gIjbbkXJlbT0tZbVGb/dlWGrEAVSTlqlUGJfa6kHDzyop8BilfRsy 5bZ1jc/CgFUfUfBGWiLhadaVIqVWxp1LA6/B0p7cnXnboa2bun+GDX5y/W7v5KZZhNFn b9WzgyjA0ZK2iMBNhH/daWifpiVBIBUlG/xtlLpZvHRcOcOatpeORDOeGBCMctHPphcb RIBgbDLr1LpyGulxpmV1a0QV19OdMXKjJZ27AmD41ys5bKRcDvaV4uxXjNy+Oadn4Dfv AgFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=epCUdkROLovKcmZ45GEsm3rBITlynbc6+xXdW1Au0fA=; b=XvC9Qu7zBQ91bG2ewzW9lrJmQAOZwxFsKRLnb91D+2WsOVByKmN7VN2HVDrjH7gKcq A2Y2zDxashpkE912t51Rcz7cUL4/5dwOoHA5kU4vDfhQ09xtr3bL9iCHqzwBu5QsJdvD PNdTb2ngOASgLd2RD/1AY4kOd9w7oW1ojfo41+LJs+HqWYPdgplyECdA+d7k8NCNBNEW azJ6odHT8bDqNBcajr+TJazcDJp3rmYhUSD/btTiD38eaMnyxviX9nwfRY3dmE3U86hY 8vGJjepkv5jUiultQS/zabt1CK8x8YFzMkhgvvuVY3xsehrA2MYT8440wHDz8j3AforB jcwA== X-Gm-Message-State: APt69E1cTShGCJnqraeZWGbTy4CIGHpGQ29O9CliA1vbqWw141yyLA+C PLvzq4axIJ/2eQR+t18akRt6ptFUB9KVEMtFuUk= X-Google-Smtp-Source: ADUXVKJznlT1/MTtpTJpEm72gqpRDsrK3QvtGy03bXW8vahYNeT4bXhywN3RjYYl9bR05nYxxtgSk2Vdkj0n5oGHBE4= X-Received: by 2002:a6b:de14:: with SMTP id v20-v6mr6982045iog.260.1528493356173; Fri, 08 Jun 2018 14:29:16 -0700 (PDT) Original-Received: by 2002:a02:97bb:0:0:0:0:0 with HTTP; Fri, 8 Jun 2018 14:28:55 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147209 Archived-At: AFAICS what I'm observing is consistent with the docstrings of vc-print-log and vc-print-log-internal: vc-print-log It is bound to C-x v l ... If WORKING-REVISION is non-nil, leave point at that revision. ... When called interactively with a prefix argument, prompt for WORKING-REVISION and LIMIT. vc-print-log-internal ... Leave point at WORKING-REVISION, if it is non-nil. So without a prefix I'm indeed passing a nil working-revision argument (I checked this with edebug). Now, when I pass a prefix argument it asks me for a revision (default is the last one) but it's again unable to set the point at that revision. The default revision is shown as "last revision" and its value is nil (so despite the ambiguity in the docstrings, no prefix arg invocation should go to "last revision" too). In the call to vc-log-internal-common goto-location-func is nil. This is the next to last argument which is passed by vc-print-log-internal with value: ;; When it's nil, point really shouldn't move (bug#15322). (when working-revision (lambda (bk) (vc-call-backend bk 'show-log-entry working-revision))) So it's no surprise the point is not being moved around at all. But the comment is not right: nil is "last revision". Now, #15322 is a very old bug so maybe the representation of the "last revision" changed since then?