From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Carlos Pita Newsgroups: gmane.emacs.bugs Subject: bug#37752: Scaling factor inconsistencies between X with and without GTK Date: Tue, 15 Oct 2019 05:09:04 -0300 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="219742"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37752@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 15 10:10:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKHuH-000uyM-7b for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Oct 2019 10:10:13 +0200 Original-Received: from localhost ([::1]:36812 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKHuG-00069X-0X for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Oct 2019 04:10:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53980) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKHu7-00060i-CQ for bug-gnu-emacs@gnu.org; Tue, 15 Oct 2019 04:10:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKHu6-0002mY-Dw for bug-gnu-emacs@gnu.org; Tue, 15 Oct 2019 04:10:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33851) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKHu6-0002mR-8l for bug-gnu-emacs@gnu.org; Tue, 15 Oct 2019 04:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iKHu6-000075-1u for bug-gnu-emacs@gnu.org; Tue, 15 Oct 2019 04:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Carlos Pita Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Oct 2019 08:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37752 X-GNU-PR-Package: emacs Original-Received: via spool by 37752-submit@debbugs.gnu.org id=B37752.1571126963384 (code B ref 37752); Tue, 15 Oct 2019 08:10:01 +0000 Original-Received: (at 37752) by debbugs.gnu.org; 15 Oct 2019 08:09:23 +0000 Original-Received: from localhost ([127.0.0.1]:42672 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKHtT-000068-0U for submit@debbugs.gnu.org; Tue, 15 Oct 2019 04:09:23 -0400 Original-Received: from mail-yw1-f50.google.com ([209.85.161.50]:40907) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKHtR-00005k-FF for 37752@debbugs.gnu.org; Tue, 15 Oct 2019 04:09:21 -0400 Original-Received: by mail-yw1-f50.google.com with SMTP id e205so7032632ywc.7 for <37752@debbugs.gnu.org>; Tue, 15 Oct 2019 01:09:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=kWKfeQiQMde57aBgSalU8acZwCB37VTroEiyYHQsKPw=; b=AJQ6rITm97Sabvja1FS+lbVXgdsnjQ44U+8LYdMH8tc3lDz/GaqFP8XFDRQtQjRBjV 90Bo1C/5gwADVivWhltvmqOXgC80eu4++F4DaYOWCa+rONUwIOt2XvZON5yWrqP/R64k MFg8Q5k28LY7684uKXAk+EijZ9WIxk8DfDxw0BeWoBmpppEWBKGIhsI/BzDnJTLh9mk/ OsYh8V8qZQ//aj70KfNkAEYPx9NrbVnDmfAwwbiGn8PObr4rPZffJyEvoHhWKjaZI9jK aNXhMfjjYHRCHK8bQMVjqvX8ORluJVf7SL/vukdr71zOqyo/I/6XuTYrsXtQfjv8q4I/ jyzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=kWKfeQiQMde57aBgSalU8acZwCB37VTroEiyYHQsKPw=; b=X9EsZhLr41mrcNvEPd/VheQSyPaE98dDGL6go40JO3PHsVJMOuZfhDetc3wdLw4+0Z Mnkoo+rmaJ5UQFa3XYw5YO4DpYK6wZTJw0w3h9N0xkjCUuPPBgjw66QajE3sBoVX1usG swTpOYSavGNmJQ7QMigt7jPxgTWnvqGXRMgKn2uzDKWFfXsrS+9kv71b44tlWX+LQCay Qyp166NlXWqUeIFeJYlWjYUm9GsJ4qVvlbIuqDel2asikRJUuys0VyLS0uChNeYG61Ti XOKYVj85HMFSRRpRNpx06tGRAOmJTOLGo+2XDVuIMplfwEpgyzrWLijGQy769wqBLgC1 Kp5A== X-Gm-Message-State: APjAAAV+wBXyrOil48ucNSO2VlcZ4qaOWr+gTnoQ2cH0xGApHZUp2fei sQbxO9e8E1oylJsDMfz5WWTt3USfK/KmWnrIUb8= X-Google-Smtp-Source: APXvYqzP4PNIppS6LwFDMIbIvGsFlRIPWfm19YYzrYIPt8KHYeESVXWaFUJkjXNNKpC+4BHSXf62jxfsJVA8gggwnGY= X-Received: by 2002:a81:254e:: with SMTP id l75mr15014158ywl.90.1571126955601; Tue, 15 Oct 2019 01:09:15 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169362 Archived-At: > Carlos> int scale =3D 1; > Carlos> #ifdef USE_GTK > Carlos> scale =3D xg_get_scale (f); > Carlos> #endif > Carlos> FRAME_CR_SURFACE (f) =3D > Carlos> cairo_image_surface_create (CAIRO_FORMAT_ARGB32, > Carlos> scale * FRAME_PIXEL_WIDTH (f), > Carlos> scale * FRAME_PIXEL_HEIGHT (f)); > > I can=CA=BCt find that code in master. You're right, this and other xg_get_scale usages were removed wrt emacs-26. Just one of them remains. > Sure, that makes sense. Do you have a test case showing a display > difference, or is this just code cleanup? It's just code cleanup. Best regards -- Carlos