From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Carlos Pita Newsgroups: gmane.emacs.bugs Subject: bug#37756: [PATCH] Wrong initialization of fringe bitmap Date: Mon, 14 Oct 2019 23:39:19 -0300 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000cdaa610594e9e46a" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="210377"; mail-complaints-to="usenet@blaine.gmane.org" To: 37756@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 15 04:40:32 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKCkt-000s36-M9 for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Oct 2019 04:40:11 +0200 Original-Received: from localhost ([::1]:59600 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKCks-0005Z0-HV for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Oct 2019 22:40:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47352) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKCkl-0005W6-I6 for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2019 22:40:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKCkk-0001Xa-KP for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2019 22:40:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33696) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKCkk-0001XW-HG for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2019 22:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iKCkk-0004g5-AT for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2019 22:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Carlos Pita Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Oct 2019 02:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 37756 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.157110717517922 (code B ref -1); Tue, 15 Oct 2019 02:40:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 15 Oct 2019 02:39:35 +0000 Original-Received: from localhost ([127.0.0.1]:42514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKCkJ-0004ez-D2 for submit@debbugs.gnu.org; Mon, 14 Oct 2019 22:39:35 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:55667) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKCkI-0004et-Nf for submit@debbugs.gnu.org; Mon, 14 Oct 2019 22:39:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47150) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKCkH-0005Hp-KH for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2019 22:39:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKCkF-0001Ch-Jn for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2019 22:39:33 -0400 Original-Received: from mail-yb1-xb34.google.com ([2607:f8b0:4864:20::b34]:41196) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKCkF-0001CF-Ek for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2019 22:39:31 -0400 Original-Received: by mail-yb1-xb34.google.com with SMTP id 206so6076696ybc.8 for ; Mon, 14 Oct 2019 19:39:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=vULXWLade1shVMSzrVEq6Foyp46FICeJbQ85hrHv4Lw=; b=gg+TirQgD2pCWt1IAIStGPSAL/h5x/iTWnLXvhjodANXHEvR7A5g2eXsb1KpGctnRV u/Vhhi5WKN3y86e6xKISHk5aQHm85Ria10+6Ba5Nzh/nsfPBDzxgiLNlTTzHwOvcwGHa HFmfEW4KLYYgWzlQDg4C84RRs8LcYSXu9Fj2wj+XFkYHyZEIEe2lvPjdgdCvFI1ff4vQ LtYDc09EXecXdu8uesmQRRBOGcYIjpnwbYXGY0OAL+NEfjpntaliXreJBe/hZaGneTh3 B4iBs/juLYWs2NAEH6tb/04w/DtPHYCepGASbK+2iN+WtoScbu3WJzlGqIDRNHFIa843 BWpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=vULXWLade1shVMSzrVEq6Foyp46FICeJbQ85hrHv4Lw=; b=NrNncolw8rWkpi8qEGku5PaI1MeQMEAypLtlMC6aI4h9SknAVPbIYuGPg/H/yZLheJ 6zgXI1Q+E/cGnx1Olsg8OFuQhN31Z35oPH5/fWkQ0eDxzhtc3n+NqaG49ZkLsTxqzuk3 Ul4nts940LGWceI/40Gn/ZCodtliNwKRDUZvAMme+cIzBThP4GLCN3SgEwL4rTYBBMwg nSK6CdrE7oyvyVSK8bSiYEZ7XX8s1hIsZcWweruPbS1hoVHLwfqsuyA0uR9ZROMX2XxV NQFozE2o1ds5wU0Muq3C5zyZeQsAPmPdwBUb4WUU/mj9ieGVAUsS1IOGJsWwYIn97ctr oepw== X-Gm-Message-State: APjAAAUANL+I3ca9IewBquySDlLsZw34iNnRXNvzt9jaCFT9FOPTIOA+ Ow4LrJj2AX6eLiXXyoRsQ7WNSzLp4aUcxpUORi7kdjLJE5Q= X-Google-Smtp-Source: APXvYqy9ds++saI7I3FMCB3iMhtDmbDvLIsilvurp09YJJhxrGA0VeMw+FejUvZAEtCL4CIN5A/2Kl5zPqFa7K1tBHg= X-Received: by 2002:a25:4d87:: with SMTP id a129mr21661863ybb.82.1571107170516; Mon, 14 Oct 2019 19:39:30 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169350 Archived-At: --000000000000cdaa610594e9e46a Content-Type: text/plain; charset="UTF-8" In fringe.c:1606 you have: xfb = xmalloc (sizeof fb + fb.height * BYTES_PER_BITMAP_ROW); fb.bits = b = ((unsigned short *) ptr_bounds_clip (xfb + 1, fb.height * BYTES_PER_BITMAP_ROW)); xfb = ptr_bounds_clip (xfb, sizeof *xfb); memset (b, 0, fb.height); I might be wrong but it seems to me that the last line should be: memset (b, 0, fb.height * BYTES_PER_BITMAP_ROW); instead. I've attached a patch that does exactly that. Best regards -- Carlos --000000000000cdaa610594e9e46a Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-zero-initialization-of-fringe-bitmap.patch" Content-Disposition: attachment; filename="0001-Fix-zero-initialization-of-fringe-bitmap.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k1r8mcp00 RnJvbSBmZTNmMDQwZDY2MTRlZTRiOTkwZjNmNDI1MmM4OWQ5YTE3YzUyODQ1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBtZW1lcGxleCA8Y2FybG9zam9zZXBpdGFAZ21haWwuY29tPgpE YXRlOiBNb24sIDE0IE9jdCAyMDE5IDIzOjMzOjM3IC0wMzAwClN1YmplY3Q6IFtQQVRDSF0gRml4 IHplcm8gaW5pdGlhbGl6YXRpb24gb2YgZnJpbmdlIGJpdG1hcAoKKiBzcmMvZnJpbmdlLmM6IHRo ZSBzaXplIGluIGJ5dGVzIG9mIGZiLmJpdHMgaXMKICAgIGZiLmhlaWdodCAqIEJZVEVTX1BFUl9C SVRNQVBfUk9XCiAgYW5kIG5vdCBzaW1wbHkgdGhlIG51bWJlciBvZiByb3dzIGZiLmhlaWdodC4K LS0tCiBzcmMvZnJpbmdlLmMgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyks IDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9zcmMvZnJpbmdlLmMgYi9zcmMvZnJpbmdlLmMK aW5kZXggMjJmM2JkYy4uZGI5MTIwOSAxMDA2NDQKLS0tIGEvc3JjL2ZyaW5nZS5jCisrKyBiL3Ny Yy9mcmluZ2UuYwpAQCAtMTYwNyw3ICsxNjA3LDcgQEAgbGlzdCAoQUxJR04gUEVSSU9ESUMpIHdo ZXJlIFBFUklPRElDIG5vbi1uaWwgc3BlY2lmaWVzIHRoYXQgdGhlIGJpdG1hcAogICBmYi5iaXRz ID0gYiA9ICgodW5zaWduZWQgc2hvcnQgKikKIAkJIHB0cl9ib3VuZHNfY2xpcCAoeGZiICsgMSwg ZmIuaGVpZ2h0ICogQllURVNfUEVSX0JJVE1BUF9ST1cpKTsKICAgeGZiID0gcHRyX2JvdW5kc19j bGlwICh4ZmIsIHNpemVvZiAqeGZiKTsKLSAgbWVtc2V0IChiLCAwLCBmYi5oZWlnaHQpOworICBt ZW1zZXQgKGIsIDAsIGZiLmhlaWdodCAqIEJZVEVTX1BFUl9CSVRNQVBfUk9XKTsKIAogICBqID0g MDsKICAgd2hpbGUgKGogPCBmYi5oZWlnaHQpCi0tIAoyLjIwLjEKCg== --000000000000cdaa610594e9e46a--