From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Carlos Pita Newsgroups: gmane.emacs.bugs Subject: bug#37752: Scaling factor inconsistencies between X with and without GTK Date: Mon, 14 Oct 2019 21:21:54 -0300 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="112696"; mail-complaints-to="usenet@blaine.gmane.org" To: 37752@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 15 02:23:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKAcL-000T9N-EF for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Oct 2019 02:23:13 +0200 Original-Received: from localhost ([::1]:58934 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKAcK-0005SI-9d for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 Oct 2019 20:23:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56937) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKAcB-0005Pg-C6 for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2019 20:23:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKAcA-0000cz-C0 for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2019 20:23:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33616) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKAcA-0000cr-8w for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2019 20:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iKAcA-0007Wb-4B for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2019 20:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Carlos Pita Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Oct 2019 00:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 37752 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.157109893228832 (code B ref -1); Tue, 15 Oct 2019 00:23:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 15 Oct 2019 00:22:12 +0000 Original-Received: from localhost ([127.0.0.1]:42437 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKAbL-0007Ux-5v for submit@debbugs.gnu.org; Mon, 14 Oct 2019 20:22:11 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:50809) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKAbK-0007Up-3Y for submit@debbugs.gnu.org; Mon, 14 Oct 2019 20:22:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56849) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKAbJ-0005Dm-1A for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2019 20:22:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKAbH-0008VC-0j for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2019 20:22:07 -0400 Original-Received: from mail-yb1-xb2a.google.com ([2607:f8b0:4864:20::b2a]:33563) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKAbG-0008Uh-T3 for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2019 20:22:06 -0400 Original-Received: by mail-yb1-xb2a.google.com with SMTP id h7so3900360ybp.0 for ; Mon, 14 Oct 2019 17:22:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=3s6t3snYn70pgJL/OVJmjoL+yE/T0MKa6pdILNnGces=; b=cFfuqsBIK4LRr3TDBesi66HH6kVUulughYHIWgzj9bhEKz1UnoCec4Ru4lK7XfdTIu lIYfagYeii7JVZWvjGbkARONNtHxMCLmS0OaC/7TUVb3UK27f+Xz5O1QQC6edg1TaVRH Jmx/dI9LmQnJCafvRLCuKgQeTfi+tQ5DC9FHubwmHDe3lsjc83qsHSXWcRXm5/1Fguq1 8infrcFjvdToy+nF/ZryT4mshUCPJJ9f5K75kDXuXfjIQE5pTYDvIF97SaNdgRk0qd3k 7ViLLxvr6yjcwyKyctt7iMmTnTxlps831tSebMtqd2OXyeq0tr/o2WHoLfgsn+2tzjWd XuGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=3s6t3snYn70pgJL/OVJmjoL+yE/T0MKa6pdILNnGces=; b=Xa/ed6iQclI09ITlVQ8EeEdcVeJeBdWQML8U3Zsa8rL0zoCSK6frNgnQemNJezpL/c Gwh6rPKPA0fBB+/WER9BxfW9aerf4Sfq/eq1B/SXBC1+ZImwb6e9hcZZeBFUoh3Z2jBG QUNQNWEb10pO/R70L2AO6yin6NcTrpwMxMpUazWTPfzsdhFUyhRUGVvwusMhzVv+/6oO Niyb9LZ1BUrGU7r1ASOzs+015Gj8Y6noRG0huqvHMpt1/Rtk0i6gFfko5BL6a0bASS1b EQFa26ogIFiEyE3S07fCGLQ9yt8K1GXuQ8PaA+iOAbmxWAj03c8ishyM8kkm2DxcvZAJ 3nRw== X-Gm-Message-State: APjAAAUHv/kfJhsPdHGmAdvlocs/66wxi9xU89flqfcFx9Kr+paS6zdg pV4R62TcdEIO+4PMeh2wG/PNJoWxQzE4orAAGOPOXiahjV8= X-Google-Smtp-Source: APXvYqxBvhhiliisf/OQZvR/HvbaXviuKj1jKAf4aGRqVw8xIaSDz90JEv0B6sKEkfqj3HIECF+0qet9GURugSw0jlo= X-Received: by 2002:a25:9947:: with SMTP id n7mr21595169ybo.263.1571098925814; Mon, 14 Oct 2019 17:22:05 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169337 Archived-At: In many places in xterm.c you have code like: #ifdef USE_GTK scale = xg_get_scale (f); #endif Sometimes scale is only used in GTK specific code and that's ok. But sometimes it's used in code that's not particular to GTK, for example: int scale = 1; #ifdef USE_GTK scale = xg_get_scale (f); #endif FRAME_CR_SURFACE (f) = cairo_image_surface_create (CAIRO_FORMAT_ARGB32, scale * FRAME_PIXEL_WIDTH (f), scale * FRAME_PIXEL_HEIGHT (f)); Besides, there is x_get_scale_factor, also defined in xterm.c, which computes the scaling factor in a GTK-independent way, and also discriminates between x and y scaling factors. It's only used by x_draw_underwave. I would like to abstract both cases inside x_get_scale_factor, that would then use xg_get_scale if in GTK or compute just one scaling factor (for x or for y) otherwise. Notice that given that the scaling factor is the ratio of the effective resolution to a base resolution of 96 dpi *truncated down* to the nearest integer, AFAICS it's almost impossible to get different scaling factors for x and for y. What do you think? Best regards -- Carlos