From: Carlos Pita <carlosjosepita@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 37756@debbugs.gnu.org
Subject: bug#37756: [PATCH] Wrong initialization of fringe bitmap
Date: Wed, 16 Oct 2019 15:54:01 -0300 [thread overview]
Message-ID: <CAELgYhe7oX8fO5z7fd1Ui61uJ1nwq9huhVcY3RsrnR1O36veyQ@mail.gmail.com> (raw)
In-Reply-To: <83zhi0cze0.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 196 bytes --]
I've done as you asked, Eli. Sorry but I'm still trying to catch up
with many of your conventions.
I'm not sure about how to designate the modified function in the
changelog, since it's a DEFUN.
[-- Attachment #2: 0001-Remove-redundant-and-incomplete-initialization-of-fr.patch --]
[-- Type: text/x-patch, Size: 847 bytes --]
From dd69833c5a1aa6a89cac4cc3b9419c1dabbe50ed Mon Sep 17 00:00:00 2001
From: memeplex <carlosjosepita@gmail.com>
Date: Wed, 16 Oct 2019 13:44:00 -0300
Subject: [PATCH] Remove redundant and incomplete initialization of fringe
bitmap
* src/fringe.c (define-fringe-bitmap): Remove redundant zeroing
of fb.bits that only zeroed half of the array anyway. Bug#37756.
---
src/fringe.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/fringe.c b/src/fringe.c
index 22f3bdc..08bf271 100644
--- a/src/fringe.c
+++ b/src/fringe.c
@@ -1607,7 +1607,6 @@ list (ALIGN PERIODIC) where PERIODIC non-nil specifies that the bitmap
fb.bits = b = ((unsigned short *)
ptr_bounds_clip (xfb + 1, fb.height * BYTES_PER_BITMAP_ROW));
xfb = ptr_bounds_clip (xfb, sizeof *xfb);
- memset (b, 0, fb.height);
j = 0;
while (j < fb.height)
--
2.20.1
next prev parent reply other threads:[~2019-10-16 18:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 2:39 bug#37756: [PATCH] Wrong initialization of fringe bitmap Carlos Pita
2019-10-15 9:47 ` Eli Zaretskii
2019-10-15 10:14 ` Carlos Pita
2019-10-16 17:28 ` Carlos Pita
2019-10-16 18:35 ` Eli Zaretskii
2019-10-16 18:54 ` Carlos Pita [this message]
2019-10-16 19:05 ` Eli Zaretskii
2019-10-16 20:01 ` Carlos Pita
2019-10-17 11:53 ` Alan Third
2019-10-17 15:01 ` Robert Pluim
2019-10-26 10:21 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAELgYhe7oX8fO5z7fd1Ui61uJ1nwq9huhVcY3RsrnR1O36veyQ@mail.gmail.com \
--to=carlosjosepita@gmail.com \
--cc=37756@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.