From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Carlos Pita Newsgroups: gmane.emacs.bugs Subject: bug#37932: [PATCH] Support hidpi fringes and images with Cairo Date: Sat, 26 Oct 2019 03:43:38 -0300 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="194536"; mail-complaints-to="usenet@blaine.gmane.org" To: 37932@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 26 08:44:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iOFo4-000oUO-1P for geb-bug-gnu-emacs@m.gmane.org; Sat, 26 Oct 2019 08:44:12 +0200 Original-Received: from localhost ([::1]:38396 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iOFo2-0007Ef-A1 for geb-bug-gnu-emacs@m.gmane.org; Sat, 26 Oct 2019 02:44:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42340) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iOFnv-0007Bf-7k for bug-gnu-emacs@gnu.org; Sat, 26 Oct 2019 02:44:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iOFnu-0007ls-7f for bug-gnu-emacs@gnu.org; Sat, 26 Oct 2019 02:44:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59049) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iOFnu-0007le-2W for bug-gnu-emacs@gnu.org; Sat, 26 Oct 2019 02:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iOFnt-0004If-UV for bug-gnu-emacs@gnu.org; Sat, 26 Oct 2019 02:44:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Carlos Pita Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Oct 2019 06:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37932 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37932-submit@debbugs.gnu.org id=B37932.157207223716511 (code B ref 37932); Sat, 26 Oct 2019 06:44:01 +0000 Original-Received: (at 37932) by debbugs.gnu.org; 26 Oct 2019 06:43:57 +0000 Original-Received: from localhost ([127.0.0.1]:39637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iOFnp-0004IE-4X for submit@debbugs.gnu.org; Sat, 26 Oct 2019 02:43:57 -0400 Original-Received: from mail-yw1-f52.google.com ([209.85.161.52]:43159) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iOFnn-0004I2-BU for 37932@debbugs.gnu.org; Sat, 26 Oct 2019 02:43:55 -0400 Original-Received: by mail-yw1-f52.google.com with SMTP id g77so1779435ywb.10 for <37932@debbugs.gnu.org>; Fri, 25 Oct 2019 23:43:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=89DLG0vbCkshAPhyTIjIDDWTenSOStIYAzcujFKhMaA=; b=DrbyRGoEGEQf/1yVSKmV516ausU9zthEeNR/Ws53yefFwFwLj/hZKqdnFbQOAh1x7m txVBWb/nFD7AuNb6E0G/FhVFbR+X2q4UAVinRpKWlWggyGuIs4bR6/DeWA98d7AB8PBX hTknx+JVkdGgDAVj9+YxaJSTrggb5uRQ0uMNvoip0NkeA+Q3ftIi3Ezf2OoqhcqkQE4c pbkOiF647oVIIqrOdu6lUB7R9Nw9IBiu3rabwoCALiRRpaxrJE6IJFbjTE+/EfdDhbeR s2UuPRWA3Z95F7oAyAU3A4qD6wmrmge9MVXAV+sjARpT6iAozXwguV+GhaY4zu60hY2R Lz/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=89DLG0vbCkshAPhyTIjIDDWTenSOStIYAzcujFKhMaA=; b=C3q2zwE1QlDmtXhr91TOvadAE334JNkEy3gi4xczAkPK1b5t7URUW1fY9iz8e85vAc H7XWe5GOZwYp8E2KQ5W+i1Sw+fbmWTCP3JQeS15CJ+smeM0PChOtk+SbGlHvj9DS53l7 q13ogEqKsLgAfFZkyi69x8I/XHwptc3gFyWrSMjOb5ZE/GaxJO+JUUkbDXGIbF2320P+ 0JHNjB8CKxND3di5NtSNX4gXJXKfR5OyOSOv3jCWznwqYdRH6053bYeK/o+DaSoSGTVl LxvX5yqaYkiK4hFUIwNNsptj/PSK8k5pfW9JofhF/AiTi/qF5e6LrhDp8Oqo2dFKsmPP wroQ== X-Gm-Message-State: APjAAAXeB/GNJPnXFDYvO063CcimWt50u2NsJPTy1AC4FWKcGsIq8jTI KJP/aMAcLHqGagTyEI8BH4AOEXgbePhq8qcMIiiQIqCzl7U= X-Google-Smtp-Source: APXvYqwvGvyUqpjRiL4V7PGLrE5WPHISyco4H0yvOXtG2jYaHe2PjaLCNaB/LfDi9zCUMayjvVIhsvXto33mKAJxKJ4= X-Received: by 2002:a81:2849:: with SMTP id o70mr5351049ywo.80.1572072229412; Fri, 25 Oct 2019 23:43:49 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170176 Archived-At: Ok, the problem is that widget-image-insert (in wid-edit.el) is directly inserting the image with insert-image, without creating the spec with create-image first, so the spec doesn't get the :scale property. Similarly, gamegrid.el is creating its own, unscaled, image spec. IMO there is something smelly in using the :scale attribute like create-image does, scaling to compensate hidpi is a very different concern than "application level" scaling. Anyway, do you think that: 1. I should fix those two modules to use create-image or at least add :scale, or 2. put a mark to unscaled images so that they are always scaled at the end in x_cr_draw_image, or 3. disable this auto :scale feature when the new low-level scaling mechanism is on ? I think I prefer 3.